Mercurial > hg > thermostat-ng > web-client
changeset 121:bfe06b87ea58
Fix extract-class service when using undefined value
Reviewed-by: aazores
Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2017-July/024068.html
| author | Alex Macdonald <almacdon@redhat.com> |
|---|---|
| date | Wed, 12 Jul 2017 09:53:26 -0400 |
| parents | e89605afe387 |
| children | 7f7956d7b541 |
| files | src/app/shared/filters/extract-class.filter.js src/app/shared/services/extract-class.service.js src/app/shared/services/extract-class.service.spec.js |
| diffstat | 3 files changed, 7 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/src/app/shared/filters/extract-class.filter.js Tue Jul 11 14:43:32 2017 -0400 +++ b/src/app/shared/filters/extract-class.filter.js Wed Jul 12 09:53:26 2017 -0400 @@ -28,7 +28,7 @@ export default function filterProvider (extractClassService) { 'ngInject'; return extractClassService.extract; -}; +} const filterName = 'extractClass';
--- a/src/app/shared/services/extract-class.service.js Tue Jul 11 14:43:32 2017 -0400 +++ b/src/app/shared/services/extract-class.service.js Wed Jul 12 09:53:26 2017 -0400 @@ -26,7 +26,8 @@ */ class ExtractClassService { - extract (fullClassName, includePkg = false) { + extract (fullClassName = '', includePkg = false) { + if (fullClassName.indexOf('.') === -1) { return fullClassName; }
--- a/src/app/shared/services/extract-class.service.spec.js Tue Jul 11 14:43:32 2017 -0400 +++ b/src/app/shared/services/extract-class.service.spec.js Wed Jul 12 09:53:26 2017 -0400 @@ -55,4 +55,8 @@ it('should strip paths to JARs', () => { svc.extract('/path/to/foo.JaR').should.equal('foo.JaR'); }); + + it('should return an empty string if given undef', () => { + svc.extract().should.equal(''); + }); });