Mercurial > hg > thermostat-ng > web-client

changeset 128:2d6a8d1d5f41

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Add CONTRIBUTING file and Naming Consistency Cleanup This patch adds the basis for a contributing file, and outlines naming conventions and styles to be used throughout the project. There has also been some cleanup of controller names to adhere to this new contributing file. Reviewed-by: aazores Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2017-July/024110.html
author Alex Macdonald <almacdon@redhat.com>
date Fri, 14 Jul 2017 09:18:32 -0400
parents ef302144b90a
children b4fe7a10f0d0
files CONTRIBUTING.md src/app/app.controller.js src/app/app.controller.spec.js src/app/app.module.js src/app/app.routing.js src/app/auth-interceptor.factory.js src/app/auth-interceptor.factory.spec.js src/app/components/auth/auth.module.spec.js src/app/components/jvm-info/jvm-gc/jvm-gc.controller.js src/app/components/jvm-info/jvm-gc/jvm-gc.controller.spec.js src/app/components/jvm-info/jvm-gc/jvm-gc.module.js src/app/components/jvm-info/jvm-gc/jvm-gc.routing.js src/app/components/jvm-info/jvm-info.controller.js src/app/components/jvm-info/jvm-info.controller.spec.js src/app/components/jvm-info/jvm-info.module.js src/app/components/jvm-info/jvm-info.routing.js src/app/components/jvm-info/jvm-memory/jvm-memory.controller.js src/app/components/jvm-info/jvm-memory/jvm-memory.controller.spec.js src/app/components/jvm-info/jvm-memory/jvm-memory.module.js src/app/components/jvm-info/jvm-memory/jvm-memory.routing.js src/app/components/jvm-list/jvm-list.controller.js src/app/components/jvm-list/jvm-list.controller.spec.js src/app/components/jvm-list/jvm-list.module.js src/app/components/jvm-list/jvm-list.routing.js src/app/components/system-info/system-cpu.controller.js src/app/components/system-info/system-cpu.controller.spec.js src/app/components/system-info/system-info.controller.js src/app/components/system-info/system-info.controller.spec.js src/app/components/system-info/system-info.html src/app/components/system-info/system-info.module.js src/app/components/system-info/system-info.routing.js src/app/components/system-info/system-memory.controller.js src/app/components/system-info/system-memory.controller.spec.js src/app/index.html src/app/shared/directives/dismissible-error-message/dismissible-error-message.directive.js src/app/shared/directives/dismissible-error-message/dismissible-error-message.html src/app/shared/services/extract-class.service.js src/app/shared/services/scale-bytes.service.js
diffstat 38 files changed, 160 insertions(+), 77 deletions(-) [+]
line wrap: on
line diff
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/CONTRIBUTING.md	Fri Jul 14 09:18:32 2017 -0400
@@ -0,0 +1,80 @@
+# Contributing to Thermostat Web-Client
+
+This guide provides an introduction and some tips for developing Thermostat Web-Client
+
+## Style
+
+### General Code Style
+* License header goes at the top of every file
+* Indent with 2 spaces instead of tabs
+* Avoid trailing spaces
+* See .eslintrc.yaml for more details
+
+### AngularJS
+* ECMAScript 2015 (ES6) Language Specification
+* Fat Arrow Functions where possible
+````
+let fooFunction = (param1, ..., paramN) => { ... };
+````
+* One space between function names and parameters
+````
+function fooFunction () { ... }
+````
+* If more than one, module dependencies and attributes should be listed one per line
+````
+angular
+  .module('fooModule', [
+    dependencyA,
+    dependencyB,
+    ...
+  ])
+  .controller('FooController', FooController);
+````
+### Testing
+* Every component foo.js should have an associated foo.spec.js file
+* The spec file should be located in the same folder as the file it's testing
+* Tests are run using the Mocha test framework & Karma test runner 
+* describe() should write the name of the code being tested
+````
+describe('FooController', () => { ... });
+````
+* it() should describe the expected behaviour of the unit test
+````
+it('should export constant ...', () => { ... });
+````
+## Naming Conventions
+Controllers
+* PascalCase
+* Component + 'Controller'
+* e.g., AppController
+
+Directives
+* lowerCamelCase
+* e.g., dismissibleErrorMessageDirective
+
+Factories
+* lowerCamelCase
+* eg., authInterceptorFactory
+
+Filters
+* lowerCamelCase
+* These will have 'Filter' appended to their names
+* i.e., bigIntToDate will become bigIntToDateFilter
+
+Modules
+* lowerCamelCase
+* component + 'Module'
+* e.g., appModule
+
+Routers
+* lowerCamelCase
+* e.g., appRouter
+
+Router States
+* lowerCamelCase
+* Should be named after the url it will be reaching
+* e.g., jvmList will be the state for /jvm-list
+
+Services
+* lowerCamelCase
+* e.g., bigIntToDateService
--- a/src/app/app.controller.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/app.controller.js	Fri Jul 14 09:18:32 2017 -0400
@@ -46,7 +46,7 @@
   }
 }
 
-let name = 'appController';
+let name = 'AppController';
 export default angular
   .module(name, [authModule])
   .controller(name, AppController)
--- a/src/app/app.controller.spec.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/app.controller.spec.js	Fri Jul 14 09:18:32 2017 -0400
@@ -32,7 +32,7 @@
     $provide.value('$transitions', { onBefore: angular.noop });
   }));
 
-  beforeEach(angular.mock.module('appController'));
+  beforeEach(angular.mock.module('AppController'));
 
   ['testing', 'development', 'production'].forEach(env => {
     describe(env + ' $scope', () => {
@@ -47,7 +47,7 @@
           logout: sinon.spy()
         };
 
-        $controller('appController', {
+        $controller('AppController', {
           $scope: scope,
           environment: env,
           authService: authService
@@ -87,7 +87,7 @@
         logout: sinon.spy()
       };
 
-      $controller('appController', {
+      $controller('AppController', {
         $scope: scope,
         environment: 'testing',
         authService: authService
--- a/src/app/app.module.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/app.module.js	Fri Jul 14 09:18:32 2017 -0400
@@ -35,8 +35,8 @@
 import filters from 'shared/filters/filters.module.js';
 import services from 'shared/services/services.module.js';
 import appRouting from './app.routing.js';
-import authInterceptor from './auth-interceptor.factory.js';
-import appController from './app.controller.js';
+import authInterceptorFactory from './auth-interceptor.factory.js';
+import AppController from './app.controller.js';
 
 require.ensure([], () => {
   require('angular-patternfly/node_modules/patternfly/dist/css/patternfly.css');
@@ -55,12 +55,12 @@
     services,
     filters,
     appRouting,
-    authInterceptor,
-    appController
+    authInterceptorFactory,
+    AppController
   ])
   .config($httpProvider => {
     'ngInject';
-    $httpProvider.interceptors.push(authInterceptor);
+    $httpProvider.interceptors.push(authInterceptorFactory);
   });
 
 authModBootstrap(process.env.NODE_ENV, () => angular.element(() => angular.bootstrap(document, [appModule.name])));
--- a/src/app/app.routing.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/app.routing.js	Fri Jul 14 09:18:32 2017 -0400
@@ -25,7 +25,7 @@
  * exception statement from your version.
  */
 
-let errorModule = angular
+let errorRouter = angular
   .module('error.routing', ['ui.router'])
   .config(errorRouting);
 
@@ -48,7 +48,7 @@
   });
 }
 
-let componentRoutingModules = [errorModule.name];
+let componentRoutingModules = [errorRouter.name];
 let req = require.context('./components', true, /\.routing\.js/);
 req.keys().forEach(k => componentRoutingModules.push(req(k).default));
 
@@ -66,8 +66,8 @@
       });
     return defer.promise;
   });
-};
+}
 appRouter.run(transitionHook);
 export default appRouter.name;
 
-export { errorModule, errorRouting, transitionHook };
+export { errorRouter, errorRouting, transitionHook };
--- a/src/app/auth-interceptor.factory.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/auth-interceptor.factory.js	Fri Jul 14 09:18:32 2017 -0400
@@ -27,7 +27,7 @@
 
 import authModule from './components/auth/auth.module.js';
 
-let name = 'authInterceptor';
+let name = 'authInterceptorFactory';
 
 export default angular
   .module(name, [authModule])
--- a/src/app/auth-interceptor.factory.spec.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/auth-interceptor.factory.spec.js	Fri Jul 14 09:18:32 2017 -0400
@@ -49,11 +49,11 @@
       $provide.value('authService', authSvc);
     });
 
-    angular.mock.module('authInterceptor');
+    angular.mock.module('authInterceptorFactory');
 
-    angular.mock.inject(authInterceptor => {
+    angular.mock.inject(authInterceptorFactory => {
       'ngInject';
-      interceptor = authInterceptor;
+      interceptor = authInterceptorFactory;
     });
   });
 
--- a/src/app/components/auth/auth.module.spec.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/auth/auth.module.spec.js	Fri Jul 14 09:18:32 2017 -0400
@@ -26,7 +26,7 @@
  */
 
 // not a 'real' angular module since this is used for bootstrapping Angular to begin with
-import {config} from './auth.module.js';
+import { config } from './auth.module.js';
 
 describe('AuthModule', () => {
 
--- a/src/app/components/jvm-info/jvm-gc/jvm-gc.controller.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/jvm-info/jvm-gc/jvm-gc.controller.js	Fri Jul 14 09:18:32 2017 -0400
@@ -227,5 +227,5 @@
     service,
     filters
   ])
-  .controller('jvmGcController', JvmGcController)
+  .controller('JvmGcController', JvmGcController)
   .name;
--- a/src/app/components/jvm-info/jvm-gc/jvm-gc.controller.spec.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/jvm-info/jvm-gc/jvm-gc.controller.spec.js	Fri Jul 14 09:18:32 2017 -0400
@@ -56,7 +56,7 @@
       getJvmGcData: sinon.stub().returns(promise)
     };
 
-    ctrl = $controller('jvmGcController', {
+    ctrl = $controller('JvmGcController', {
       jvmId: 'foo-jvmId',
       $scope: scope,
       $interval: interval,
--- a/src/app/components/jvm-info/jvm-gc/jvm-gc.module.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/jvm-info/jvm-gc/jvm-gc.module.js	Fri Jul 14 09:18:32 2017 -0400
@@ -25,12 +25,12 @@
  * exception statement from your version.
  */
 
-import controller from './jvm-gc.controller.js';
+import JvmGcController from './jvm-gc.controller.js';
 import service from './jvm-gc.service.js';
 
 export default angular
   .module('jvmGc', [
-    controller,
+    JvmGcController,
     service
   ])
   .name;
--- a/src/app/components/jvm-info/jvm-gc/jvm-gc.routing.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/jvm-info/jvm-gc/jvm-gc.routing.js	Fri Jul 14 09:18:32 2017 -0400
@@ -30,7 +30,7 @@
 
   $stateProvider.state('jvmInfo.jvmGc', {
     url: '/garbage-collection',
-    controller: 'jvmGcController as ctrl',
+    controller: 'JvmGcController as ctrl',
     templateProvider: $q => {
       'ngInject';
       return $q(resolve =>
--- a/src/app/components/jvm-info/jvm-info.controller.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/jvm-info/jvm-info.controller.js	Fri Jul 14 09:18:32 2017 -0400
@@ -60,5 +60,5 @@
     filters,
     service
   ])
-  .controller('jvmInfoController', JvmInfoController)
+  .controller('JvmInfoController', JvmInfoController)
   .name;
--- a/src/app/components/jvm-info/jvm-info.controller.spec.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/jvm-info/jvm-info.controller.spec.js	Fri Jul 14 09:18:32 2017 -0400
@@ -48,7 +48,7 @@
       getJvmInfo: sinon.stub().returns(promise)
     };
 
-    ctrl = $controller('jvmInfoController', {
+    ctrl = $controller('JvmInfoController', {
       $scope: scope,
       $state: state,
       systemId: 'bar-systemId',
--- a/src/app/components/jvm-info/jvm-info.module.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/jvm-info/jvm-info.module.js	Fri Jul 14 09:18:32 2017 -0400
@@ -25,12 +25,12 @@
  * exception statement from your version.
  */
 
-import controller from './jvm-info.controller.js';
+import JvmInfoController from './jvm-info.controller.js';
 import service from './jvm-info.service.js';
 
 export default angular
   .module('jvmInfo', [
-    controller,
+    JvmInfoController,
     service
   ])
   .name;
--- a/src/app/components/jvm-info/jvm-info.routing.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/jvm-info/jvm-info.routing.js	Fri Jul 14 09:18:32 2017 -0400
@@ -40,7 +40,7 @@
         )
       );
     },
-    controller: 'jvmInfoController as ctrl',
+    controller: 'JvmInfoController as ctrl',
     resolve: {
       loadJvmInfo: ($q, $ocLazyLoad) => {
         'ngInject';
--- a/src/app/components/jvm-info/jvm-memory/jvm-memory.controller.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/jvm-info/jvm-memory/jvm-memory.controller.js	Fri Jul 14 09:18:32 2017 -0400
@@ -151,5 +151,5 @@
     filters,
     service
   ])
-  .controller('jvmMemoryController', JvmMemoryController)
+  .controller('JvmMemoryController', JvmMemoryController)
   .name;
--- a/src/app/components/jvm-info/jvm-memory/jvm-memory.controller.spec.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/jvm-info/jvm-memory/jvm-memory.controller.spec.js	Fri Jul 14 09:18:32 2017 -0400
@@ -54,7 +54,7 @@
       })
     };
 
-    ctrl = $controller('jvmMemoryController', {
+    ctrl = $controller('JvmMemoryController', {
       jvmId: 'foo-jvmId',
       $scope: scope,
       $interval: interval,
--- a/src/app/components/jvm-info/jvm-memory/jvm-memory.module.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/jvm-info/jvm-memory/jvm-memory.module.js	Fri Jul 14 09:18:32 2017 -0400
@@ -25,12 +25,12 @@
  * exception statement from your version.
  */
 
-import controller from './jvm-memory.controller.js';
+import JvmMemoryController from './jvm-memory.controller.js';
 import service from './jvm-memory.service.js';
 
 export default angular
   .module('jvmMemory', [
-    controller,
+    JvmMemoryController,
     service
   ])
   .name;
--- a/src/app/components/jvm-info/jvm-memory/jvm-memory.routing.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/jvm-info/jvm-memory/jvm-memory.routing.js	Fri Jul 14 09:18:32 2017 -0400
@@ -30,7 +30,7 @@
 
   $stateProvider.state('jvmInfo.jvmMemory', {
     url: '/memory',
-    controller: 'jvmMemoryController as ctrl',
+    controller: 'JvmMemoryController as ctrl',
     templateProvider: $q => {
       'ngInject';
       return $q(resolve =>
--- a/src/app/components/jvm-list/jvm-list.controller.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/jvm-list/jvm-list.controller.js	Fri Jul 14 09:18:32 2017 -0400
@@ -27,7 +27,7 @@
 
 import filters from 'shared/filters/filters.module.js';
 import service from './jvm-list.service.js';
-import dismissibleErrorMessage from "shared/directives/dismissible-error-message/dismissible-error-message.directive.js";
+import dismissibleErrorMessage from 'shared/directives/dismissible-error-message/dismissible-error-message.directive.js';
 
 class JvmListController {
   constructor (jvmListService, $scope, $location, $timeout, $anchorScroll) {
@@ -104,5 +104,5 @@
     filters,
     service
   ])
-  .controller('jvmListController', JvmListController)
+  .controller('JvmListController', JvmListController)
   .name;
--- a/src/app/components/jvm-list/jvm-list.controller.spec.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/jvm-list/jvm-list.controller.spec.js	Fri Jul 14 09:18:32 2017 -0400
@@ -47,7 +47,7 @@
     svc = {
       getSystems: sinon.stub().returns(promise.promise)
     };
-    ctrl = $controller('jvmListController', {
+    ctrl = $controller('JvmListController', {
       jvmListService: svc,
       $location: location,
       $scope: scope,
--- a/src/app/components/jvm-list/jvm-list.module.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/jvm-list/jvm-list.module.js	Fri Jul 14 09:18:32 2017 -0400
@@ -25,12 +25,12 @@
  * exception statement from your version.
  */
 
-import controller from './jvm-list.controller.js';
+import JvmListController from './jvm-list.controller.js';
 import service from './jvm-list.service.js';
 
 export default angular
   .module('jvmList', [
-    controller,
+    JvmListController,
     service
   ])
   .name;
--- a/src/app/components/jvm-list/jvm-list.routing.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/jvm-list/jvm-list.routing.js	Fri Jul 14 09:18:32 2017 -0400
@@ -37,7 +37,7 @@
         )
       );
     },
-    controller: 'jvmListController as ctrl',
+    controller: 'JvmListController as ctrl',
     resolve: {
       loadJvmList: ($q, $ocLazyLoad) => {
         'ngInject';
--- a/src/app/components/system-info/system-cpu.controller.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/system-info/system-cpu.controller.js	Fri Jul 14 09:18:32 2017 -0400
@@ -74,5 +74,5 @@
     filters,
     service
   ])
-  .controller('systemCpuController', SystemCpuController)
+  .controller('SystemCpuController', SystemCpuController)
   .name;
--- a/src/app/components/system-info/system-cpu.controller.spec.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/system-info/system-cpu.controller.spec.js	Fri Jul 14 09:18:32 2017 -0400
@@ -52,7 +52,7 @@
 
     interval = sinon.stub().returns('interval-sentinel');
     interval.cancel = sinon.stub().returns(interval.sentinel);
-    controller = $controller('systemCpuController', {
+    controller = $controller('SystemCpuController', {
       systemInfoService: service,
       $scope: scope,
       $interval: interval
--- a/src/app/components/system-info/system-info.controller.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/system-info/system-info.controller.js	Fri Jul 14 09:18:32 2017 -0400
@@ -56,5 +56,5 @@
     filters,
     service
   ])
-  .controller('systemInfoController', SystemInfoController)
+  .controller('SystemInfoController', SystemInfoController)
   .name;
--- a/src/app/components/system-info/system-info.controller.spec.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/system-info/system-info.controller.spec.js	Fri Jul 14 09:18:32 2017 -0400
@@ -39,7 +39,7 @@
     let systemInfoService = {
       getSystemInfo: () => promise.promise
     };
-    ctrl = $controller('systemInfoController', {
+    ctrl = $controller('SystemInfoController', {
       systemId: 'foo-systemId',
       systemInfoService: systemInfoService,
       $scope: scope,
--- a/src/app/components/system-info/system-info.html	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/system-info/system-info.html	Fri Jul 14 09:18:32 2017 -0400
@@ -46,7 +46,7 @@
     <div class="row row-cards-pf">
       <div class="container container-cards-pf">
         <!-- System-CPU Donut Chart -->
-        <div class="col-xs-12 col-md-6" ng-controller="systemCpuController as ctrl">
+        <div class="col-xs-12 col-md-6" ng-controller="SystemCpuController as ctrl">
           <div class="card-pf card-pf-view">
             <div class="card-pf-heading">
               <label class="card-pf-title">CPU Usage</label>
@@ -56,7 +56,7 @@
             </div>
           </div>
         </div>
-        <div class="system-memory-charts" ng-controller="systemMemoryController as ctrl">
+        <div class="system-memory-charts" ng-controller="SystemMemoryController as ctrl">
           <!-- System-Memory Donut Chart -->
           <div class="col-xs-12 col-md-6">
             <div class="card-pf card-pf-view">
--- a/src/app/components/system-info/system-info.module.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/system-info/system-info.module.js	Fri Jul 14 09:18:32 2017 -0400
@@ -25,16 +25,16 @@
  * exception statement from your version.
  */
 
-import controller from './system-info.controller.js';
-import cpuController from './system-cpu.controller.js';
-import memoryController from './system-memory.controller.js';
+import SystemInfocontroller from './system-info.controller.js';
+import SystemCpuController from './system-cpu.controller.js';
+import SystemMemoryController from './system-memory.controller.js';
 import service from './system-info.service.js';
 
 export default angular
   .module('systemInfo', [
-    controller,
-    cpuController,
-    memoryController,
+    SystemInfocontroller,
+    SystemCpuController,
+    SystemMemoryController,
     service
   ])
   .name;
--- a/src/app/components/system-info/system-info.routing.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/system-info/system-info.routing.js	Fri Jul 14 09:18:32 2017 -0400
@@ -37,7 +37,7 @@
         )
       );
     },
-    controller: 'systemInfoController as ctrl',
+    controller: 'SystemInfoController as ctrl',
     resolve: {
       loadSystemInfo: ($q, $ocLazyLoad) => {
         'ngInject';
--- a/src/app/components/system-info/system-memory.controller.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/system-info/system-memory.controller.js	Fri Jul 14 09:18:32 2017 -0400
@@ -193,5 +193,5 @@
     filters,
     service
   ])
-  .controller('systemMemoryController', SystemMemoryController)
+  .controller('SystemMemoryController', SystemMemoryController)
   .name;
--- a/src/app/components/system-info/system-memory.controller.spec.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/components/system-info/system-memory.controller.spec.js	Fri Jul 14 09:18:32 2017 -0400
@@ -64,7 +64,7 @@
     interval.cancel = sinon.stub().returns(interval.sentinel);
 
 
-    controller = $controller('systemMemoryController', {
+    controller = $controller('SystemMemoryController', {
       systemId: 'foo-systemId',
       systemInfoService: service,
       $scope: scope,
--- a/src/app/index.html	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/index.html	Fri Jul 14 09:18:32 2017 -0400
@@ -10,7 +10,7 @@
     <meta name="viewport" content="width=device-width"/>
 </head>
 <body id="pf-app" class="pf-body apf-body ng-cloak">
-  <div ng-controller="appController">
+  <div ng-controller="AppController">
     <nav class="navbar navbar-pf-vertical">
       <div class="navbar-header">
         <a ui-sref="landing" class="navbar-brand">
--- a/src/app/shared/directives/dismissible-error-message/dismissible-error-message.directive.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/shared/directives/dismissible-error-message/dismissible-error-message.directive.js	Fri Jul 14 09:18:32 2017 -0400
@@ -25,20 +25,19 @@
  * exception statement from your version.
  */
 
-import dismissibleErrorMessageTemplate from './dismissible-error-message.html'
+import dismissibleErrorMessageTemplate from './dismissible-error-message.html';
 
 export let dismissibleErrorMessageFunc = () => {
-    return {
-        restrict: 'E',
-        scope: {
-            errTitle: '<',
-            errMessage: '<'
-        },
-        template: dismissibleErrorMessageTemplate
-    }
-}
+  return {
+    restrict: 'E',
+    scope: {
+      errTitle: '<',
+      errMessage: '<'
+    },
+    template: dismissibleErrorMessageTemplate
+  };
+};
 
-export default angular.module('directives.dismissible-error-message',
-    [
-    ]
-).directive("dismissibleErrorMessage", dismissibleErrorMessageFunc);
+export default angular
+    .module('directives.dismissible-error-message', [])
+    .directive('dismissibleErrorMessage', dismissibleErrorMessageFunc);
--- a/src/app/shared/directives/dismissible-error-message/dismissible-error-message.html	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/shared/directives/dismissible-error-message/dismissible-error-message.html	Fri Jul 14 09:18:32 2017 -0400
@@ -1,9 +1,9 @@
 <div ng-hide="showElement" class="toast-pf alert alert-warning alert-dismissable" >
-    <button type="button" class="close" data-dismiss="alert" aria-hidden="true" ng-click="showElement=true">
-        <span class="pficon pficon-close"></span>
-    </button>
+  <button type="button" class="close" data-dismiss="alert" aria-hidden="true" ng-click="showElement=true">
+    <span class="pficon pficon-close"></span>
+  </button>
 
-    <span class="pficon pficon-warning-triangle-o"></span>
-    <strong>{{errTitle}}</strong> 
-    {{errMessage}}
+  <span class="pficon pficon-warning-triangle-o"></span>
+  <strong>{{errTitle}}</strong> 
+  {{errMessage}}
 </div>
--- a/src/app/shared/services/extract-class.service.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/shared/services/extract-class.service.js	Fri Jul 14 09:18:32 2017 -0400
@@ -57,4 +57,6 @@
   }
 }
 
-angular.module('app.services').service('extractClassService', ExtractClassService);
+angular
+  .module('app.services')
+  .service('extractClassService', ExtractClassService);
--- a/src/app/shared/services/scale-bytes.service.js	Thu Jul 13 10:44:20 2017 -0400
+++ b/src/app/shared/services/scale-bytes.service.js	Fri Jul 14 09:18:32 2017 -0400
@@ -66,4 +66,6 @@
   }
 }
 
-angular.module('app.services').service('scaleBytesService', ScaleBytesService);
+angular
+  .module('app.services')
+  .service('scaleBytesService', ScaleBytesService);