Mercurial > hg > release > thermostat-1.6
changeset 1733:ac22225863ac
Be explicit when profiling gathered no results
Reviewed-by: jerboaa
Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2015-August/015256.html
author | Omair Majid <omajid@redhat.com> |
---|---|
date | Mon, 17 Aug 2015 11:54:56 -0400 |
parents | 28d1691c7203 |
children | 16960ccfe1a0 |
files | vm-profiler/client-swing/src/main/java/com/redhat/thermostat/vm/profiler/client/swing/internal/LocaleResources.java vm-profiler/client-swing/src/main/java/com/redhat/thermostat/vm/profiler/client/swing/internal/SwingVmProfileView.java vm-profiler/client-swing/src/main/resources/com/redhat/thermostat/vm/profiler/client/swing/internal/strings.properties |
diffstat | 3 files changed, 12 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/vm-profiler/client-swing/src/main/java/com/redhat/thermostat/vm/profiler/client/swing/internal/LocaleResources.java Wed Aug 12 20:06:57 2015 -0400 +++ b/vm-profiler/client-swing/src/main/java/com/redhat/thermostat/vm/profiler/client/swing/internal/LocaleResources.java Mon Aug 17 11:54:56 2015 -0400 @@ -54,6 +54,8 @@ PROFILER_RESULTS_METHOD, PROFILER_RESULTS_PERCENTAGE_TIME, PROFILER_RESULTS_TIME, + + PROFILER_NO_RESULTS, ; static final String RESOURCE_BUNDLE = "com.redhat.thermostat.vm.profiler.client.swing.internal.strings";
--- a/vm-profiler/client-swing/src/main/java/com/redhat/thermostat/vm/profiler/client/swing/internal/SwingVmProfileView.java Wed Aug 12 20:06:57 2015 -0400 +++ b/vm-profiler/client-swing/src/main/java/com/redhat/thermostat/vm/profiler/client/swing/internal/SwingVmProfileView.java Mon Aug 17 11:54:56 2015 -0400 @@ -306,6 +306,14 @@ // delete all existing data tableModel.setRowCount(0); + if (results.getMethodInfo().size() == 0) { + String noResultsMessage = translator + .localize(LocaleResources.PROFILER_NO_RESULTS) + .getContents(); + tableModel.addRow(new Object[] { noResultsMessage, null, null }); + return; + } + for (MethodInfo methodInfo: results.getMethodInfo()) { Object[] data = new Object[] { methodInfo.name,
--- a/vm-profiler/client-swing/src/main/resources/com/redhat/thermostat/vm/profiler/client/swing/internal/strings.properties Wed Aug 12 20:06:57 2015 -0400 +++ b/vm-profiler/client-swing/src/main/resources/com/redhat/thermostat/vm/profiler/client/swing/internal/strings.properties Mon Aug 17 11:54:56 2015 -0400 @@ -14,3 +14,5 @@ PROFILER_RESULTS_METHOD = Method PROFILER_RESULTS_PERCENTAGE_TIME = Percentage PROFILER_RESULTS_TIME = Total Time ({0}) + +PROFILER_NO_RESULTS = No profiling data available