Mercurial > hg > release > thermostat-0.7

changeset 754:3dc46860f28b

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Fix AgentInformation to use arrays review-thread: http://icedtea.classpath.org/pipermail/thermostat/2012-October/003963.html reviewed-by: jerboaa, rkennke
author Mario Torre <neugens.limasoftware@gmail.com>
date Mon, 29 Oct 2012 17:49:26 +0100
parents 7182f8c2066f
children dfdd139397b6
files agent/core/src/main/java/com/redhat/thermostat/agent/Agent.java common/core/src/main/java/com/redhat/thermostat/common/model/BackendInformation.java common/core/src/test/java/com/redhat/thermostat/common/dao/BackendInfoDAOTest.java
diffstat 3 files changed, 8 insertions(+), 7 deletions(-) [+]
line wrap: on
line diff
--- a/agent/core/src/main/java/com/redhat/thermostat/agent/Agent.java	Fri Oct 26 11:41:59 2012 +0200
+++ b/agent/core/src/main/java/com/redhat/thermostat/agent/Agent.java	Mon Oct 29 17:49:26 2012 +0100
@@ -179,7 +179,7 @@
         backendInfo.setDescription(backend.getDescription());
         backendInfo.setObserveNewJvm(backend.getObserveNewJvm());
         backendInfo.setActive(true);
-        backendInfo.setPids(new ArrayList<Integer>());
+        backendInfo.setPids(new int[0]);
         
         return backendInfo;
     }
--- a/common/core/src/main/java/com/redhat/thermostat/common/model/BackendInformation.java	Fri Oct 26 11:41:59 2012 +0200
+++ b/common/core/src/main/java/com/redhat/thermostat/common/model/BackendInformation.java	Mon Oct 29 17:49:26 2012 +0100
@@ -36,6 +36,7 @@
 
 package com.redhat.thermostat.common.model;
 
+import java.util.Arrays;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -51,7 +52,7 @@
     private String description;
     private boolean isActive;
     private boolean observeNewJvm;
-    private List<Integer> pids;
+    private int[] pids;
     private Map<String, String> configuration = new HashMap<String,String>();
 
     @Persist
@@ -85,12 +86,12 @@
     }
 
     @Persist
-    public List<Integer> getPids() {
+    public int[] getPids() {
         return pids;
     }
 
     @Persist
-    public void setPids(List<Integer> pids) {
+    public void setPids(int[] pids) {
         this.pids = pids;
     }
 
@@ -125,7 +126,7 @@
                 Objects.equals(this.configuration, other.configuration) &&
                 Objects.equals(this.isActive, other.isActive) &&
                 Objects.equals(this.observeNewJvm, other.observeNewJvm) &&
-                Objects.equals(this.pids, other.pids);
+                Arrays.equals(this.pids, other.pids);
     }
 
     @Override
--- a/common/core/src/test/java/com/redhat/thermostat/common/dao/BackendInfoDAOTest.java	Fri Oct 26 11:41:59 2012 +0200
+++ b/common/core/src/test/java/com/redhat/thermostat/common/dao/BackendInfoDAOTest.java	Mon Oct 29 17:49:26 2012 +0100
@@ -75,14 +75,14 @@
         backendInfo1.setDescription("description");
         backendInfo1.setActive(true);
         backendInfo1.setObserveNewJvm(true);
-        backendInfo1.setPids(Arrays.asList(new Integer[] { -1, 0, 1}));
+        backendInfo1.setPids(new int[] { -1, 0, 1});
 
         backend1 = new BackendInformation();
         backend1.setName("backend-name");
         backend1.setDescription("description");
         backend1.setActive(true);
         backend1.setObserveNewJvm(true);
-        backend1.setPids(Arrays.asList(new Integer[] { -1, 0, 1}));
+        backend1.setPids(new int[] { -1, 0, 1});
         
     }