Mercurial > hg > release > thermostat-0.6
changeset 679:7b3ea162fe1b
Remove obsolete FIXMEs and TODOs
The FIXMEs and TODOs are no longer needed. Either the fix (or todo)
has been implemented or there is nothing to do.
Reviewed-by: jerboaa
Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2012-October/003599.html
| author | Omair Majid <omajid@redhat.com> |
|---|---|
| date | Thu, 04 Oct 2012 13:40:01 -0400 |
| parents | b7b32a0587bd |
| children | 54eb535d6cac |
| files | agent/core/src/main/java/com/redhat/thermostat/backend/sample/SampleBackend.java agent/core/src/test/java/com/redhat/thermostat/backend/BackendRegistryTest.java client/core/src/main/java/com/redhat/thermostat/client/ui/HostMemoryPanel.java client/heapdumper/src/main/java/com/redhat/thermostat/client/heap/ObjectDetailsController.java client/heapdumper/src/main/java/com/redhat/thermostat/client/heap/cli/ListHeapDumpsCommand.java common/core/src/test/java/com/redhat/thermostat/common/storage/ConnectionTest.java |
| diffstat | 6 files changed, 6 insertions(+), 13 deletions(-) [+] |
line wrap: on
line diff
--- a/agent/core/src/main/java/com/redhat/thermostat/backend/sample/SampleBackend.java Thu Oct 04 13:24:00 2012 -0400 +++ b/agent/core/src/main/java/com/redhat/thermostat/backend/sample/SampleBackend.java Thu Oct 04 13:40:01 2012 -0400 @@ -132,8 +132,7 @@ @Override protected void setDAOFactoryAction() { - // TODO Auto-generated method stub - + /* NO-OP */ } }
--- a/agent/core/src/test/java/com/redhat/thermostat/backend/BackendRegistryTest.java Thu Oct 04 13:24:00 2012 -0400 +++ b/agent/core/src/test/java/com/redhat/thermostat/backend/BackendRegistryTest.java Thu Oct 04 13:40:01 2012 -0400 @@ -93,8 +93,7 @@ @Override protected void setDAOFactoryAction() { - // TODO Auto-generated method stub - + /* NO-OP */ } }
--- a/client/core/src/main/java/com/redhat/thermostat/client/ui/HostMemoryPanel.java Thu Oct 04 13:24:00 2012 -0400 +++ b/client/core/src/main/java/com/redhat/thermostat/client/ui/HostMemoryPanel.java Thu Oct 04 13:40:01 2012 -0400 @@ -290,8 +290,6 @@ } private JFreeChart createMemoryChart() { - // FIXME associate a fixed color with each type - JFreeChart chart = ChartFactory.createTimeSeriesChart( localize(LocaleResources.HOST_MEMORY_CHART_TITLE), // Title localize(LocaleResources.HOST_MEMORY_CHART_TIME_LABEL), // x-axis Label
--- a/client/heapdumper/src/main/java/com/redhat/thermostat/client/heap/ObjectDetailsController.java Thu Oct 04 13:24:00 2012 -0400 +++ b/client/heapdumper/src/main/java/com/redhat/thermostat/client/heap/ObjectDetailsController.java Thu Oct 04 13:40:01 2012 -0400 @@ -122,13 +122,13 @@ @Override public boolean mightExclude() { - // TODO what is this? + /* we never return true in exclude */ return false; } @Override public boolean exclude(JavaClass clazz, JavaField f) { - // TODO hmm.... what is this? + /* visit every field in every java class */ return false; } };
--- a/client/heapdumper/src/main/java/com/redhat/thermostat/client/heap/cli/ListHeapDumpsCommand.java Thu Oct 04 13:24:00 2012 -0400 +++ b/client/heapdumper/src/main/java/com/redhat/thermostat/client/heap/cli/ListHeapDumpsCommand.java Thu Oct 04 13:40:01 2012 -0400 @@ -59,7 +59,6 @@ private static final String NAME = "list-heap-dumps"; - // TODO localize private static final String[] COLUMN_NAMES = { Translate.localize(LocaleResources.HEADER_HOST_ID), Translate.localize(LocaleResources.HEADER_VM_ID),
--- a/common/core/src/test/java/com/redhat/thermostat/common/storage/ConnectionTest.java Thu Oct 04 13:24:00 2012 -0400 +++ b/common/core/src/test/java/com/redhat/thermostat/common/storage/ConnectionTest.java Thu Oct 04 13:40:01 2012 -0400 @@ -60,14 +60,12 @@ @Override public void disconnect() { - // TODO Auto-generated method stub - + /* NO-OP */ } @Override public void connect() { - // TODO Auto-generated method stub - + /* NO-OP */ } }; listener1 = mock(Connection.ConnectionListener.class);