Mercurial > hg > release > thermostat-0.4
changeset 582:ac8f8bb554d3
Clean-up VMKilledListener.
This patch addresses a few suggestions made in an earlier review:
http://icedtea.classpath.org/pipermail/thermostat/2012-August/003029.html
Reviewed-by: rkennke
Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2012-September/003045.html
author | Severin Gehwolf <sgehwolf@redhat.com> |
---|---|
date | Mon, 03 Sep 2012 11:40:29 +0200 |
parents | b8a464e454a8 |
children | ed3f6e0a3867 |
files | client/killvm/src/main/java/com/redhat/thermostat/client/killvm/internal/VMKilledListener.java |
diffstat | 1 files changed, 13 insertions(+), 10 deletions(-) [+] |
line wrap: on
line diff
--- a/client/killvm/src/main/java/com/redhat/thermostat/client/killvm/internal/VMKilledListener.java Fri Aug 24 18:57:55 2012 +0200 +++ b/client/killvm/src/main/java/com/redhat/thermostat/client/killvm/internal/VMKilledListener.java Mon Sep 03 11:40:29 2012 +0200 @@ -45,29 +45,32 @@ public class VMKilledListener implements RequestResponseListener { - private static final Logger logger = Logger.getLogger(VMKilledListener.class.getName()); + private static final Logger logger = Logger + .getLogger(VMKilledListener.class.getName()); @Override public void fireComplete(Request request, Response response) { switch (response.getType()) { - case NOOP: // fall-through - case EXCEPTION: // fall-through - case NOK: { - logger.log(Level.SEVERE, "Unknown response from kill VM request."); + case EXCEPTION: + logger.log(Level.SEVERE, + "Exception response from kill VM request. Command channel failure?"); break; - } case ERROR: - logger.log(Level.SEVERE, "Kill request error for VM ID " + request.getParameter("vm-id")); + logger.log(Level.SEVERE, + "Kill request error for VM ID " + + request.getParameter("vm-id")); break; - case PONG: // fall-through, also OK :) + case PONG: // fall-through, also OK :) case OK: // TODO: Report this to user somehow (notification?) - logger.log(Level.INFO, "VM with id " + request.getParameter("vm-id") + " killed on host " + request.getTarget().toString()); + logger.log(Level.INFO, + "VM with id " + request.getParameter("vm-id") + + " killed on host " + + request.getTarget().toString()); break; default: logger.log(Level.WARNING, "Unknown result from KILL VM command."); break; } } - }