Mercurial > hg > release > thermostat-0.15

changeset 1166:ee5858fb6618

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
String builder for validator handler Reviewed-by: neugens Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2013-July/007298.html
author Giovanni Astarita <gastarit@redhat.com>
date Thu, 11 Jul 2013 18:16:31 +0200
parents 9c787a04da94
children 94e5078418e5
files thermostat-plugin-validator/src/main/java/com/redhat/thermostat/plugin/validator/internal/ConfigurationValidatorErrorHandler.java
diffstat 1 files changed, 12 insertions(+), 11 deletions(-) [+]
line wrap: on
line diff
--- a/thermostat-plugin-validator/src/main/java/com/redhat/thermostat/plugin/validator/internal/ConfigurationValidatorErrorHandler.java	Fri Jul 12 10:59:40 2013 +0200
+++ b/thermostat-plugin-validator/src/main/java/com/redhat/thermostat/plugin/validator/internal/ConfigurationValidatorErrorHandler.java	Thu Jul 11 18:16:31 2013 +0200
@@ -95,8 +95,9 @@
         int columnNumber = e.getColumnNumber();
         int lineNumber = e.getLineNumber();
         
-        StringBuffer buffer = new StringBuffer();
+        StringBuilder builder = new StringBuilder();
         
+        String LS = System.getProperty("line.separator");
         String firstLine = null;
         String secondLine = null;
         String thirdLine = null;
@@ -125,26 +126,26 @@
             pointer = pointer.concat("^");
             br.close();
         } catch (IOException exception) {
-            System.out.println("File not found!");;
+            // if br fails to close
         }
         
-        buffer.append(translator.localize(
+        builder.append(translator.localize(
                 translateKeys.get(type),
                 absolutePath, 
                 Integer.toString(lineNumber), 
                 Integer.toString(columnNumber)).getContents());
                     
-        buffer.append(formatMessage(e.getLocalizedMessage()) + "\n\n");
-        buffer.append(firstLine + "\n");
-        buffer.append(secondLine + "\n");
-        buffer.append(thirdLine + "\n");
-        buffer.append(errorLine + "\n");
-        buffer.append(pointer  + "\n");
+        builder.append(formatMessage(e.getLocalizedMessage())).append(LS).append(LS);
+        builder.append(firstLine).append(LS);
+        builder.append(secondLine).append(LS);
+        builder.append(thirdLine).append(LS);
+        builder.append(errorLine).append(LS);
+        builder.append(pointer).append(LS);
         
         if (isCommand) {
-            System.out.println(buffer.toString());
+            System.out.println(builder.toString());
         } else {
-            logger.info(buffer.toString());
+            logger.info(builder.toString());
         }
         
     }