Mercurial > hg > release > thermostat-0.11

changeset 1135:de36c4b57bb4

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
PR1450: description of heap-dump-histogram in shell Reviewed-by: omajid Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2013-June/007025.html
author Andriy Petrus <apetrus@redhat.com>
date Thu, 06 Jun 2013 11:00:25 -0400
parents 3d102042f1df
children 9d27da66582c
files vm-heap-analysis/command/src/main/java/com/redhat/thermostat/vm/heap/analysis/command/internal/ShowHeapHistogramCommand.java vm-heap-analysis/command/src/main/java/com/redhat/thermostat/vm/heap/analysis/command/locale/LocaleResources.java vm-heap-analysis/command/src/main/resources/com/redhat/thermostat/vm/heap/analysis/command/locale/strings.properties vm-heap-analysis/command/src/test/java/com/redhat/thermostat/vm/heap/analysis/command/internal/ShowHeapHistogramCommandTest.java
diffstat 4 files changed, 13 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/vm-heap-analysis/command/src/main/java/com/redhat/thermostat/vm/heap/analysis/command/internal/ShowHeapHistogramCommand.java	Wed Jun 05 15:48:48 2013 -0400
+++ b/vm-heap-analysis/command/src/main/java/com/redhat/thermostat/vm/heap/analysis/command/internal/ShowHeapHistogramCommand.java	Thu Jun 06 11:00:25 2013 -0400
@@ -103,6 +103,9 @@
 
     private void printHeapHistogram(ObjectHistogram histogram, PrintStream out) {
         TableRenderer table = new TableRenderer(3);
+        table.printLine(translator.localize(LocaleResources.TABLE_CLASS_NAME).getContents(),
+                translator.localize(LocaleResources.TABLE_NUMBER_INSTANCES).getContents(),
+                translator.localize(LocaleResources.TABLE_TOTAL_SIZE).getContents());
         for (HistogramRecord rec : histogram.getHistogram()) {
             table.printLine(rec.getClassname(), String.valueOf(rec.getNumberOf()), String.valueOf(rec.getTotalSize()));
         }
--- a/vm-heap-analysis/command/src/main/java/com/redhat/thermostat/vm/heap/analysis/command/locale/LocaleResources.java	Wed Jun 05 15:48:48 2013 -0400
+++ b/vm-heap-analysis/command/src/main/java/com/redhat/thermostat/vm/heap/analysis/command/locale/LocaleResources.java	Thu Jun 06 11:00:25 2013 -0400
@@ -76,6 +76,10 @@
     COMMAND_SAVE_HEAP_DUMP_SAVED_TO_FILE,
     COMMAND_SAVE_HEAP_DUMP_ERROR_SAVING,
     COMMAND_SAVE_HEAP_DUMP_ERROR_CLOSING_STREAM,
+    
+    TABLE_CLASS_NAME,
+    TABLE_NUMBER_INSTANCES,
+    TABLE_TOTAL_SIZE,
     ;
     
     static final String RESOURCE_BUNDLE = "com.redhat.thermostat.vm.heap.analysis.command.locale.strings";
--- a/vm-heap-analysis/command/src/main/resources/com/redhat/thermostat/vm/heap/analysis/command/locale/strings.properties	Wed Jun 05 15:48:48 2013 -0400
+++ b/vm-heap-analysis/command/src/main/resources/com/redhat/thermostat/vm/heap/analysis/command/locale/strings.properties	Thu Jun 06 11:00:25 2013 -0400
@@ -36,3 +36,6 @@
 COMMAND_SAVE_HEAP_DUMP_ERROR_SAVING = error saving heap to file: {0}
 COMMAND_SAVE_HEAP_DUMP_ERROR_CLOSING_STREAM = error closing heap stream: {0}
 
+TABLE_CLASS_NAME = Class Name
+TABLE_NUMBER_INSTANCES = Instances
+TABLE_TOTAL_SIZE = Total Size
--- a/vm-heap-analysis/command/src/test/java/com/redhat/thermostat/vm/heap/analysis/command/internal/ShowHeapHistogramCommandTest.java	Wed Jun 05 15:48:48 2013 -0400
+++ b/vm-heap-analysis/command/src/test/java/com/redhat/thermostat/vm/heap/analysis/command/internal/ShowHeapHistogramCommandTest.java	Thu Jun 06 11:00:25 2013 -0400
@@ -102,8 +102,9 @@
 
         command.run(factory.createContext(args));
 
-        assertEquals("class1                  2 8\n" +
-                     "verylongclassnameclass2 1 10\n", factory.getOutput());
+        assertEquals("Class Name              Instances Total Size\n" +
+                     "class1                  2         8\n" +
+                     "verylongclassnameclass2 1         10\n", factory.getOutput());
     }
 
     @Test