Mercurial > hg > release > thermostat-0.11
changeset 816:ba1eb6634612
Fix eclipse tests.
So this took way longer than anticipated :( But here's what happened (and made Eclipse tests fail):
1. Even though we cleared out thermostat bundles from the local maven repo,
this hasn't been done in other places. The Eclipse build uses tycho which, of
course, has it's own cache and other fluff but is still within the local maven
repo tree.
2. If you have a look at the repo history you can observe that the vmclasstat patch has been pushed
after the ApplicationService refactoring.
3. Since Eclipse builds happened prior this refactoring (from 2.) and not all
artifacts from previous Eclipse builds have been cleaned up, tycho started
resolving bundles based on stale artifacts. And this is where things went wrong. And only
the vmclassstat bundle was showing this test failure.
4. This also explains why it wasn't reproducible if the local maven/tycho repo gets removed in its
entirety.
The solution is to do better cleanup prior attempting builds.
Reviewed-by: ebaron
Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2012-December/004368.html
author | Severin Gehwolf <sgehwolf@redhat.com> |
---|---|
date | Tue, 04 Dec 2012 15:39:00 +0100 |
parents | 5917cd87fdb4 |
children | 7b9365602c9f |
files | Makefile |
diffstat | 1 files changed, 5 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/Makefile Fri Nov 30 13:58:41 2012 +0100 +++ b/Makefile Tue Dec 04 15:39:00 2012 +0100 @@ -61,8 +61,12 @@ create-repo-dir: mkdir -p $(REPO_LOC) +# This is basically in bash speak: +# +# for i in $(find | grep thermostat); do rm -rf $i; done; +# rm -rf .cache/tycho clean-repo: - find $(REPO_LOC)/com/redhat/thermostat -print0 | xargs -0 rm -rf + done=$(shell bash -c 'cd $(REPO_LOC); for i in $$(find | grep thermostat); do rm -rf $$i; done; rm -rf .cache/tycho/; echo true' ) echo-repo: echo "Using private Maven repository: $(REPO_LOC)"