Mercurial > hg > release > thermostat-0.11

changeset 841:2e52ed806ce2

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Avoid exporting commands Currently, we register all commands as OSGi services and commands are looked up using OSGi. Do not export the implementation classes, so anyone using a Command implementation (obtained from OSGi) can only work with the public API of the Command class. Reviewed-by: neugens Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2012-December/004507.html
author Omair Majid <omajid@redhat.com>
date Tue, 11 Dec 2012 11:53:57 -0500
parents 54b96842f43c
children 94bfc70b0da0
files client/command/pom.xml tools/pom.xml web/cmd/pom.xml
diffstat 3 files changed, 7 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/client/command/pom.xml	Tue Dec 11 16:02:58 2012 +0100
+++ b/client/command/pom.xml	Tue Dec 11 11:53:57 2012 -0500
@@ -103,10 +103,10 @@
             <Bundle-SymbolicName>com.redhat.thermostat.client.command</Bundle-SymbolicName>
             <Export-Package>
               com.redhat.thermostat.client.command,
-              com.redhat.thermostat.client.command.cli
             </Export-Package>
             <Private-Package>
-              com.redhat.thermostat.client.command.internal
+              com.redhat.thermostat.client.command.cli,
+              com.redhat.thermostat.client.command.internal,
             </Private-Package>
             <!-- Do not autogenerate uses clauses in Manifests -->
             <_nouses>true</_nouses>
--- a/tools/pom.xml	Tue Dec 11 16:02:58 2012 +0100
+++ b/tools/pom.xml	Tue Dec 11 11:53:57 2012 -0500
@@ -115,10 +115,11 @@
             <Bundle-SymbolicName>com.redhat.thermostat.tools</Bundle-SymbolicName>
             <Export-Package>
               com.redhat.thermostat.tools,
+            </Export-Package>
+            <Private-Package>
+              META_INF.services,
               com.redhat.thermostat.tools.cli,
-              com.redhat.thermostat.tools.db,
-            </Export-Package>
-            <Private-Package>META_INF.services</Private-Package>
+            </Private-Package>
             <!-- Do not autogenerate uses clauses in Manifests -->
             <_nouses>true</_nouses>
           </instructions>
--- a/web/cmd/pom.xml	Tue Dec 11 16:02:58 2012 +0100
+++ b/web/cmd/pom.xml	Tue Dec 11 11:53:57 2012 -0500
@@ -110,7 +110,7 @@
             <Bundle-SymbolicName>com.redhat.thermostat.web.cmd</Bundle-SymbolicName>
             <Bundle-Vendor>Red Hat, Inc.</Bundle-Vendor>
             <Bundle-Activator>com.redhat.thermostat.web.cmd.Activator</Bundle-Activator>
-            <Export-Package>com.redhat.thermostat.web.cmd</Export-Package>
+            <Private-Package>com.redhat.thermostat.web.cmd</Private-Package>
             <!-- Do not autogenerate uses clauses in Manifests -->
             <_nouses>true</_nouses>
           </instructions>