Mercurial > hg > release > icedtea8-forest-3.0 > jdk

changeset 10744:bf30dfeaa3ac

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
8072069: Toolkit.getScreenInsets() doesn't update if insets change Reviewed-by: serb, azvegint
author anashaty
date Tue, 17 Feb 2015 20:05:15 +0300
parents 7b91e9e3034d
children 628cb66e781b
files src/macosx/classes/sun/awt/CGraphicsDevice.java
diffstat 1 files changed, 7 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/src/macosx/classes/sun/awt/CGraphicsDevice.java	Mon Feb 16 22:57:17 2015 +0000
+++ b/src/macosx/classes/sun/awt/CGraphicsDevice.java	Tue Feb 17 20:05:15 2015 +0300
@@ -43,7 +43,6 @@
      * therefore methods, which is using this id should be ready to it.
      */
     private volatile int displayID;
-    private volatile Insets screenInsets;
     private volatile double xResolution;
     private volatile double yResolution;
     private volatile int scale;
@@ -120,7 +119,13 @@
     }
 
     public Insets getScreenInsets() {
-        return screenInsets;
+        // the insets are queried synchronously and are not cached
+        // since there are no Quartz or Cocoa means to receive notifications
+        // on insets changes (e.g. when the Dock is resized):
+        // the existing CGDisplayReconfigurationCallBack is not notified
+        // as well as the NSApplicationDidChangeScreenParametersNotification
+        // is fired on the Dock location changes only
+        return nativeGetScreenInsets(displayID);
     }
 
     public int getScaleFactor() {
@@ -135,7 +140,6 @@
     public void displayChanged() {
         xResolution = nativeGetXResolution(displayID);
         yResolution = nativeGetYResolution(displayID);
-        screenInsets = nativeGetScreenInsets(displayID);
         scale = (int) nativeGetScaleFactor(displayID);
         //TODO configs/fullscreenWindow/modes?
     }