Mercurial > hg > release > icedtea7-forest-2.2 > langtools
changeset 210:4542977c959e
6557182: Unchecked warning *and* inconvertible types
Summary: Redundant warnings are generated when casting from intersection types
Reviewed-by: jjg
author | mcimadamore |
---|---|
date | Thu, 29 Jan 2009 12:18:19 +0000 |
parents | 1aa81917016a |
children | 79f2f2c7d846 |
files | src/share/classes/com/sun/tools/javac/code/Types.java test/tools/javac/cast/6557182/T6557182.java test/tools/javac/cast/6557182/T6557182.out |
diffstat | 3 files changed, 49 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/src/share/classes/com/sun/tools/javac/code/Types.java Thu Jan 29 12:17:57 2009 +0000 +++ b/src/share/classes/com/sun/tools/javac/code/Types.java Thu Jan 29 12:18:19 2009 +0000 @@ -949,12 +949,16 @@ } if (t.isCompound()) { + Warner oldWarner = warnStack.head; + warnStack.head = Warner.noWarnings; if (!visit(supertype(t), s)) return false; for (Type intf : interfaces(t)) { if (!visit(intf, s)) return false; } + if (warnStack.head.unchecked == true) + oldWarner.warnUnchecked(); return true; }
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/tools/javac/cast/6557182/T6557182.java Thu Jan 29 12:18:19 2009 +0000 @@ -0,0 +1,41 @@ +/* + * Copyright 2009 Sun Microsystems, Inc. All Rights Reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, + * CA 95054 USA or visit www.sun.com if you need additional information or + * have any questions. + */ + +/* + * @test + * @author Maurizio Cimadamore + * @bug 6557182 + * @summary Unchecked warning *and* inconvertible types + * @compile/fail/ref=T6557182.out -XDrawDiagnostics -Xlint:unchecked T6557182.java + */ + +class T6557182 { + + <T extends Number & Comparable<String>> void test1(T t) { + Comparable<Integer> ci = (Comparable<Integer>) t; + } + + <T extends Number & Comparable<? extends Number>> void test2(T t) { + Comparable<Integer> ci = (Comparable<Integer>) t; + } +}
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/tools/javac/cast/6557182/T6557182.out Thu Jan 29 12:18:19 2009 +0000 @@ -0,0 +1,4 @@ +T6557182.java:35:56: compiler.err.prob.found.req: (- compiler.misc.inconvertible.types), T, java.lang.Comparable<java.lang.Integer> +T6557182.java:39:56: compiler.warn.prob.found.req: (- compiler.misc.unchecked.cast.to.type), T, java.lang.Comparable<java.lang.Integer> +1 error +1 warning