changeset 2054:b1dfd5460bf9

Restore icedtea-override-metacity.patch to allow full screen apps and other expected behavioral improvements. 2010-07-14 Jon VanAlten <jon.vanalten@redhat.com> * patches/icedtea-override-redirect-metacity.patch: Produces the "expected" behavior for full screen applications or other situations where developers wish to present elements that would cover things like panels. * Makefile.am: Apply icedtea-override-redirect-metacity.patch.
author Jon VanAlten <jon.vanalten@redhat.com>
date Fri, 16 Jul 2010 17:08:40 +0100
parents cc8ca057c727
children faa4f2e58846
files ChangeLog Makefile.am patches/icedtea-override-redirect-metacity.patch
diffstat 3 files changed, 29 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Tue Jul 13 11:46:10 2010 +0200
+++ b/ChangeLog	Fri Jul 16 17:08:40 2010 +0100
@@ -1,3 +1,19 @@
+2010-07-14  Jon VanAlten  <jon.vanalten@redhat.com>
+
+	* patches/icedtea-override-redirect-metacity.patch: Produces the
+	"expected" behavior for full screen applications or other situations
+	where developers wish to present elements that would cover things like
+	panels.  We previously had a version of this patch since changeset 876
+	ebc064e8892d, but dropped it in changeset changeset 1731
+	83619682858e because upstream had rejected as a metacity bug[1].
+	Metacity maintains that this behavior does not break any spec and does
+	not appear likely to change either[2], so we must be the "good guys" and
+	provide the expected behavior.  See discussion[3].
+	[1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6514512
+	[2] https://bugzilla.gnome.org/show_bug.cgi?id=405269
+	[3] http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-April/008862.html
+	* Makefile.am: Apply icedtea-override-redirect-metacity.patch.
+
 2010-07-13  Mark Wielaard  <mjw@redhat.com>
 
 	Reported by William Cohen <wcohen@redhat.com>
--- a/Makefile.am	Tue Jul 13 11:46:10 2010 +0200
+++ b/Makefile.am	Fri Jul 16 17:08:40 2010 +0100
@@ -326,7 +326,8 @@
 	patches/security/20100330/6932480.patch \
 	patches/ant-1.8.0.patch \
 	patches/icedtea-nss-6763530.patch \
-	patches/nss-debug.patch
+	patches/nss-debug.patch \
+	patches/icedtea-override-redirect-metacity.patch
 
 if WITH_RHINO
 ICEDTEA_PATCHES += \
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/patches/icedtea-override-redirect-metacity.patch	Fri Jul 16 17:08:40 2010 +0100
@@ -0,0 +1,11 @@
+--- openjdk/jdk/src/solaris/classes/sun/awt/X11/XWindowPeer.java.orig	2008-05-25 17:31:31.000000000 +0200
++++ openjdk/jdk/src/solaris/classes/sun/awt/X11/XWindowPeer.java	2008-05-25 17:33:32.000000000 +0200
+@@ -1124,6 +1124,8 @@
+ 
+     boolean isOverrideRedirect() {
+         return (XWM.getWMID() == XWM.OPENLOOK_WM ? true : false) ||
++            (XWM.getWMID() == XWM.METACITY_WM ? true : false) ||
++            target.getName().equals("###overrideRedirect###") ||
+             ((XToolkit)Toolkit.getDefaultToolkit()).isOverrideRedirect((Window)target) ||
+             XTrayIconPeer.isTrayIconStuffWindow((Window)target);
+     }