changeset 2884:9faadf8e66b2

PR1339: Simplify the rewriter, avoiding concurrency. 2013-03-11 Andrew John Hughes <gnu.andrew@member.fsf.org> PR1339: Simplify the rewriter, avoiding concurrency. * rewriter/com/redhat/rewriter/ClassRewriter.java: Always use the single threaded executor. * NEWS: Updated with this and PR1338, added silently for 1.11.5 but not HEAD.
author Andrew John Hughes <gnu.andrew@redhat.com>
date Wed, 17 Apr 2013 08:19:05 +0100
parents a4f35810b04f
children a4c7d55a2e77
files ChangeLog NEWS rewriter/com/redhat/rewriter/ClassRewriter.java
diffstat 3 files changed, 13 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Wed Apr 17 08:13:18 2013 +0100
+++ b/ChangeLog	Wed Apr 17 08:19:05 2013 +0100
@@ -1,3 +1,11 @@
+2013-03-11  Andrew John Hughes  <gnu.andrew@member.fsf.org>
+
+	PR1339: Simplify the rewriter, avoiding concurrency.
+	* rewriter/com/redhat/rewriter/ClassRewriter.java:
+	Always use the single threaded executor.
+	* NEWS: Updated with this and PR1338, added silently
+	for 1.11.5 but not HEAD.
+
 2013-04-17  Andrew John Hughes  <gnu.andrew@redhat.com>
 
 	* NEWS: Updated.
--- a/NEWS	Wed Apr 17 08:13:18 2013 +0100
+++ b/NEWS	Wed Apr 17 08:19:05 2013 +0100
@@ -60,6 +60,7 @@
   - OJ3: Fix get_stack_bounds memory leak (alternate fix for S7197906)
   - PR1362: Fedora 19 / rawhide FTBFS SIGILL
   - PR1319: Correct #ifdef to #if
+  - PR1339: Simplify the rhino class rewriter to avoid use of concurrency
 
 New in release 1.11.9 (2013-03-04):
 
@@ -156,6 +157,7 @@
   - S7199153: TEST_BUG: try-with-resources syntax pushed to 6-open repo
 * Bug fixes
   - PR1194: IcedTea tries to build with /usr/lib/jvm/java-openjdk (now a 1.7 VM) by default
+  - PR1338: Remove dependence on libXp
 
 New in release 1.11.4 (2012-08-31):
 
--- a/rewriter/com/redhat/rewriter/ClassRewriter.java	Wed Apr 17 08:13:18 2013 +0100
+++ b/rewriter/com/redhat/rewriter/ClassRewriter.java	Wed Apr 17 08:19:05 2013 +0100
@@ -60,8 +60,8 @@
   /**
    * The executor for submitting rewriting jobs.
    */
-  private static final ExecutorService executor = DEBUG ?
-    Executors.newSingleThreadExecutor() : Executors.newCachedThreadPool();
+  private static final ExecutorService executor = 
+    Executors.newSingleThreadExecutor();
 
   /**
    * The source directory, set once by main.
@@ -290,4 +290,4 @@
     return null;
   }
 
-}
\ No newline at end of file
+}