changeset 2609:50b12236cc6d

Fix hanging jtreg test.
author Denis Lila <dlila@redhat.com>
date Mon, 20 Jun 2011 11:38:07 -0400
parents 628bfb4cd6c1
children be0c585e6d35
files ChangeLog Makefile.am patches/jtreg-bug7036148-test.patch
diffstat 3 files changed, 33 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Mon Jun 20 11:23:24 2011 -0400
+++ b/ChangeLog	Mon Jun 20 11:38:07 2011 -0400
@@ -1,3 +1,10 @@
+2011-06-20  Denis Lila  <dlila@redhat.com>
+
+	* Makefile.am: Add patch.
+	* patches/jtreg-bug7036148-test.patch:
+	Fix regression test. It used to never end, regardless of
+	success/failure.
+
 2011-06-20  Denis Lila  <dlila@redhat.com>
 
 	* pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioDataLine.java
--- a/Makefile.am	Mon Jun 20 11:23:24 2011 -0400
+++ b/Makefile.am	Mon Jun 20 11:38:07 2011 -0400
@@ -358,7 +358,8 @@
 	patches/jtreg-EncodedMultiByteChar.patch \
 	patches/jtreg-FileLoaderTest.patch \
 	patches/jtreg-FileMap.patch \
-	patches/jtreg-ChannelsWrite.patch
+	patches/jtreg-ChannelsWrite.patch \
+	patches/jtreg-bug7036148-test.patch
 
 if WITH_ALT_HSBUILD
 ICEDTEA_PATCHES += \
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/patches/jtreg-bug7036148-test.patch	Mon Jun 20 11:38:07 2011 -0400
@@ -0,0 +1,24 @@
+diff -r e7493c32e598 test/javax/swing/JMenuItem/7036148/bug7036148.java
+--- openjdk.orig/jdk/test/javax/swing/JMenuItem/7036148/bug7036148.java	Wed Jun 08 10:24:10 2011 -0700
++++ openjdk/jdk/test/javax/swing/JMenuItem/7036148/bug7036148.java	Wed Jun 15 14:25:59 2011 -0400
+@@ -44,10 +44,16 @@
+         menu.add(new JMenuItem("test"));
+         bar.add(menu);
+         setJMenuBar(bar);
+-        pack();
+     }
+ 
+-       public static void main(String[] args) {
+-            new bug7036148();
+-       }
++    public static void main(String[] args) {
++        // if the bug is present, an NPE will be thrown on pack() above.
++        JFrame f = new bug7036148();
++
++        try {
++            f.pack();
++        } finally {
++            f.dispose();
++        }
++    }
+ }