Mercurial > hg > release > icedtea-web-1.6

changeset 287:e9a9792ee189

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
current reproducers (see changelog) done more verbose
author Jiri Vanek <jvanek@redhat.com>
date Thu, 15 Sep 2011 15:27:40 +0200
parents d2434b3dc395
children b56fd9cb2dfc
files ChangeLog tests/jnlp_tests/simple/AccessClassInPackage/testcases/AccessClassInPackageTest.java tests/jnlp_tests/simple/AddShutdownHook/testcases/AddShutdownHookTest.java tests/jnlp_tests/simple/AllStackTraces/testcases/AllStackTracesTest.java tests/jnlp_tests/simple/CreateClassLoader/testcases/CreateClassLoaderTest.java tests/jnlp_tests/simple/ReadEnvironment/testcases/ReadEnvironmentTest.java tests/jnlp_tests/simple/ReadProperties/testcases/ReadPropertiesTest.java tests/jnlp_tests/simple/RedirectStreams/testcases/RedirectStreamsTest.java tests/jnlp_tests/simple/ReplaceSecurityManager/testcases/ReplaceSecurityManagerTest.java tests/jnlp_tests/simple/SetContextClassLoader/testcases/SetContextClassLoaderTest.java tests/jnlp_tests/simple/deadlocktest/testcases/DeadLockTestTest.java tests/jnlp_tests/simple/simpletest1/testcases/SimpleTest1Test.java tests/jnlp_tests/simple/simpletest2/testcases/SimpleTest2Test.java
diffstat 13 files changed, 101 insertions(+), 56 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Tue Sep 13 16:23:04 2011 -0400
+++ b/ChangeLog	Thu Sep 15 15:27:40 2011 +0200
@@ -1,3 +1,11 @@
+2011-09-15  Jiri Vanek <jvanek@redhat.com>
+
+	* tests/jnlp_tests/: all current reproducers (AccessClassInPackage
+	AddShutdownHook AllStackTraces CreateClassLoader deadlocktest
+	ReadEnvironment ReadProperties RedirectStreams ReplaceSecurityManager
+	SetContextClassLoader simpletest1 simpletest2) junit's asserts are enchanted
+	for reason, so junit assertion exception message is much clearer. 
+
 2011-09-13  Deepak Bhole <dbhole@redhat.com>
 
 	PR782: Support building against npapi-sdk as well
--- a/tests/jnlp_tests/simple/AccessClassInPackage/testcases/AccessClassInPackageTest.java	Tue Sep 13 16:23:04 2011 -0400
+++ b/tests/jnlp_tests/simple/AccessClassInPackage/testcases/AccessClassInPackageTest.java	Thu Sep 15 15:27:40 2011 +0200
@@ -47,13 +47,17 @@
     @Test
     public void AccessClassInPackageTestLunch1() throws Exception {
         System.out.println("connecting AccessClassInPackageTest request");
+	System.err.println("connecting AccessClassInPackageTest request");
         ServerAccess.ProcessResult pr = server.executeJavawsHeadless(null, "/AccessClassInPackage.jnlp");
         System.out.println(pr.stdout);
         System.err.println(pr.stderr);
-        Assert.assertTrue(pr.stderr.contains("java.security.AccessControlException: access denied (java.lang.RuntimePermission accessClassInPackage.sun.security.internal.spec)"));
-        Assert.assertFalse(pr.stderr.contains("ClassNotFoundException"));
-        Assert.assertFalse(pr.stdout.length() > 2);
-        Assert.assertFalse(pr.wasTerminated);
+        String c="java.security.AccessControlException: access denied (java.lang.RuntimePermission accessClassInPackage.sun.security.internal.spec)";
+        Assert.assertTrue("stderr should contains `"+c+"`, but didn't ",pr.stderr.contains(c));
+        String cc="ClassNotFoundException";
+        Assert.assertFalse("stderr should NOT contains `"+cc+"`, but did",pr.stderr.contains(cc));
+        Assert.assertFalse("stdout length should be <=2, but was "+pr.stdout.length(),pr.stdout.length()>2);
+        Assert.assertFalse("AccessClassInPackageTestLunch1 should not be terminated, but was",pr.wasTerminated);
         Assert.assertEquals((Integer) 0, pr.returnValue);
     }
+
 }
--- a/tests/jnlp_tests/simple/AddShutdownHook/testcases/AddShutdownHookTest.java	Tue Sep 13 16:23:04 2011 -0400
+++ b/tests/jnlp_tests/simple/AddShutdownHook/testcases/AddShutdownHookTest.java	Thu Sep 15 15:27:40 2011 +0200
@@ -47,13 +47,16 @@
     @Test
     public void AddShutdownHookTestLunch1() throws Exception {
         System.out.println("connecting AddShutdownHook request");
+        System.err.println("connecting AddShutdownHook request");
         ServerAccess.ProcessResult pr = server.executeJavawsHeadless(null, "/AddShutdownHook.jnlp");
         System.out.println(pr.stdout);
         System.err.println(pr.stderr);
-        Assert.assertTrue(pr.stderr.contains("java.security.AccessControlException: access denied (java.lang.RuntimePermission shutdownHooks)"));
-        Assert.assertFalse(pr.stderr.contains("ClassNotFoundException"));
-        Assert.assertFalse(pr.stdout.length() > 2);
-        Assert.assertFalse(pr.wasTerminated);
+        String s="java.security.AccessControlException: access denied (java.lang.RuntimePermission shutdownHooks)";
+        Assert.assertTrue("stderr should contains "+s+" but didn't",pr.stderr.contains(s));
+        String cc="ClassNotFoundException";
+        Assert.assertFalse("stderr should NOT contains `"+cc+"`, but did",pr.stderr.contains(cc));
+        Assert.assertFalse("stdout length should be <=2, but was "+pr.stdout.length(),pr.stdout.length()>2);
+        Assert.assertFalse("AddShutdownHookTestLunch1 should not be terminated, but was",pr.wasTerminated);
         Assert.assertEquals((Integer) 0, pr.returnValue);
     }
 }
--- a/tests/jnlp_tests/simple/AllStackTraces/testcases/AllStackTracesTest.java	Tue Sep 13 16:23:04 2011 -0400
+++ b/tests/jnlp_tests/simple/AllStackTraces/testcases/AllStackTracesTest.java	Thu Sep 15 15:27:40 2011 +0200
@@ -47,15 +47,18 @@
   
 
     @Test
-    public void AddShutdownHookTestLunch1() throws Exception {
+    public void AllStackTracesTest1() throws Exception {
         System.out.println("connecting AllStackTraces request");
+        System.err.println("connecting AllStackTraces request");
         ServerAccess.ProcessResult pr=server.executeJavawsHeadless(null,"/AllStackTraces.jnlp");
         System.out.println(pr.stdout);
         System.err.println(pr.stderr);
-        Assert.assertTrue(pr.stderr.contains("java.security.AccessControlException: access denied (java.lang.RuntimePermission getStackTrace)"));
-        Assert.assertFalse(pr.stderr.contains("ClassNotFoundException"));
-        Assert.assertFalse(pr.stdout.length()>2);
-        Assert.assertFalse(pr.wasTerminated);
+        String c="java.security.AccessControlException: access denied (java.lang.RuntimePermission getStackTrace)";	
+        Assert.assertTrue("stderr should contains `"+c+"`, but didn't ",pr.stderr.contains(c));
+        String cc="ClassNotFoundException";
+        Assert.assertFalse("stderr should NOT contains `"+cc+"`, but did ",pr.stderr.contains(cc));
+        Assert.assertFalse("stdout length should be <=2, but was "+pr.stdout.length(),pr.stdout.length()>2);
+        Assert.assertFalse("AllStackTracesTest1 should not be terminated, but was",pr.wasTerminated);
         Assert.assertEquals((Integer)0, pr.returnValue);
     }
 
--- a/tests/jnlp_tests/simple/CreateClassLoader/testcases/CreateClassLoaderTest.java	Tue Sep 13 16:23:04 2011 -0400
+++ b/tests/jnlp_tests/simple/CreateClassLoader/testcases/CreateClassLoaderTest.java	Thu Sep 15 15:27:40 2011 +0200
@@ -47,13 +47,16 @@
     @Test
     public void CreateClassLoaderLunch1() throws Exception {
         System.out.println("connecting CreateClassLoader request");
+        System.err.println("connecting CreateClassLoader request");
         ServerAccess.ProcessResult pr = server.executeJavawsHeadless(null, "/CreateClassLoader.jnlp");
         System.out.println(pr.stdout);
         System.err.println(pr.stderr);
-        Assert.assertTrue(pr.stderr.contains("java.security.AccessControlException: access denied (java.lang.RuntimePermission createClassLoader)"));
-        Assert.assertFalse(pr.stderr.contains("ClassNotFoundException"));
-        Assert.assertFalse(pr.stdout.length() > 2);
-        Assert.assertFalse(pr.wasTerminated);
+        String s="java.security.AccessControlException: access denied (java.lang.RuntimePermission createClassLoader)";
+        Assert.assertTrue("Stderr should contains "+s+" but didn't",pr.stderr.contains(s));
+        String cc="ClassNotFoundException";
+        Assert.assertFalse("stderr should NOT contains `"+cc+"`, but did",pr.stderr.contains(cc));
+        Assert.assertFalse("stdout length should be <=2, but was "+pr.stdout.length(),pr.stdout.length()>2);
+        Assert.assertFalse("CreateClassLoaderLunch1 should not be terminated, but was",pr.wasTerminated);
         Assert.assertEquals((Integer) 0, pr.returnValue);
     }
 }
--- a/tests/jnlp_tests/simple/ReadEnvironment/testcases/ReadEnvironmentTest.java	Tue Sep 13 16:23:04 2011 -0400
+++ b/tests/jnlp_tests/simple/ReadEnvironment/testcases/ReadEnvironmentTest.java	Thu Sep 15 15:27:40 2011 +0200
@@ -47,13 +47,16 @@
     @Test
     public void ReadEnvironmentLunch1() throws Exception {
         System.out.println("connecting ReadEnvironment request");
+        System.err.println("connecting ReadEnvironment request");
         ServerAccess.ProcessResult pr = server.executeJavawsHeadless(null, "/ReadEnvironment.jnlp");
         System.out.println(pr.stdout);
         System.err.println(pr.stderr);
-        Assert.assertTrue(pr.stderr.contains("java.security.AccessControlException: access denied (java.lang.RuntimePermission getenv.USER)"));
-        Assert.assertFalse(pr.stderr.contains("ClassNotFoundException"));
-        Assert.assertFalse(pr.stdout.length() > 2);
-        Assert.assertFalse(pr.wasTerminated);
+        String s="java.security.AccessControlException: access denied (java.lang.RuntimePermission getenv.USER)";
+        Assert.assertTrue("stderr should contains "+s+"but didn't",pr.stderr.contains(s));
+        String cc="ClassNotFoundException";
+        Assert.assertFalse("stderr should NOT contains `"+cc+"`, but did",pr.stderr.contains(cc));
+        Assert.assertFalse("stdout length should be <=2, but was "+pr.stdout.length(),pr.stdout.length()>2);
+        Assert.assertFalse("ReadEnvironmentLunch1 should not be terminated, but was",pr.wasTerminated);
         Assert.assertEquals((Integer) 0, pr.returnValue);
     }
 }
--- a/tests/jnlp_tests/simple/ReadProperties/testcases/ReadPropertiesTest.java	Tue Sep 13 16:23:04 2011 -0400
+++ b/tests/jnlp_tests/simple/ReadProperties/testcases/ReadPropertiesTest.java	Thu Sep 15 15:27:40 2011 +0200
@@ -44,31 +44,36 @@
 
     private static ServerAccess server = new ServerAccess();
 
-  
-
+ 
     @Test
     public void ReadPropertiesLunch1() throws Exception {
-        System.out.println("connecting ReadProperties request");
+        System.out.println("connecting ReadProperties1 request");
+        System.err.println("connecting ReadProperties1 request");
         ServerAccess.ProcessResult pr=server.executeJavawsHeadless(null,"/ReadProperties1.jnlp");
         System.out.println(pr.stdout);
         System.err.println(pr.stderr);
-        Assert.assertTrue(pr.stderr.contains("java.security.AccessControlException: access denied (java.util.PropertyPermission user.name read)"));
-        Assert.assertFalse(pr.stderr.contains("ClassNotFoundException"));
-        Assert.assertFalse(pr.stdout.length()>2);
-        Assert.assertFalse(pr.wasTerminated);
+        String s="java.security.AccessControlException: access denied (java.util.PropertyPermission user.name read)";
+        Assert.assertTrue("stderr should contains "+s+" but didn't",pr.stderr.contains(s));
+        String cc="ClassNotFoundException";
+        Assert.assertFalse("stderr should NOT contains `"+cc+"`, but did",pr.stderr.contains(cc));
+        Assert.assertFalse("stdout length should be <=2, but was "+pr.stdout.length(),pr.stdout.length()>2);
+        Assert.assertFalse("ReadPropertiesLunch1 should not be terminated, but was",pr.wasTerminated);
         Assert.assertEquals((Integer)0, pr.returnValue);
     }
 
  @Test
     public void ReadPropertiesLunch2() throws Exception {
-        System.out.println("connecting ReadProperties request");
+        System.out.println("connecting ReadProperties2 request");
+        System.err.println("connecting ReadProperties2 request");
         ServerAccess.ProcessResult pr=server.executeJavawsHeadless(null,"/ReadProperties2.jnlp");
         System.out.println(pr.stdout);
         System.err.println(pr.stderr);
-        Assert.assertTrue(pr.stderr.contains("java.security.AccessControlException: access denied (java.util.PropertyPermission user.home read)"));
-        Assert.assertFalse(pr.stderr.contains("ClassNotFoundException"));
-        Assert.assertFalse(pr.stdout.length()>2);
-        Assert.assertFalse(pr.wasTerminated);
+        String s="java.security.AccessControlException: access denied (java.util.PropertyPermission user.home read)";
+        Assert.assertTrue("stderr should contains "+s+" but didn't",pr.stderr.contains(s));
+        String cc="ClassNotFoundException";
+        Assert.assertFalse("stderr should NOT contains `"+cc+"`, but did",pr.stderr.contains(cc));
+        Assert.assertFalse("stdout length should be <=2, but was "+pr.stdout.length(),pr.stdout.length()>2);
+        Assert.assertFalse("ReadPropertiesLunch2 should not be terminated, but was",pr.wasTerminated);
         Assert.assertEquals((Integer)0, pr.returnValue);
     }
   }
--- a/tests/jnlp_tests/simple/RedirectStreams/testcases/RedirectStreamsTest.java	Tue Sep 13 16:23:04 2011 -0400
+++ b/tests/jnlp_tests/simple/RedirectStreams/testcases/RedirectStreamsTest.java	Thu Sep 15 15:27:40 2011 +0200
@@ -44,15 +44,18 @@
     private static ServerAccess server = new ServerAccess();
 
     @Test
-    public void ReadPropertiesLunch1() throws Exception {
+    public void RedirectStreamsTest1() throws Exception {
         System.out.println("connecting RedirectStreams request");
+        System.err.println("connecting RedirectStreams request");
         ServerAccess.ProcessResult pr = server.executeJavawsHeadless(null, "/RedirectStreams.jnlp");
         System.out.println(pr.stdout);
         System.err.println(pr.stderr);
-        Assert.assertTrue(pr.stderr.contains("java.security.AccessControlException: access denied (java.lang.RuntimePermission setIO)"));
-        Assert.assertFalse(pr.stderr.contains("ClassNotFoundException"));
-        Assert.assertFalse(pr.stdout.length() > 2);
-        Assert.assertFalse(pr.wasTerminated);
+        String s="java.security.AccessControlException: access denied (java.lang.RuntimePermission setIO)";
+        Assert.assertTrue("Stderr should contains "+s+" but didn't",pr.stderr.contains(s));
+        String cc="ClassNotFoundException";
+        Assert.assertFalse("stderr should NOT contains `"+cc+"`, but did",pr.stderr.contains(cc));
+        Assert.assertFalse("stdout length should be <=2, but was "+pr.stdout.length(),pr.stdout.length()>2);
+        Assert.assertFalse("RedirectStreams should not be terminated, but was",pr.wasTerminated);
         Assert.assertEquals((Integer) 0, pr.returnValue);
     }
 }
--- a/tests/jnlp_tests/simple/ReplaceSecurityManager/testcases/ReplaceSecurityManagerTest.java	Tue Sep 13 16:23:04 2011 -0400
+++ b/tests/jnlp_tests/simple/ReplaceSecurityManager/testcases/ReplaceSecurityManagerTest.java	Thu Sep 15 15:27:40 2011 +0200
@@ -45,14 +45,17 @@
 
     @Test
     public void ReplaceSecurityManagerLunch1() throws Exception {
-        System.out.println("connecting RedirectStreams request");
+        System.out.println("connecting ReplaceSecurityManager request");
+        System.err.println("connecting ReplaceSecurityManager request");
         ServerAccess.ProcessResult pr = server.executeJavawsHeadless(null, "/ReplaceSecurityManager.jnlp");
         System.out.println(pr.stdout);
         System.err.println(pr.stderr);
-        Assert.assertTrue(pr.stderr.contains("java.security.AccessControlException: access denied (java.lang.RuntimePermission setSecurityManager)"));
-        Assert.assertFalse(pr.stderr.contains("ClassNotFoundException"));
-        Assert.assertFalse(pr.stdout.length() > 2);
-        Assert.assertFalse(pr.wasTerminated);
+        String s="java.security.AccessControlException: access denied (java.lang.RuntimePermission setSecurityManager)";
+        Assert.assertTrue("stderr should contains "+s+" but didn't",pr.stderr.contains(s));
+        String cc="ClassNotFoundException";
+        Assert.assertFalse("stderr should NOT contains `"+cc+"`, but did",pr.stderr.contains(cc));
+        Assert.assertFalse("stdout length should be <=2, but was "+pr.stdout.length(),pr.stdout.length()>2);
+        Assert.assertFalse("ReplaceSecurityManagerLunch1 should not be terminated, but was",pr.wasTerminated);
         Assert.assertEquals((Integer) 0, pr.returnValue);
     }
 }
--- a/tests/jnlp_tests/simple/SetContextClassLoader/testcases/SetContextClassLoaderTest.java	Tue Sep 13 16:23:04 2011 -0400
+++ b/tests/jnlp_tests/simple/SetContextClassLoader/testcases/SetContextClassLoaderTest.java	Thu Sep 15 15:27:40 2011 +0200
@@ -45,14 +45,17 @@
 
     @Test
     public void SetContextClassLoader1() throws Exception {
-        System.out.println("connecting RedirectStreams request");
+        System.out.println("connecting SetContextClassLoader request");
+        System.err.println("connecting SetContextClassLoader request");
         ServerAccess.ProcessResult pr = server.executeJavawsHeadless(null, "/SetContextClassLoader.jnlp");
         System.out.println(pr.stdout);
         System.err.println(pr.stderr);
-        Assert.assertTrue(pr.stderr.contains("java.security.AccessControlException: access denied (java.lang.RuntimePermission setContextClassLoader)"));
-        Assert.assertFalse(pr.stderr.contains("ClassNotFoundException"));
-        Assert.assertFalse(pr.stdout.length() > 2);
-        Assert.assertFalse(pr.wasTerminated);
+        String s="java.security.AccessControlException: access denied (java.lang.RuntimePermission setContextClassLoader)";
+        Assert.assertTrue("stderr should contains "+s+" but didn't",pr.stderr.contains(s));
+        String cc="ClassNotFoundException";
+        Assert.assertFalse("stderr should NOT contains `"+cc+"`, but did",pr.stderr.contains(cc));
+        Assert.assertFalse("stdout length should be <=2, but was "+pr.stdout.length(),pr.stdout.length()>2);
+        Assert.assertFalse("SetContextClassLoader1 should not be terminated, but was",pr.wasTerminated);
         Assert.assertEquals((Integer) 0, pr.returnValue);
     }
 }
--- a/tests/jnlp_tests/simple/deadlocktest/testcases/DeadLockTestTest.java	Tue Sep 13 16:23:04 2011 -0400
+++ b/tests/jnlp_tests/simple/deadlocktest/testcases/DeadLockTestTest.java	Thu Sep 15 15:27:40 2011 +0200
@@ -49,12 +49,13 @@
    @Test
     public void testDeadLockTestTerminated() throws Exception {
         System.out.println("connecting deadlocktest request");
+        System.err.println("connecting deadlocktest request");
         ServerAccess.ProcessResult pr=server.executeJavawsHeadless(null,"/deadlocktest.jnlp");
         System.out.println(pr.stdout);
         System.err.println(pr.stderr);
         Assert.assertFalse(pr.stdout.contains("This process is hanging more then 30s. Should be killed"));
 //        Assert.assertTrue(pr.stderr.contains("xception"));, exception is thrown by engine,not by application
-        Assert.assertTrue(pr.wasTerminated);
+        Assert.assertTrue("testDeadLockTestTerminated should be terminated, but wasn't",pr.wasTerminated);
         Assert.assertEquals(null, pr.returnValue);//killed process have no value
     }
 
--- a/tests/jnlp_tests/simple/simpletest1/testcases/SimpleTest1Test.java	Tue Sep 13 16:23:04 2011 -0400
+++ b/tests/jnlp_tests/simple/simpletest1/testcases/SimpleTest1Test.java	Thu Sep 15 15:27:40 2011 +0200
@@ -50,11 +50,14 @@
     @Test
     public void testSimpletest1lunchOk() throws Exception {
         System.out.println("connecting simpletest1 request");
+        System.err.println("connecting simpletest1 request");
         ServerAccess.ProcessResult pr=server.executeJavawsHeadless(null,"/simpletest1.jnlp");
         System.out.println(pr.stdout);
         System.err.println(pr.stderr);
-        Assert.assertTrue(pr.stdout.contains("Good simple javaws exapmle"));
-        Assert.assertFalse(pr.stderr.contains("xception"));
+        String s="Good simple javaws exapmle";
+        Assert.assertTrue("testSimpletest1lunchOk stdout should contains "+s+" bud didn't",pr.stdout.contains(s));
+        String ss="xception";
+        Assert.assertFalse("testSimpletest1lunchOk stderr should not contains "+ss+" but did",pr.stderr.contains(ss));
         Assert.assertFalse(pr.wasTerminated);
         Assert.assertEquals((Integer)0, pr.returnValue);
     }
@@ -63,4 +66,4 @@
 
 
 
-    }
\ No newline at end of file
+    }
--- a/tests/jnlp_tests/simple/simpletest2/testcases/SimpleTest2Test.java	Tue Sep 13 16:23:04 2011 -0400
+++ b/tests/jnlp_tests/simple/simpletest2/testcases/SimpleTest2Test.java	Thu Sep 15 15:27:40 2011 +0200
@@ -48,13 +48,16 @@
     @Test
     public void testSimpletest2lunchException() throws Exception {
         System.out.println("connecting simpletest2 request");
+        System.err.println("connecting simpletest2 request");
         ServerAccess.ProcessResult pr=server.executeJavawsHeadless(null,"/simpletest2.jnlp");
         System.out.println(pr.stdout);
         System.err.println(pr.stderr);
-        Assert.assertTrue(pr.stdout.trim().length() < 1);
-        Assert.assertTrue(pr.stderr.contains("Correct exception"));
-        Assert.assertTrue(pr.stderr.contains("Exception"));
-        Assert.assertFalse(pr.wasTerminated);
+        Assert.assertTrue("stdout should be < 1 , but was "+pr.stdout.trim().length(),pr.stdout.trim().length() < 1);
+        String s="Correct exception";
+        Assert.assertTrue("stderr should contains "+s+" but didn't",pr.stderr.contains(s));
+        String ss="Exception";
+        Assert.assertTrue("stderr should contains "+ss+" but did not",pr.stderr.contains(ss));
+        Assert.assertFalse("testSimpletest2lunchException should not be terminated, but was",pr.wasTerminated);
         //Assert.assertFalse(0==pr.returnValue);exception and still returned 0?
     }