Mercurial > hg > release > icedtea-web-1.3

changeset 506:c89c2bf6707b

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Provide names for unnamed threads for better debugging
author Adam Domurad <adomurad@redhat.com>
date Wed, 06 Feb 2013 09:22:51 -0500
parents b619cda99360
children f63bdf513e9d
files ChangeLog netx/net/sourceforge/jnlp/NetxPanel.java netx/net/sourceforge/jnlp/runtime/JNLPRuntime.java plugin/icedteanp/java/sun/applet/PluginMessageConsumer.java plugin/icedteanp/java/sun/applet/PluginMessageHandlerWorker.java plugin/icedteanp/java/sun/applet/PluginStreamHandler.java
diffstat 6 files changed, 27 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Wed Jan 16 15:34:44 2013 -0500
+++ b/ChangeLog	Wed Feb 06 09:22:51 2013 -0500
@@ -1,3 +1,20 @@
+2013-02-06  Adam Domurad <adomurad@redhat.com>
+
+	Name threads for easier debugging/tooling. Remove 2 erroneous
+	VoidPluginCallRequest header comments.
+	* netx/net/sourceforge/jnlp/NetxPanel.java:
+	Provide name for thread that calls (run).
+	* netx/net/sourceforge/jnlp/runtime/JNLPRuntime.java:
+	Provide name for shutdown hook thread.
+	* plugin/icedteanp/java/sun/applet/PluginMessageConsumer.java:
+	Remove erroneous VoidPluginCallRequest comment. Provide name for
+	ConsumerThread thread.
+	* plugin/icedteanp/java/sun/applet/PluginMessageHandlerWorker.java:
+	Provide name for worker thread.
+	* plugin/icedteanp/java/sun/applet/PluginStreamHandler.java:
+	Remove erroneous VoidPluginCallRequest comment. Provide name for
+	stream listener thread.
+
 2013-01-16  Deepak Bhole <dbhole@redhat.com>
 
 	PR1260: IcedTea-Web should not rely on GTK
--- a/netx/net/sourceforge/jnlp/NetxPanel.java	Wed Jan 16 15:34:44 2013 -0500
+++ b/netx/net/sourceforge/jnlp/NetxPanel.java	Wed Feb 06 09:22:51 2013 -0500
@@ -199,7 +199,7 @@
             }
         }
 
-        handler = new Thread(getThreadGroup(), this);
+        handler = new Thread(getThreadGroup(), this, "NetxPanelThread@" + this.documentURL);
         handler.start();
     }
 
--- a/netx/net/sourceforge/jnlp/runtime/JNLPRuntime.java	Wed Jan 16 15:34:44 2013 -0500
+++ b/netx/net/sourceforge/jnlp/runtime/JNLPRuntime.java	Wed Feb 06 09:22:51 2013 -0500
@@ -737,7 +737,7 @@
             e.printStackTrace();
         }
 
-        Runtime.getRuntime().addShutdownHook(new Thread() {
+        Runtime.getRuntime().addShutdownHook(new Thread("JNLPRuntimeShutdownHookThread") {
             public void run() {
                 markNetxStopped();
                 CacheUtil.cleanCache();
--- a/plugin/icedteanp/java/sun/applet/PluginMessageConsumer.java	Wed Jan 16 15:34:44 2013 -0500
+++ b/plugin/icedteanp/java/sun/applet/PluginMessageConsumer.java	Wed Feb 06 09:22:51 2013 -0500
@@ -1,4 +1,4 @@
-/* VoidPluginCallRequest -- represent Java-to-JavaScript requests
+/* 
    Copyright (C) 2008  Red Hat
 
 This file is part of IcedTea.
@@ -131,6 +131,10 @@
 
     protected class ConsumerThread extends Thread {
 
+        public ConsumerThread() {
+            super("PluginMessageConsumer.ConsumerThread");
+        }
+
         /**
          * Scans the readQueue for priority messages and brings them to the front
          */
--- a/plugin/icedteanp/java/sun/applet/PluginMessageHandlerWorker.java	Wed Jan 16 15:34:44 2013 -0500
+++ b/plugin/icedteanp/java/sun/applet/PluginMessageHandlerWorker.java	Wed Feb 06 09:22:51 2013 -0500
@@ -50,6 +50,7 @@
                 PluginMessageConsumer consumer,
                 PluginStreamHandler streamHandler, int id,
                 boolean isPriorityWorker) {
+        super("PluginMessageHandlerWorker" + id);
 
         this.id = id;
         this.streamHandler = streamHandler;
--- a/plugin/icedteanp/java/sun/applet/PluginStreamHandler.java	Wed Jan 16 15:34:44 2013 -0500
+++ b/plugin/icedteanp/java/sun/applet/PluginStreamHandler.java	Wed Feb 06 09:22:51 2013 -0500
@@ -1,4 +1,4 @@
-/* VoidPluginCallRequest -- represent Java-to-JavaScript requests
+/*
    Copyright (C) 2008  Red Hat
 
 This file is part of IcedTea.
@@ -81,7 +81,7 @@
 
     public void startProcessing() {
 
-        Thread listenerThread = new Thread() {
+        Thread listenerThread = new Thread("PluginStreamHandlerListenerThread") {
 
             public void run() {