Mercurial > hg > openjdk > jdk9 > nashorn
changeset 1618:4e9749cc32f1 jdk-9+105
8149334: JSON.parse(JSON.stringify([])).push(10) creates an array containing two elements
Reviewed-by: jlaskey, sundar
| author | mhaupt |
|---|---|
| date | Mon, 08 Feb 2016 17:43:02 +0100 |
| parents | f35bd1bd0184 |
| children | 1766d9d909c2 7ac82655d829 |
| files | src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/arrays/ArrayData.java test/script/nosecurity/JDK-8149334.js test/script/nosecurity/JDK-8149334.js.EXPECTED |
| diffstat | 3 files changed, 50 insertions(+), 6 deletions(-) [+] |
line wrap: on
line diff
--- a/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/arrays/ArrayData.java Mon Feb 08 12:59:08 2016 +0100 +++ b/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/arrays/ArrayData.java Mon Feb 08 17:43:02 2016 +0100 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2010, 2016, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -81,14 +81,11 @@ } private ArrayData toRealArrayData() { - return toRealArrayData(0); + return new IntArrayData(0); } private ArrayData toRealArrayData(final int index) { final IntArrayData newData = new IntArrayData(index + 1); - if (index == 0) { - return newData; - } return new DeletedRangeArrayFilter(newData, 0, index); } @@ -122,7 +119,7 @@ @Override public ArrayData convert(final Class<?> type) { - return toRealArrayData(0).convert(type); + return toRealArrayData().convert(type); } @Override
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/script/nosecurity/JDK-8149334.js Mon Feb 08 17:43:02 2016 +0100 @@ -0,0 +1,41 @@ +/* + * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/** + * JDK-8149334: JSON.parse(JSON.stringify([])).push(10) creates an array containing two elements + * + * @test + * @run + */ + +var a = JSON.parse(JSON.stringify([])) +print(a.length) +a.push(10) +print(a.length) +print(a) + +var b = JSON.parse(JSON.stringify([])) +print(b.length) +b.push('ieps') +print(b.length) +print(b)