Mercurial > hg > openjdk > jdk8u > hotspot
changeset 9468:85c1e19cae36
Merge
author | andrew |
---|---|
date | Wed, 26 May 2021 18:02:41 +0100 |
parents | 76c173746025 (current diff) 2d8e910c71e3 (diff) |
children | 4962a2ce077a |
files | test/runtime/8001071/Test8001071.java test/runtime/8001071/Test8001071.sh |
diffstat | 9 files changed, 75 insertions(+), 108 deletions(-) [+] |
line wrap: on
line diff
--- a/src/cpu/aarch64/vm/macroAssembler_aarch64.cpp Tue May 25 05:53:14 2021 +0100 +++ b/src/cpu/aarch64/vm/macroAssembler_aarch64.cpp Wed May 26 18:02:41 2021 +0100 @@ -644,6 +644,11 @@ // do the call, remove parameters MacroAssembler::call_VM_leaf_base(entry_point, number_of_arguments, &l); + // lr could be poisoned with PAC signature during throw_pending_exception + // if it was tail-call optimized by compiler, since lr is not callee-saved + // reload it with proper value + adr(lr, l); + // reset last Java frame // Only interpreter should have to clear fp reset_last_Java_frame(true);
--- a/src/share/vm/jfr/jni/jfrJniMethod.cpp Tue May 25 05:53:14 2021 +0100 +++ b/src/share/vm/jfr/jni/jfrJniMethod.cpp Wed May 26 18:02:41 2021 +0100 @@ -238,6 +238,10 @@ JfrJavaLog::log(tag_set, level, message, thread); JVM_END +JVM_ENTRY_NO_ENV(jboolean, jfr_should_log(JNIEnv* env, jobject jvm, jint level)) + return JfrJavaLog::should_log(level, thread) ? JNI_TRUE : JNI_FALSE; +JVM_END + JVM_ENTRY_NO_ENV(void, jfr_subscribe_log_level(JNIEnv* env, jobject jvm, jobject log_tag, jint id)) JfrJavaLog::subscribe_log_level(log_tag, id, thread); JVM_END
--- a/src/share/vm/jfr/jni/jfrJniMethod.hpp Tue May 25 05:53:14 2021 +0100 +++ b/src/share/vm/jfr/jni/jfrJniMethod.hpp Wed May 26 18:02:41 2021 +0100 @@ -67,6 +67,8 @@ void JNICALL jfr_log(JNIEnv* env, jobject jvm, jint tag_set, jint level, jstring message); +jboolean JNICALL jfr_should_log(JNIEnv* env, jobject jvm, jint level); + void JNICALL jfr_retransform_classes(JNIEnv* env, jobject jvm, jobjectArray classes); void JNICALL jfr_set_enabled(JNIEnv* env, jobject jvm, jlong event_type_id, jboolean enabled);
--- a/src/share/vm/jfr/jni/jfrJniMethodRegistration.cpp Tue May 25 05:53:14 2021 +0100 +++ b/src/share/vm/jfr/jni/jfrJniMethodRegistration.cpp Wed May 26 18:02:41 2021 +0100 @@ -49,6 +49,7 @@ (char*)"getTicksFrequency", (char*)"()J", (void*)jfr_elapsed_frequency, (char*)"subscribeLogLevel", (char*)"(Ljdk/jfr/internal/LogTag;I)V", (void*)jfr_subscribe_log_level, (char*)"log", (char*)"(IILjava/lang/String;)V", (void*)jfr_log, + (char*)"shouldLog", (char*)"(I)Z", (void*)jfr_should_log, (char*)"retransformClasses", (char*)"([Ljava/lang/Class;)V", (void*)jfr_retransform_classes, (char*)"setEnabled", (char*)"(JZ)V", (void*)jfr_set_enabled, (char*)"setFileNotification", (char*)"(J)V", (void*)jfr_set_file_notification,
--- a/src/share/vm/jfr/utilities/jfrJavaLog.cpp Tue May 25 05:53:14 2021 +0100 +++ b/src/share/vm/jfr/utilities/jfrJavaLog.cpp Wed May 26 18:02:41 2021 +0100 @@ -139,3 +139,7 @@ // log_tag_sets[tag_set].log_tag_set->log((LogLevelType)level, s); tty->print_cr("JFR: %s", s); } + +bool JfrJavaLog::should_log(jint level, TRAPS) { + return LogJFR; +}
--- a/src/share/vm/jfr/utilities/jfrJavaLog.hpp Tue May 25 05:53:14 2021 +0100 +++ b/src/share/vm/jfr/utilities/jfrJavaLog.hpp Wed May 26 18:02:41 2021 +0100 @@ -43,6 +43,7 @@ public: static void subscribe_log_level(jobject log_tag, jint id, TRAPS); static void log(jint tag_set, jint level, jstring message, TRAPS); + static bool should_log(jint level, TRAPS); }; #endif // SHARE_VM_JFR_UTILITIES_JFRJAVALOG_HPP
--- a/test/runtime/8001071/Test8001071.java Tue May 25 05:53:14 2021 +0100 +++ /dev/null Thu Jan 01 00:00:00 1970 +0000 @@ -1,45 +0,0 @@ -/* - * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA - * or visit www.oracle.com if you need additional information or have any - * questions. - */ - -import sun.misc.Unsafe; -import java.lang.reflect.Field; - -@SuppressWarnings("sunapi") -public class Test8001071 { - public static Unsafe unsafe; - - static { - try { - Field f = Unsafe.class.getDeclaredField("theUnsafe"); - f.setAccessible(true); - unsafe = (Unsafe) f.get(null); - } catch ( Exception e ) { - e.printStackTrace(); - } - } - - public static void main(String args[]) { - unsafe.getObject(new Test8001071(), Short.MAX_VALUE); - } - -}
--- a/test/runtime/8001071/Test8001071.sh Tue May 25 05:53:14 2021 +0100 +++ /dev/null Thu Jan 01 00:00:00 1970 +0000 @@ -1,63 +0,0 @@ -#!/bin/sh - -# Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. -# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. -# -# This code is free software; you can redistribute it and/or modify it -# under the terms of the GNU General Public License version 2 only, as -# published by the Free Software Foundation. -# -# This code is distributed in the hope that it will be useful, but WITHOUT -# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or -# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License -# version 2 for more details (a copy is included in the LICENSE file that -# accompanied this code). -# -# You should have received a copy of the GNU General Public License version -# 2 along with this work; if not, write to the Free Software Foundation, -# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. -# -# Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA -# or visit www.oracle.com if you need additional information or have any -# questions. - -## @test -## @bug 8001071 -## @summary Add simple range check into VM implemenation of Unsafe access methods -## @compile Test8001071.java -## @run shell Test8001071.sh -## @author filipp.zhinkin@oracle.com - -VERSION=`${TESTJAVA}/bin/java ${TESTVMOPTS} -version 2>&1` - -if [ -n "`echo $VERSION | grep debug`" -o -n "`echo $VERSION | grep jvmg`" ]; then - echo "Build type check passed" - echo "Continue testing" -else - echo "Fastdebug build is required for this test" - exit 0 -fi - -${TESTJAVA}/bin/java -cp ${TESTCLASSES} ${TESTVMOPTS} Test8001071 2>&1 - -HS_ERR_FILE=hs_err_pid*.log - -if [ ! -f $HS_ERR_FILE ] -then - echo "hs_err_pid log file was not found" - echo "Test failed" - exit 1 -fi - -grep "assert(byte_offset < p_size) failed: Unsafe access: offset.*> object's size.*" $HS_ERR_FILE - -if [ "0" = "$?" ]; -then - echo "Range check assertion failed as expected" - echo "Test passed" - exit 0 -else - echo "Range check assertion was not failed" - echo "Test failed" - exit 1 -fi
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/runtime/Unsafe/RangeCheck.java Wed May 26 18:02:41 2021 +0100 @@ -0,0 +1,58 @@ +/* + * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8001071 + * @summary Add simple range check into VM implemenation of Unsafe access methods + * @library /testlibrary + */ + +import com.oracle.java.testlibrary.*; +import sun.misc.Unsafe; + +public class RangeCheck { + + public static void main(String args[]) throws Exception { + if (!Platform.isDebugBuild()) { + System.out.println("Testing assert which requires a debug build. Passing silently."); + return; + } + + ProcessBuilder pb = ProcessTools.createJavaProcessBuilder( + true, + "-Xmx32m", + "-XX:-TransmitErrorReport", + DummyClassWithMainRangeCheck.class.getName()); + + OutputAnalyzer output = new OutputAnalyzer(pb.start()); + output.shouldMatch("assert\\(byte_offset < p_size\\) failed: Unsafe access: offset \\d+ > object's size \\d+"); + } + + public static class DummyClassWithMainRangeCheck { + public static void main(String args[]) throws Exception { + Unsafe unsafe = Utils.getUnsafe(); + unsafe.getObject(new DummyClassWithMainRangeCheck(), Short.MAX_VALUE); + } + } +}