Mercurial > hg > openjdk > jdk8 > jdk
changeset 8069:657482758408
7097386: Correct error in Predicate javadoc example
Reviewed-by: alanb, shade
author | lancea |
---|---|
date | Tue, 17 Sep 2013 07:56:56 -0400 |
parents | 86aa8e7503e9 |
children | ebc44e50df79 8708569b5524 2b928330970a |
files | src/share/classes/javax/sql/rowset/Predicate.java |
diffstat | 1 files changed, 20 insertions(+), 21 deletions(-) [+] |
line wrap: on
line diff
--- a/src/share/classes/javax/sql/rowset/Predicate.java Mon Sep 16 10:28:20 2013 -0700 +++ b/src/share/classes/javax/sql/rowset/Predicate.java Tue Sep 17 07:56:56 2013 -0400 @@ -56,44 +56,43 @@ * <pre>{@code * public class Range implements Predicate { * - * private Object lo[]; - * private Object hi[]; - * private int idx[]; + * private int[] lo; + * private int[] hi; + * private int[] idx; * - * public Range(Object[] lo, Object[] hi, int[] idx) { + * public Range(int[] lo, int[] hi, int[] idx) { * this.lo = lo; * this.hi = hi; * this.idx = idx; * } * * public boolean evaluate(RowSet rs) { - * CachedRowSet crs = (CachedRowSet)rs; - * boolean bool1,bool2; * * // Check the present row determine if it lies * // within the filtering criteria. * * for (int i = 0; i < idx.length; i++) { + * int value; + * try { + * value = (Integer) rs.getObject(idx[i]); + * } catch (SQLException ex) { + * Logger.getLogger(Range.class.getName()).log(Level.SEVERE, null, ex); + * return false; + * } * - * if ((rs.getObject(idx[i]) >= lo[i]) && - * (rs.getObject(idx[i]) >= hi[i]) { - * bool1 = true; // within filter constraints - * } else { - * bool2 = true; // outside of filter constraints - * } - * } - * - * if (bool2) { - * return false; - * } else { - * return true; - * } + * if (value < lo[i] && value > hi[i]) { + * // outside of filter constraints + * return false; + * } + * } + * // Within filter constraints + * return true; * } - * } + * } * }</pre> * <P> * The example above implements a simple range predicate. Note, that - * implementations should but are not required to provider <code>String</code> + * implementations should but are not required to provide <code>String</code> * and integer index based constructors to provide for JDBC RowSet Implementation * applications that use both column identification conventions. *