changeset 1416:19263eb2ff0c

8081809: Missing final modifier in method parameters (nashorn code convention) Reviewed-by: attila, lagergren
author sundar
date Fri, 05 Jun 2015 14:46:52 +0530
parents d5a9705a27b1
children 2f1b9f4daec1
files src/jdk/nashorn/internal/codegen/CompilationPhase.java src/jdk/nashorn/internal/codegen/SplitIntoFunctions.java src/jdk/nashorn/internal/ir/SplitReturn.java src/jdk/nashorn/internal/ir/TryNode.java src/jdk/nashorn/internal/runtime/linker/NashornBeansLinker.java
diffstat 5 files changed, 6 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/src/jdk/nashorn/internal/codegen/CompilationPhase.java	Wed Jun 03 18:08:57 2015 +0200
+++ b/src/jdk/nashorn/internal/codegen/CompilationPhase.java	Fri Jun 05 14:46:52 2015 +0530
@@ -363,7 +363,7 @@
             //partial code generation
             final FunctionNode newFunctionNode = transformFunction(fn, new ReplaceCompileUnits() {
                 @Override
-                CompileUnit getReplacement(CompileUnit original) {
+                CompileUnit getReplacement(final CompileUnit original) {
                     return map.get(original);
                 }
 
--- a/src/jdk/nashorn/internal/codegen/SplitIntoFunctions.java	Wed Jun 03 18:08:57 2015 +0200
+++ b/src/jdk/nashorn/internal/codegen/SplitIntoFunctions.java	Fri Jun 05 14:46:52 2015 +0530
@@ -101,7 +101,7 @@
     public SplitIntoFunctions(final Compiler compiler) {
         super(new BlockLexicalContext() {
             @Override
-            protected Block afterSetStatements(Block block) {
+            protected Block afterSetStatements(final Block block) {
                 for(Statement stmt: block.getStatements()) {
                     assert !(stmt instanceof SplitNode);
                 }
@@ -301,7 +301,7 @@
     }
 
     @Override
-    public boolean enterVarNode(VarNode varNode) {
+    public boolean enterVarNode(final VarNode varNode) {
         if (!inSplitNode()) {
             return super.enterVarNode(varNode);
         }
--- a/src/jdk/nashorn/internal/ir/SplitReturn.java	Wed Jun 03 18:08:57 2015 +0200
+++ b/src/jdk/nashorn/internal/ir/SplitReturn.java	Fri Jun 05 14:46:52 2015 +0530
@@ -54,7 +54,7 @@
     }
 
     @Override
-    public void toString(StringBuilder sb, boolean printType) {
+    public void toString(final StringBuilder sb, final boolean printType) {
         sb.append(":splitreturn;");
     }
 
--- a/src/jdk/nashorn/internal/ir/TryNode.java	Wed Jun 03 18:08:57 2015 +0200
+++ b/src/jdk/nashorn/internal/ir/TryNode.java	Fri Jun 05 14:46:52 2015 +0530
@@ -122,7 +122,7 @@
      * @param visitor IR navigating visitor.
      */
     @Override
-    public Node accept(final LexicalContext lc, NodeVisitor<? extends LexicalContext> visitor) {
+    public Node accept(final LexicalContext lc, final NodeVisitor<? extends LexicalContext> visitor) {
         if (visitor.enterTryNode(this)) {
             // Need to do finallybody first for termination analysis. TODO still necessary?
             final Block newFinallyBody = finallyBody == null ? null : (Block)finallyBody.accept(visitor);
--- a/src/jdk/nashorn/internal/runtime/linker/NashornBeansLinker.java	Wed Jun 03 18:08:57 2015 +0200
+++ b/src/jdk/nashorn/internal/runtime/linker/NashornBeansLinker.java	Fri Jun 05 14:46:52 2015 +0530
@@ -246,7 +246,7 @@
         }
 
         @Override
-        public MethodHandle filterInternalObjects(MethodHandle target) {
+        public MethodHandle filterInternalObjects(final MethodHandle target) {
             return linkerServices.filterInternalObjects(target);
         }
     }