Mercurial > hg > openjdk > aarch64-port > hotspot
changeset 8573:85e9169ff89c
8138966: Intermittent SEGV running ParallelGC
Summary: Add necessary memory fences so that the parallel threads are unable to observe partially filled block tables.
Reviewed-by: tschatzl
| author | aph |
|---|---|
| date | Wed, 04 Nov 2015 13:38:38 +0100 |
| parents | 3b837e8988b5 |
| children | 3b4d83989d8e |
| files | src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp |
| diffstat | 1 files changed, 5 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp Tue Sep 08 14:08:58 2015 +0100 +++ b/src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp Wed Nov 04 13:38:38 2015 +0100 @@ -348,7 +348,7 @@ HeapWord* _partial_obj_addr; region_sz_t _partial_obj_size; region_sz_t volatile _dc_and_los; - bool _blocks_filled; + bool volatile _blocks_filled; #ifdef ASSERT size_t _blocks_filled_count; // Number of block table fills. @@ -499,7 +499,9 @@ inline bool ParallelCompactData::RegionData::blocks_filled() const { - return _blocks_filled; + bool result = _blocks_filled; + OrderAccess::acquire(); + return result; } #ifdef ASSERT @@ -513,6 +515,7 @@ inline void ParallelCompactData::RegionData::set_blocks_filled() { + OrderAccess::release(); _blocks_filled = true; // Debug builds count the number of times the table was filled. DEBUG_ONLY(Atomic::inc_ptr(&_blocks_filled_count));