Mercurial > hg > heapstats
changeset 190:0505e8809f39
Bug 3254: Incorrect time value in tooltip on SnapShot Histogram
Reviewed-by: ykubota
https://github.com/HeapStats/heapstats/pull/50
author | Yasumasa Suenaga <yasuenag@gmail.com> |
---|---|
date | Sat, 03 Dec 2016 23:25:27 +0900 |
parents | 8f717a109972 |
children | e91a7dea56df |
files | ChangeLog analyzer/fx/src/main/java/jp/co/ntt/oss/heapstats/plugin/builtin/snapshot/tabs/HistogramController.java |
diffstat | 2 files changed, 10 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/ChangeLog Mon Nov 21 22:51:37 2016 +0900 +++ b/ChangeLog Sat Dec 03 23:25:27 2016 +0900 @@ -1,3 +1,7 @@ +2016-12-03 Yasumasa Suenaga <yasuenag@gmail.com> + + * Bug 3254: Incorrect time value in tooltip on SnapShot Histogram + 2016-11-21 Yasumasa Suenaga <yasuenag@gmail.com> * Bug 3234: HeapStats agent cannot be upgraded with `rpm -U`
--- a/analyzer/fx/src/main/java/jp/co/ntt/oss/heapstats/plugin/builtin/snapshot/tabs/HistogramController.java Mon Nov 21 22:51:37 2016 +0900 +++ b/analyzer/fx/src/main/java/jp/co/ntt/oss/heapstats/plugin/builtin/snapshot/tabs/HistogramController.java Sat Dec 03 23:25:27 2016 +0900 @@ -75,6 +75,7 @@ import jp.co.ntt.oss.heapstats.plugin.builtin.snapshot.BindingFilter; import jp.co.ntt.oss.heapstats.plugin.builtin.snapshot.ChartColorManager; import jp.co.ntt.oss.heapstats.task.DiffCalculator; +import jp.co.ntt.oss.heapstats.utils.EpochTimeConverter; import jp.co.ntt.oss.heapstats.utils.HeapStatsUtils; import jp.co.ntt.oss.heapstats.utils.TaskAdapter; import jp.co.ntt.oss.heapstats.xml.binding.Filter; @@ -151,6 +152,8 @@ private Consumer<Task<Void>> taskExecutor; private List<String> hideRegexList; + + private EpochTimeConverter epochTimeConverter; /** * Initializes the controller class. @@ -215,6 +218,8 @@ .map(d -> d.getTag()) .orElse(0xffffffffffffffffl), lastDiffTable.getSelectionModel().selectedItemProperty())); + + epochTimeConverter = new EpochTimeConverter(); } /** @@ -242,7 +247,7 @@ series.getData().add(data); String unit = instanceGraph.get() ? "instances" : "MB"; - String tip = String.format("%s: %s, %d " + unit, series.getName(), time, yValue); + String tip = String.format("%s: %s, %d " + unit, series.getName(), epochTimeConverter.toString(time), yValue); Tooltip.install(data.getNode(), new Tooltip(tip)); }