Mercurial > hg > arm32-8
changeset 7247:f996dba3f54e
8067991: [Findbugs] SA com.sun.java.swing.ui.CommonUI some methods need final protect
Summary: Fixed java programmint style nit
Reviewed-by: jbachorik, sspitsyn
author | dsamersoff |
---|---|
date | Tue, 07 Apr 2015 02:56:25 -0700 |
parents | 10d10330688b |
children | 04e84c0579be |
files | agent/src/share/classes/com/sun/java/swing/ui/CommonToolBar.java agent/src/share/classes/com/sun/java/swing/ui/CommonUI.java |
diffstat | 2 files changed, 21 insertions(+), 16 deletions(-) [+] |
line wrap: on
line diff
--- a/agent/src/share/classes/com/sun/java/swing/ui/CommonToolBar.java Fri Apr 03 10:12:57 2015 -0700 +++ b/agent/src/share/classes/com/sun/java/swing/ui/CommonToolBar.java Tue Apr 07 02:56:25 2015 -0700 @@ -46,7 +46,7 @@ { this.manager = manager; statusBar = status; - buttonSize = new Dimension(CommonUI.buttconPrefSize); + buttonSize = new Dimension(CommonUI.getButtconPrefSize()); buttonInsets = new Insets(0, 0, 0, 0); addComponents(); }
--- a/agent/src/share/classes/com/sun/java/swing/ui/CommonUI.java Fri Apr 03 10:12:57 2015 -0700 +++ b/agent/src/share/classes/com/sun/java/swing/ui/CommonUI.java Tue Apr 07 02:56:25 2015 -0700 @@ -373,20 +373,25 @@ comp.setCursor(Cursor.getPredefinedCursor(0)); } - public static final int BUTTON_WIDTH = 100; - public static final int BUTTON_HEIGHT = 26; - public static final int BUTTCON_WIDTH = 28; - public static final int BUTTCON_HEIGHT = 28; - public static final int SM_BUTTON_WIDTH = 72; - public static final int SM_BUTTON_HEIGHT = 26; - public static final int LABEL_WIDTH = 100; - public static final int LABEL_HEIGHT = 20; - public static final int TEXT_WIDTH = 150; - public static final int TEXT_HEIGHT = 20; - public static Dimension buttonPrefSize = new Dimension(100, 26); - public static Dimension buttconPrefSize = new Dimension(28, 28); - public static Dimension smbuttonPrefSize = new Dimension(72, 26); - public static Dimension labelPrefSize = new Dimension(100, 20); - public static Dimension textPrefSize = new Dimension(150, 20); + public static Dimension getButtconPrefSize() + { + return buttconPrefSize; + } + + private static final int BUTTON_WIDTH = 100; + private static final int BUTTON_HEIGHT = 26; + private static final int BUTTCON_WIDTH = 28; + private static final int BUTTCON_HEIGHT = 28; + private static final int SM_BUTTON_WIDTH = 72; + private static final int SM_BUTTON_HEIGHT = 26; + private static final int LABEL_WIDTH = 100; + private static final int LABEL_HEIGHT = 20; + private static final int TEXT_WIDTH = 150; + private static final int TEXT_HEIGHT = 20; + private static final Dimension buttonPrefSize = new Dimension(100, 26); + private static final Dimension buttconPrefSize = new Dimension(28, 28); + private static final Dimension smbuttonPrefSize = new Dimension(72, 26); + private static final Dimension labelPrefSize = new Dimension(100, 20); + private static final Dimension textPrefSize = new Dimension(150, 20); }