Mercurial > hg > arm32-8

changeset 7222:ad32e85474ff

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
8051837: Remove temporary G1UseParallelRSetUpdating and G1UseParallelRSetScanning flags Reviewed-by: stefank, tschatzl Contributed-by: marcus.larsson@oracle.com
author brutisso
date Thu, 07 Aug 2014 09:35:08 +0200
parents 8e9ede9dd2cd
children 93a69595b807
files src/share/vm/gc_implementation/g1/g1RemSet.cpp src/share/vm/gc_implementation/g1/g1_globals.hpp
diffstat 2 files changed, 2 insertions(+), 25 deletions(-) [+]
line wrap: on
line diff
--- a/src/share/vm/gc_implementation/g1/g1RemSet.cpp	Mon Dec 08 18:57:33 2014 +0100
+++ b/src/share/vm/gc_implementation/g1/g1RemSet.cpp	Thu Aug 07 09:35:08 2014 +0200
@@ -341,23 +341,8 @@
 
   assert((ParallelGCThreads > 0) || worker_i == 0, "invariant");
 
-  // The two flags below were introduced temporarily to serialize
-  // the updating and scanning of remembered sets. There are some
-  // race conditions when these two operations are done in parallel
-  // and they are causing failures. When we resolve said race
-  // conditions, we'll revert back to parallel remembered set
-  // updating and scanning. See CRs 6677707 and 6677708.
-  if (G1UseParallelRSetUpdating || (worker_i == 0)) {
-    updateRS(&into_cset_dcq, worker_i);
-  } else {
-    _g1p->phase_times()->record_update_rs_processed_buffers(worker_i, 0);
-    _g1p->phase_times()->record_update_rs_time(worker_i, 0.0);
-  }
-  if (G1UseParallelRSetScanning || (worker_i == 0)) {
-    scanRS(oc, code_root_cl, worker_i);
-  } else {
-    _g1p->phase_times()->record_scan_rs_time(worker_i, 0.0);
-  }
+  updateRS(&into_cset_dcq, worker_i);
+  scanRS(oc, code_root_cl, worker_i);
 
   // We now clear the cached values of _cset_rs_update_cl for this worker
   _cset_rs_update_cl[worker_i] = NULL;
--- a/src/share/vm/gc_implementation/g1/g1_globals.hpp	Mon Dec 08 18:57:33 2014 +0100
+++ b/src/share/vm/gc_implementation/g1/g1_globals.hpp	Thu Aug 07 09:35:08 2014 +0200
@@ -217,14 +217,6 @@
   product(uintx, G1HeapRegionSize, 0,                                       \
           "Size of the G1 regions.")                                        \
                                                                             \
-  experimental(bool, G1UseParallelRSetUpdating, true,                       \
-          "Enables the parallelization of remembered set updating "         \
-          "during evacuation pauses")                                       \
-                                                                            \
-  experimental(bool, G1UseParallelRSetScanning, true,                       \
-          "Enables the parallelization of remembered set scanning "         \
-          "during evacuation pauses")                                       \
-                                                                            \
   product(uintx, G1ConcRefinementThreads, 0,                                \
           "If non-0 is the number of parallel rem set update threads, "     \
           "otherwise the value is determined ergonomically.")               \