Mercurial > hg > thermostat-ng > agent
view plugins/host-memory/agent/src/test/java/com/redhat/thermostat/host/memory/agent/internal/HostMemoryBackendTest.java @ 2733:4a55900090e4
Compare JSON strings as JSON, not strings
This patch adds a assertJsonEquals() method to common-test (bringing in
Gson at test time), and modifies many of the JUnit tests to use it
instead of string compare.
Doing a proper JSON compare means whitespace and member order no longer
needs to be exact. Member order doesn't matter in JSON objects; only
arrays.
Reviewed-by: jkang
Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2017-August/024424.html
author | Simon Tooke <stooke@redhat.com> |
---|---|
date | Wed, 09 Aug 2017 13:26:10 -0400 |
parents | b9ab00ccce2f |
children |
line wrap: on
line source
/* * Copyright 2012-2017 Red Hat, Inc. * * This file is part of Thermostat. * * Thermostat is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published * by the Free Software Foundation; either version 2, or (at your * option) any later version. * * Thermostat is distributed in the hope that it will be useful, but * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. * * You should have received a copy of the GNU General Public License * along with Thermostat; see the file COPYING. If not see * <http://www.gnu.org/licenses/>. * * Linking this code with other modules is making a combined work * based on this code. Thus, the terms and conditions of the GNU * General Public License cover the whole combination. * * As a special exception, the copyright holders of this code give * you permission to link this code with independent modules to * produce an executable, regardless of the license terms of these * independent modules, and to copy and distribute the resulting * executable under terms of your choice, provided that you also * meet, for each linked independent module, the terms and conditions * of the license of that module. An independent module is a module * which is not derived from or based on this code. If you modify * this code, you may extend this exception to your version of the * library, but you are not obligated to do so. If you do not wish * to do so, delete this exception statement from your version. */ package com.redhat.thermostat.host.memory.agent.internal; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertTrue; import static org.mockito.Matchers.any; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.verify; import static org.mockito.Mockito.when; import java.util.concurrent.ScheduledExecutorService; import java.util.concurrent.TimeUnit; import org.junit.Before; import org.junit.Test; import org.mockito.ArgumentCaptor; import com.redhat.thermostat.common.Version; import com.redhat.thermostat.host.memory.model.MemoryStat; import com.redhat.thermostat.storage.core.WriterID; import org.osgi.framework.Bundle; import org.osgi.framework.BundleContext; public class HostMemoryBackendTest { private HostMemoryBackend backend; private ScheduledExecutorService executor; private MemoryStatDAO memoryStatDAO; private WriterID writerID; private Version version; @Before public void setup() { executor = mock(ScheduledExecutorService.class); version = mock(Version.class); when(version.getVersionNumber()).thenReturn("0.0.0"); // these two are created via OSGI wiring memoryStatDAO = mock(MemoryStatDAO.class); writerID = mock(WriterID.class); backend = new HostMemoryBackend("Host Memory Backend", "Gathers memory statistics about a host", "Red Hat, Inc.", version, executor); backend.bindMemoryStatDAO(memoryStatDAO); backend.bindWriterID(writerID); } @Test public void testActivate() { org.osgi.framework.Version osgiVersion = mock(org.osgi.framework.Version.class); Bundle bundle = mock(Bundle.class); when(bundle.getVersion()).thenReturn(osgiVersion); BundleContext ctx = mock(BundleContext.class); when(ctx.getBundle()).thenReturn(bundle); backend.componentActivated(ctx); backend.activate(); ArgumentCaptor<Runnable> captor = ArgumentCaptor.forClass(Runnable.class); verify(executor).scheduleAtFixedRate(captor.capture(), any(Long.class), any(Long.class), any(TimeUnit.class)); assertTrue(backend.isActive()); // Run to ensure working Runnable runnable = captor.getValue(); runnable.run(); verify(memoryStatDAO).put(any(MemoryStat.class)); } @Test public void testDeactivate() { backend.activate(); backend.deactivate(); verify(executor).shutdown(); assertFalse(backend.isActive()); } }