view keyring/src/main/native/libsecret/LibsecretKeyringLibraryNative.c @ 1825:2ae8438ee9d2

Keyring service might block forever storing passwords on newer distributions Add a libsecret based JNI implementation which is preferred over an libgnome-keyring based one. The JNI build is now autotools based so as to be able to select an implementation at build time. PR2660 Reviewed-by: neugens, omajid Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2015-October/016616.html Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2015-October/016640.html
author Severin Gehwolf <sgehwolf@redhat.com>
date Mon, 05 Oct 2015 11:58:01 -0400
parents keyring/src/main/native/GnomeKeyringLibraryNative.c@e255ee1b2f90
children
line wrap: on
line source

/*
 * Copyright 2012-2015 Red Hat, Inc.
 *
 * This file is part of Thermostat.
 *
 * Thermostat is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published
 * by the Free Software Foundation; either version 2, or (at your
 * option) any later version.
 *
 * Thermostat is distributed in the hope that it will be useful, but
 * WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with Thermostat; see the file COPYING.  If not see
 * <http://www.gnu.org/licenses/>.
 *
 * Linking this code with other modules is making a combined work
 * based on this code.  Thus, the terms and conditions of the GNU
 * General Public License cover the whole combination.
 *
 * As a special exception, the copyright holders of this code give
 * you permission to link this code with independent modules to
 * produce an executable, regardless of the license terms of these
 * independent modules, and to copy and distribute the resulting
 * executable under terms of your choice, provided that you also
 * meet, for each linked independent module, the terms and conditions
 * of the license of that module.  An independent module is a module
 * which is not derived from or based on this code.  If you modify
 * this code, you may extend this exception to your version of the
 * library, but you are not obligated to do so.  If you do not wish
 * to do so, delete this exception statement from your version.
 */

#include "com_redhat_thermostat_utils_keyring_impl_KeyringImpl.h"

#include <jni.h>
#include <glib.h>
#include <libsecret/secret.h>
#include <stdlib.h>
#include <string.h>

SecretSchema thermostat_schema = {
        "com.redhat.thermostat.password", SECRET_SCHEMA_NONE,
        {
            { "username", SECRET_SCHEMA_ATTRIBUTE_STRING },
            { "url", SECRET_SCHEMA_ATTRIBUTE_STRING },
            { "NULL", 0 }
        }
    };

static void init(void) {
    if (g_get_application_name() == NULL) {
        g_set_application_name("Thermostat");
    }
}

JNIEXPORT jboolean JNICALL
Java_com_redhat_thermostat_utils_keyring_impl_KeyringImpl_gnomeKeyringWrapperSavePasswordNative
  (JNIEnv *env, jclass GnomeKeyringLibraryNativeClass, jstring jurl, jstring juserName, jbyteArray jpassword, jstring jdescription)
{
    int passIndex;
    const char *url = (*env)->GetStringUTFChars(env, jurl, NULL);
    if (url == NULL) {
        return JNI_FALSE;
    }
    const char *userName = (*env)->GetStringUTFChars(env, juserName, NULL);
    if (userName == NULL) {
        (*env)->ReleaseStringUTFChars(env, jurl, url);
        return JNI_FALSE;
    }

    jsize passwordLength = (*env)->GetArrayLength(env, jpassword);
    jbyte *password = (*env)->GetByteArrayElements(env, jpassword, NULL);
    if (password == NULL) {
        (*env)->ReleaseStringUTFChars(env, jurl, url);
        (*env)->ReleaseStringUTFChars(env, juserName, userName);
        return JNI_FALSE;
    }

    /* Make into null terminated (g)char * to make gnome api happy */
    gchar *gpassword = malloc(sizeof(gchar) * (passwordLength + 1));
    if (gpassword == NULL) {
        (*env)->ReleaseStringUTFChars(env, jurl, url);
        (*env)->ReleaseStringUTFChars(env, juserName, userName);
        for (passIndex = 0; passIndex < (int) passwordLength; passIndex++) {
            password[passIndex] = '\0';
        }
        (*env)->ReleaseByteArrayElements(env, jpassword, password, JNI_ABORT);
        return JNI_FALSE;
    }
    for (passIndex = 0; passIndex < passwordLength; passIndex++) {
        gpassword[passIndex] = (gchar) (password[passIndex]);
    }
    gpassword[passwordLength] = (gchar) '\0';

    /* Overwrite original array, release back to java-land. */
    for (passIndex = 0; passIndex < (int) passwordLength; passIndex++) {
        password[passIndex] = '\0';
    }
    (*env)->ReleaseByteArrayElements(env, jpassword, password, JNI_ABORT);

    const char *description = (*env)->GetStringUTFChars(env, jdescription, NULL);
    if (description == NULL) {
        (*env)->ReleaseStringUTFChars(env, jurl, url);
        (*env)->ReleaseStringUTFChars(env, juserName, userName);
        for (passIndex = 0; passIndex < (int) passwordLength; passIndex++) {
            gpassword[passIndex] = (gchar) '\0';
        }
        free(gpassword);
        return JNI_FALSE;
    }

    init();
    GError *error = NULL;
    jboolean is_success = JNI_TRUE;
    secret_password_store_sync(&thermostat_schema,
                               SECRET_COLLECTION_DEFAULT,
                               description,
                               gpassword,
                               NULL,
                               &error,
                               "username", userName,
                               "url", url,
                               NULL);
    if (error != NULL) {
        is_success = JNI_FALSE;
        g_error_free (error);
    }
    (*env)->ReleaseStringUTFChars(env, jurl, url);
    (*env)->ReleaseStringUTFChars(env, juserName, userName);
    for (passIndex = 0; passIndex < (int) passwordLength; passIndex++) {
        gpassword[passIndex] = '\0';
    }
    free(gpassword);
    (*env)->ReleaseStringUTFChars(env, jdescription, description);

    return is_success;
}

JNIEXPORT jbyteArray JNICALL
Java_com_redhat_thermostat_utils_keyring_impl_KeyringImpl_gnomeKeyringWrapperGetPasswordNative
  (JNIEnv *env, jclass GnomeKeyringLibraryNative, jstring jurl, jstring juserName)
{
    const char *url = (*env)->GetStringUTFChars(env, jurl, NULL);
    if (url == NULL) {
        return NULL;
    }

    const char *userName = (*env)->GetStringUTFChars(env, juserName, NULL);
    if (userName == NULL) {
        (*env)->ReleaseStringUTFChars(env, jurl, url);
        return NULL;
    }

    gchar *password = NULL;
    GError *error = NULL;

    init();
    password = secret_password_lookup_sync(&thermostat_schema,
                                           NULL,
                                           &error,
                                           "username", userName,
                                           "url", url,
                                           NULL);

    (*env)->ReleaseStringUTFChars(env, jurl, url);
    (*env)->ReleaseStringUTFChars(env, juserName, userName);

    if (error == NULL) {
        // Password may be null if not found in secret store
        if (password == NULL) {
            return NULL;
        }
        const jbyte *jbytePassword = (const jbyte *) password;

        jsize passwordLength = strlen(password);
        jbyteArray jpassword = (*env)->NewByteArray(env, passwordLength);
        (*env)->SetByteArrayRegion(env, jpassword, 0, passwordLength, jbytePassword);
        secret_password_free(password);
        return jpassword;
    } else {
        g_error_free(error);
        return NULL;
    }
}

JNIEXPORT jboolean JNICALL
Java_com_redhat_thermostat_utils_keyring_impl_KeyringImpl_gnomeKeyringWrapperClearPasswordNative
  (JNIEnv *env, jclass GnomeKeyringLibraryNative, jstring jurl, jstring juserName)
{
    const char *url = (*env)->GetStringUTFChars(env, jurl, NULL);
    if (url == NULL) {
        return JNI_FALSE;
    }
    const char *userName = (*env)->GetStringUTFChars(env, juserName, NULL);
    if (userName == NULL) {
        (*env)->ReleaseStringUTFChars(env, jurl, url);
        return JNI_FALSE;
    }

    init();
    GError *error = NULL;
    jboolean is_success = JNI_TRUE;
    secret_password_clear_sync(&thermostat_schema,
                               NULL,
                               &error,
                               "username", userName,
                               "url", url,
                               NULL);

    if (error != NULL) {
        is_success = JNI_FALSE;
        g_error_free (error);
    }
    (*env)->ReleaseStringUTFChars(env, jurl, url);
    (*env)->ReleaseStringUTFChars(env, juserName, userName);

    return is_success;
}