view agent/core/src/main/java/com/redhat/thermostat/utils/management/internal/MXBeanConnector.java @ 1415:adb678c592f5

Remove RMI-based agent-proxy mechanism. It was discovered that, in certain configurations, the Thermostat agent disclosed JMX management URLs of all local Java virtual machines to any local user. A local, unprivileged user could use this flaw to escalate their privileges on the system. (CVE-2014-8120) More information will be available at: http://cve.mitre.org/cgi-bin/cvename.gci?name=CVE=2014-8120
author Elliott Baron <ebaron@redhat.com>
date Tue, 16 Dec 2014 11:54:58 -0700
parents a0592d702416
children
line wrap: on
line source

/*
 * Copyright 2012-2014 Red Hat, Inc.
 *
 * This file is part of Thermostat.
 *
 * Thermostat is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published
 * by the Free Software Foundation; either version 2, or (at your
 * option) any later version.
 *
 * Thermostat is distributed in the hope that it will be useful, but
 * WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with Thermostat; see the file COPYING.  If not see
 * <http://www.gnu.org/licenses/>.
 *
 * Linking this code with other modules is making a combined work
 * based on this code.  Thus, the terms and conditions of the GNU
 * General Public License cover the whole combination.
 *
 * As a special exception, the copyright holders of this code give
 * you permission to link this code with independent modules to
 * produce an executable, regardless of the license terms of these
 * independent modules, and to copy and distribute the resulting
 * executable under terms of your choice, provided that you also
 * meet, for each linked independent module, the terms and conditions
 * of the license of that module.  An independent module is a module
 * which is not derived from or based on this code.  If you modify
 * this code, you may extend this exception to your version of the
 * library, but you are not obligated to do so.  If you do not wish
 * to do so, delete this exception statement from your version.
 */

package com.redhat.thermostat.utils.management.internal;

import java.io.File;
import java.io.IOException;

import javax.management.MBeanServerConnection;
import javax.management.remote.JMXConnector;
import javax.management.remote.JMXConnectorFactory;
import javax.management.remote.JMXServiceURL;

import com.redhat.thermostat.common.tools.ApplicationException;

class MXBeanConnector {
    
    private final JMXConnectionCreator jmxCreator;
    private final String serviceURL;
    
    public MXBeanConnector(int pid, String user, File binPath) throws IOException, ApplicationException {
        this(new AgentProxyClient(pid, user, binPath), new JMXConnectionCreator());
    }
    
    MXBeanConnector(AgentProxyClient client, JMXConnectionCreator jmxCreator) throws IOException, ApplicationException {
        this.jmxCreator = jmxCreator;
        this.serviceURL = client.getJMXServiceURL();
    }
    
    public synchronized MXBeanConnectionImpl connect() throws IOException {
        JMXServiceURL url = new JMXServiceURL(serviceURL);
        JMXConnector connection = jmxCreator.create(url);
        MBeanServerConnection mbsc = null;
        try {
            mbsc = connection.getMBeanServerConnection();
            
        } catch (IOException e) {
            connection.close();
            throw e;
        }
        
        return new MXBeanConnectionImpl(connection, mbsc);
    }
    
    static class JMXConnectionCreator {
        JMXConnector create(JMXServiceURL url) throws IOException {
            return JMXConnectorFactory.connect(url);
        }
    }
}