view agent/core/src/test/java/com/redhat/thermostat/backend/VmListenerBackendTest.java @ 1032:b269be10beb4

Wrap sun.jvmstat class usage Omair had pointed out that the VmListenerBackend exposes sun.jvmstat classes as API. These classes are subject to change and are not part of the Java specification. This commit resolves this issue by wrapping Thermostat's usage of these classes in a new set of API classes. A new VmUpdateListener is used in place of sun.jvmstat.monitor.VmListener. A new internal VmListenerWrapper class maps this class to the underlying VmListener. Performance counters retrieved from s.j.m.MonitoredVm can now be accessed through a new type-safe VmUpdate interface. Finally VmMonitor extracts some of the logic out of VmListenerBackend. With this commit, none of our plugins use any sun.jvmstat classes directly anymore. Reviewed-by: omajid Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2013-March/006072.html
author Elliott Baron <ebaron@redhat.com>
date Fri, 15 Mar 2013 14:01:22 -0400
parents cf7a445c359b
children
line wrap: on
line source

/*
 * Copyright 2012, 2013 Red Hat, Inc.
 *
 * This file is part of Thermostat.
 *
 * Thermostat is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published
 * by the Free Software Foundation; either version 2, or (at your
 * option) any later version.
 *
 * Thermostat is distributed in the hope that it will be useful, but
 * WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with Thermostat; see the file COPYING.  If not see
 * <http://www.gnu.org/licenses/>.
 *
 * Linking this code with other modules is making a combined work
 * based on this code.  Thus, the terms and conditions of the GNU
 * General Public License cover the whole combination.
 *
 * As a special exception, the copyright holders of this code give
 * you permission to link this code with independent modules to
 * produce an executable, regardless of the license terms of these
 * independent modules, and to copy and distribute the resulting
 * executable under terms of your choice, provided that you also
 * meet, for each linked independent module, the terms and conditions
 * of the license of that module.  An independent module is a module
 * which is not derived from or based on this code.  If you modify
 * this code, you may extend this exception to your version of the
 * library, but you are not obligated to do so.  If you do not wish
 * to do so, delete this exception statement from your version.
 */

package com.redhat.thermostat.backend;

import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.mockito.Matchers.same;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;

import java.net.URISyntaxException;

import org.junit.Before;
import org.junit.Test;

import sun.jvmstat.monitor.MonitorException;

import com.redhat.thermostat.agent.VmStatusListener.Status;
import com.redhat.thermostat.agent.VmStatusListenerRegistrar;
import com.redhat.thermostat.backend.internal.VmMonitor;

public class VmListenerBackendTest {
    
    private VmListenerBackend backend;
    private VmStatusListenerRegistrar registrar;
    private VmMonitor monitor;
    private VmUpdateListener listener;

    @Before
    public void setup() {
        registrar = mock(VmStatusListenerRegistrar.class);
        backend = new TestBackend("Test Backend", "Backend for test", "Test Co.",
                "0.0.0", registrar);
        monitor = mock(VmMonitor.class);
        listener = mock(VmUpdateListener.class);
        backend.setMonitor(monitor);
    }
    
    @Test
    public void testActivate() {
        backend.activate();
        assertTrue(backend.isActive());
        verify(registrar).register(backend);
    }

    @Test
    public void testActivateTwice() {
        assertTrue(backend.activate());
        assertTrue(backend.isActive());

        assertTrue(backend.activate());
        assertTrue(backend.isActive());
    }

    @Test
    public void testCanNotActivateWithoutMonitor() {
        backend.setMonitor(null);

        assertFalse(backend.activate());
        assertFalse(backend.isActive());
    }
    
    @Test
    public void testDeactivate() {
        backend.activate();
        backend.deactivate();
        verify(registrar).unregister(backend);
        assertFalse(backend.isActive());
    }

    @Test
    public void testDeactivateTwice() {
        backend.activate();

        assertTrue(backend.deactivate());
        assertFalse(backend.isActive());
        assertTrue(backend.deactivate());
    }
    
    @Test
    public void testNewVM() {
        final int VM_PID = 1;

        // Should be no response if not observing new jvm.
        backend.setObserveNewJvm(false);
        backend.vmStatusChanged(Status.VM_STARTED, VM_PID);
        verify(monitor, times(0)).handleNewVm(same(listener), same(VM_PID));

        backend.setObserveNewJvm(true);
        backend.vmStatusChanged(Status.VM_STARTED, VM_PID);
        verify(monitor).handleNewVm(listener, VM_PID);
    }

    @Test
    public void testAlreadyRunningVM() {
        final int VM_PID = 1;

        backend.setObserveNewJvm(true);
        backend.vmStatusChanged(Status.VM_ACTIVE, VM_PID);

        verify(monitor).handleNewVm(listener, VM_PID);
    }

    @Test
    public void testStoppedVM() throws MonitorException, URISyntaxException {
        final int VM_PID = 1;

        backend.setObserveNewJvm(true);
        backend.vmStatusChanged(Status.VM_STARTED, VM_PID);
        backend.vmStatusChanged(Status.VM_STOPPED, VM_PID);

        verify(monitor).handleStoppedVm(VM_PID);
    }

    @Test
    public void testDeactivateUnregistersListener() throws URISyntaxException, MonitorException {
        final int VM_PID = 1;
        backend.activate();
        
        backend.setObserveNewJvm(true);
        backend.vmStatusChanged(Status.VM_STARTED, VM_PID);
        backend.deactivate();
        verify(monitor).removeVmListeners();
    }
    
    private class TestBackend extends VmListenerBackend {

        public TestBackend(String name, String description, String vendor,
                String version, VmStatusListenerRegistrar registrar) {
            super(name, description, vendor, version, registrar);
        }

        @Override
        public int getOrderValue() {
            return 0;
        }

        @Override
        protected VmUpdateListener createVmListener(int pid) {
            return listener;
        }
        
    }

}