Mercurial > hg > release > thermostat-0.7
view vm-heap-analysis/command/src/main/resources/com/redhat/thermostat/vm/heap/analysis/command/locale/strings.properties @ 1045:3526e4183714
Remove OSGIUtils
This commit removes OSGIUtils. This class duplicated a lot of
functionality from BundleContext, and hides some important details about
OSGi such as where the underlying BundleContext comes from. For
instance, when developing the Eclipse client, at first the common-core
bundle wasn't started. This lead to NPEs in OSGIUtils because it uses
the BundleContext of the common-core bundle and not the bundle of the
calling class or the bundle containing the requested service. Another
problem with OSGIUtils is from several cases in Thermostat where we are
using getService instead of getServiceAllowNull, which throws NPEs if
the requested service is not registered.
Uses of OSGIUtils have been replaced with either a ServiceTracker for
long-running tasks (e.g. GUI), or for shell commands using a
BundleContext and checking the ServiceReference for null and throwing a
meaningful exception.
Reviewed-by: jerboaa, vanaltj, neugens
Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2013-March/006104.html
author | Elliott Baron <ebaron@redhat.com> |
---|---|
date | Fri, 22 Mar 2013 12:01:35 -0400 |
parents | 9f569536d421 |
children |
line wrap: on
line source
HOST_SERVICE_UNAVAILABLE = Unable to access host information (HostInfoDAO unavailable) VM_SERVICE_UNAVAILABLE = Unable to access vm information (VmInfoDAO unavailable) HEAP_SERVICE_UNAVAILABLE = Unable to access heap information (HeapDAO unavailable) AGENT_SERVICE_UNAVAILABLE = Unable to access agent information (AgentInfoDAO unavailable) REQUEST_QUEUE_UNAVAILABLE = Unable to access command channel (RequestQueue unavailable) HEADER_TIMESTAMP = TIMESTAMP HEADER_HOST_ID = HOST ID HEADER_VM_ID = VM ID HEADER_HEAP_ID = HEAP ID HEADER_OBJECT_ID = ID HEADER_OBJECT_TYPE = TYPE FILE_REQUIRED = A file name is required INVALID_LIMIT = Invalid limit {0} HEAP_ID_NOT_FOUND = Heap ID not found: {0} HEAP_ID_REQUIRED = Heap ID required SEARCH_TERM_REQUIRED = A search term is required HEAP_DUMP_ERROR = Error dumping heap (agent: {0}, vm: {1}) COMMAND_HEAP_DUMP_DONE = Done COMMAND_FIND_ROOT_NO_ROOT_FOUND = No root found for: {0} COMMAND_OBJECT_INFO_OBJECT_ID = Object ID: COMMAND_OBJECT_INFO_TYPE = Type: COMMAND_OBJECT_INFO_SIZE = Size: COMMAND_OBJECT_INFO_HEAP_ALLOCATED = Heap allocated: COMMAND_OBJECT_INFO_REFERENCES = References: COMMAND_OBJECT_INFO_REFERRERS = Referrers: COMMAND_SAVE_HEAP_DUMP_SAVED_TO_FILE = Saved heap dump to {0} COMMAND_SAVE_HEAP_DUMP_ERROR_SAVING = error saving heap to file: {0} COMMAND_SAVE_HEAP_DUMP_ERROR_CLOSING_STREAM = error closing heap stream: {0}