Mercurial > hg > release > thermostat-0.7
view client/cli/src/main/resources/com/redhat/thermostat/client/cli/strings.properties @ 1045:3526e4183714
Remove OSGIUtils
This commit removes OSGIUtils. This class duplicated a lot of
functionality from BundleContext, and hides some important details about
OSGi such as where the underlying BundleContext comes from. For
instance, when developing the Eclipse client, at first the common-core
bundle wasn't started. This lead to NPEs in OSGIUtils because it uses
the BundleContext of the common-core bundle and not the bundle of the
calling class or the bundle containing the requested service. Another
problem with OSGIUtils is from several cases in Thermostat where we are
using getService instead of getServiceAllowNull, which throws NPEs if
the requested service is not registered.
Uses of OSGIUtils have been replaced with either a ServiceTracker for
long-running tasks (e.g. GUI), or for shell commands using a
BundleContext and checking the ServiceReference for null and throwing a
meaningful exception.
Reviewed-by: jerboaa, vanaltj, neugens
Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2013-March/006104.html
author | Elliott Baron <ebaron@redhat.com> |
---|---|
date | Fri, 22 Mar 2013 12:01:35 -0400 |
parents | 1e51015e63e5 |
children |
line wrap: on
line source
MISSING_INFO = Missing Information HOST_SERVICE_UNAVAILABLE = Unable to get host information (HostInfoDAO is unavailable) VM_SERVICE_UNAVAILABLE = Unable to get vm information (VmInfoDAO is unavailable) VM_CPU_SERVICE_NOT_AVAILABLE = Unable to access vm cpu information (VmCpuStats not available) VM_MEMORY_SERVICE_NOT_AVAILABLE = Unable to access vm memory information (VmCpuStats not available) COMMAND_CONNECT_ALREADY_CONNECTED = Already connected to storage: URL = {0}\nPlease use disconnect command to disconnect. COMMAND_CONNECT_FAILED_TO_CONNECT = Could not connect to db {0} COMMAND_CONNECT_INVALID_STORAGE = Unrecognized storage URL {0} COMMAND_CONNECT_NO_KEYRING = Unable to retrieve keyring COMMAND_CONNECT_ERROR = Error: {0} COMMAND_DISCONNECT_NOT_CONNECTED = Not connected to storage. You may use the connect command for establishing connections. COMMAND_DISCONNECT_ERROR = Failed to disconnect from database. VM_INFO_PROCESS_ID = Process ID: VM_INFO_START_TIME = Start time: VM_INFO_STOP_TIME = Stop time: VM_INFO_MAIN_CLASS = Main class: VM_INFO_COMMAND_LINE = Command line: VM_INFO_JAVA_VERSION = Java version: VM_INFO_VIRTUAL_MACHINE = Virtual machine: VM_INFO_VM_ARGUMENTS = VM arguments: COLUMN_HEADER_HOST_ID = HOST_ID COLUMN_HEADER_HOST = HOST COLUMN_HEADER_VM_ID = VM_ID COLUMN_HEADER_VM_NAME = VM_NAME COLUMN_HEADER_VM_STATUS = STATUS COLUMN_HEADER_TIME = TIME VM_STOP_TIME_RUNNING = <Running> VM_STATUS_ALIVE = RUNNING VM_STATUS_DEAD = EXITED