Mercurial > hg > release > thermostat-0.7
view agent/cli/src/main/resources/com/redhat/thermostat/agent/cli/impl/strings.properties @ 1045:3526e4183714
Remove OSGIUtils
This commit removes OSGIUtils. This class duplicated a lot of
functionality from BundleContext, and hides some important details about
OSGi such as where the underlying BundleContext comes from. For
instance, when developing the Eclipse client, at first the common-core
bundle wasn't started. This lead to NPEs in OSGIUtils because it uses
the BundleContext of the common-core bundle and not the bundle of the
calling class or the bundle containing the requested service. Another
problem with OSGIUtils is from several cases in Thermostat where we are
using getService instead of getServiceAllowNull, which throws NPEs if
the requested service is not registered.
Uses of OSGIUtils have been replaced with either a ServiceTracker for
long-running tasks (e.g. GUI), or for shell commands using a
BundleContext and checking the ServiceReference for null and throwing a
meaningful exception.
Reviewed-by: jerboaa, vanaltj, neugens
Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2013-March/006104.html
| author | Elliott Baron <ebaron@redhat.com> |
|---|---|
| date | Fri, 22 Mar 2013 12:01:35 -0400 |
| parents | 5a2d3c43b551 |
| children |
line wrap: on
line source
STARTING_AGENT = starting agent now... COMMAND_STORAGE_ARGUMENT_REQUIRED = either --start or --stop must be given ERROR_STARTING_DB = error starting db STORAGE_ALREADY_RUNNING = Storage is already running. Please use "agent --start" to start the agent STORAGE_ALREADY_RUNNING_WITH_PID = Storage is already running with pid {0} SERVER_SHUTDOWN_COMPLETE = server shutdown complete: {0} LOG_FILE_AT = log file is here: {0} CANNOT_START_SERVER = cannot start server {0}, exit status: {1}. Please check that your configuration is valid CANNOT_SHUTDOWN_SERVER = cannot shutdown server {0}, exit status: {1}. Please check that your configuration is valid STALE_PID_FILE = stale pid file: {0} STALE_PID_FILE_NO_MATCHING_PROCESS = A stale pid file ({0}) is present but there is no matching {1} process. Removing stale pid file. STARTING_STORAGE_SERVER = starting storage server... CANNOT_EXECUTE_PROCESS = can not execute {0} process. is it installed? SERVER_LISTENING_ON = server listening on ip: {0} PID_IS = pid: {0} LAUNCHER_UNAVAILABLE = Launcher is not available