Mercurial > hg > release > thermostat-0.6
changeset 957:1a1c6524e05b
Add cautionary comment about necessary order of adding command options.
| author | Jon VanAlten <jon.vanalten@redhat.com> |
|---|---|
| date | Thu, 07 Feb 2013 14:20:59 -0500 |
| parents | 539c0e95b660 |
| children | 66f3c55d7692 |
| files | launcher/src/main/java/com/redhat/thermostat/launcher/internal/BuiltInCommandInfo.java |
| diffstat | 1 files changed, 11 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/launcher/src/main/java/com/redhat/thermostat/launcher/internal/BuiltInCommandInfo.java Wed Feb 06 16:17:02 2013 -0500 +++ b/launcher/src/main/java/com/redhat/thermostat/launcher/internal/BuiltInCommandInfo.java Thu Feb 07 14:20:59 2013 -0500 @@ -115,6 +115,17 @@ boolean addLogOption = false; for (String optionString : optionNames) { + /* + * The automatic options are not added until the end. This ordering + * is part of a not-entirely-clear solution that accomplishes: + * a) Preventing conflicts between options. + * b) Still allowing the "required" property of these DB and LOG + * options to be overridden. + * + * Change this order at your peril. + * + * See also http://icedtea.classpath.org/pipermail/thermostat/2013-February/005503.html + */ if (optionString.equals(CommonOptions.OPTIONS_COMMON_DB_OPTIONS)) { addDbOptions = true; continue;