view storage/core/src/main/java/com/redhat/thermostat/storage/core/Storage.java @ 946:b5693fd9f6b8

Keep WebConnection instance I have come across this issue while working on the DAOFactory removal patch. The problem was the Reconnect dialog wasn't appearing when the GUI couldn't connect to storage. The cause is that WebStorage.getConnection returns a new instance of WebConnection each time it is called. Thus if one method calls storage.getConnection().addListener() and then another method calls storage.getConnection().connect(), the listener is no longer attached. This simple commit changes WebStorage to instantiate a WebConnection in its constructor and always return this instance in getConnection. Reviewed-by: omajid Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2013-January/005318.html
author Elliott Baron <ebaron@redhat.com>
date Thu, 31 Jan 2013 14:37:55 -0500
parents ccac9bcabaa0
children
line wrap: on
line source

/*
 * Copyright 2012, 2013 Red Hat, Inc.
 *
 * This file is part of Thermostat.
 *
 * Thermostat is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published
 * by the Free Software Foundation; either version 2, or (at your
 * option) any later version.
 *
 * Thermostat is distributed in the hope that it will be useful, but
 * WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with Thermostat; see the file COPYING.  If not see
 * <http://www.gnu.org/licenses/>.
 *
 * Linking this code with other modules is making a combined work
 * based on this code.  Thus, the terms and conditions of the GNU
 * General Public License cover the whole combination.
 *
 * As a special exception, the copyright holders of this code give
 * you permission to link this code with independent modules to
 * produce an executable, regardless of the license terms of these
 * independent modules, and to copy and distribute the resulting
 * executable under terms of your choice, provided that you also
 * meet, for each linked independent module, the terms and conditions
 * of the license of that module.  An independent module is a module
 * which is not derived from or based on this code.  If you modify
 * this code, you may extend this exception to your version of the
 * library, but you are not obligated to do so.  If you do not wish
 * to do so, delete this exception statement from your version.
 */

package com.redhat.thermostat.storage.core;

import java.io.InputStream;
import java.util.UUID;

import com.redhat.thermostat.annotations.Service;
import com.redhat.thermostat.storage.model.Pojo;

/**
 * A storage can be used to store, query, update and remove data.
 * Implementations may use memory, a file, some database or even a network
 * server as the backing store.
 */
@Service
public interface Storage {

    void setAgentId(UUID id);

    String getAgentId();

    void registerCategory(Category<?> category);

    /**
     * Returns the Connection object that may be used to manage connections
     * to this Storage. Subsequent calls to this method should return
     * the same Connection.
     * @return the Connection for this Storage
     */
    Connection getConnection();

    Add createAdd(Category<?> category);
    Replace createReplace(Category<?> category);

    void removePojo(Remove remove);

    /**
     * Drop all data related to the currently running agent.
     */
    void purge();

    long getCount(Category<?> category);

    void saveFile(String filename, InputStream data);

    InputStream loadFile(String filename);

    <T extends Pojo> Query<T> createQuery(Category<T> category);

    Update createUpdate(Category<?> category);
    Remove createRemove();


    void shutdown();

}