Mercurial > hg > release > thermostat-0.4
view client/heapdumper/src/main/java/com/redhat/thermostat/client/heap/swing/HeapSwingView.java @ 656:3befd8ddad2f
Fix UI hangs caused by Memory Analyzer chart
Certain operations in the "Memory Analyzer" tab can cause the entire GUI
to free and the client application to hang.
This behaviour can be seen if you leave thermostat (agent and client)
running for a little while looking at a large java application (I used
eclipse in my tests) and trigger heap dumps occasionally. It takes about
10 minutes for this bug to become fully visible.
I noticed that the memory chart (that displays used/free memory) is
recreated in HeapSwingView whenever HeapDumpController fetches some new
data from storage. This creation also causes a clone of the TimeSeries
objects containing the _entire_ dataset for the target application. A
JFreeChart object is constructed from this but then thrown away after
being used once. All this is done on the EDT too, which completely
freezes the GUI. The client can only be killed by using kill -9 at this
point.
This commit changes the ChartPanel from a c.r.t.swing.ChartPanel to a
org.jfree.chart.ChartPanel which automatically redraws itself whenever
the underlying model changes. It also connects the ChartPanel directly
to the model used by the controller so values are automatically updated
in the chart without additional copying of memory.
It is still possible to for the client to run out of memory and trigger
OutOfMemoryError when triggering heap dumps, but at least the UI stays
responsive enough and can be killed using ctrl-c on the console.
Reviewed-by: jerboaa, neugens, vanaltj
Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2012-October/003585.html
author | Omair Majid <omajid@redhat.com> |
---|---|
date | Thu, 04 Oct 2012 17:35:18 -0400 |
parents | 6a179175bb1b |
children |
line wrap: on
line source
/* * Copyright 2012 Red Hat, Inc. * * This file is part of Thermostat. * * Thermostat is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published * by the Free Software Foundation; either version 2, or (at your * option) any later version. * * Thermostat is distributed in the hope that it will be useful, but * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. * * You should have received a copy of the GNU General Public License * along with Thermostat; see the file COPYING. If not see * <http://www.gnu.org/licenses/>. * * Linking this code with other modules is making a combined work * based on this code. Thus, the terms and conditions of the GNU * General Public License cover the whole combination. * * As a special exception, the copyright holders of this code give * you permission to link this code with independent modules to * produce an executable, regardless of the license terms of these * independent modules, and to copy and distribute the resulting * executable under terms of your choice, provided that you also * meet, for each linked independent module, the terms and conditions * of the license of that module. An independent module is a module * which is not derived from or based on this code. If you modify * this code, you may extend this exception to your version of the * library, but you are not obligated to do so. If you do not wish * to do so, delete this exception statement from your version. */ package com.redhat.thermostat.client.heap.swing; import java.awt.Component; import java.awt.EventQueue; import java.awt.event.ActionEvent; import java.awt.event.ActionListener; import java.util.List; import javax.swing.BoxLayout; import javax.swing.JPanel; import javax.swing.SwingUtilities; import javax.swing.event.ListSelectionEvent; import javax.swing.event.ListSelectionListener; import org.jfree.chart.ChartPanel; import com.redhat.thermostat.client.heap.HeapView; import com.redhat.thermostat.client.heap.LocaleResources; import com.redhat.thermostat.client.heap.Translate; import com.redhat.thermostat.client.heap.chart.OverviewChart; import com.redhat.thermostat.client.osgi.service.BasicView; import com.redhat.thermostat.client.ui.ComponentVisibleListener; import com.redhat.thermostat.client.ui.SwingComponent; import com.redhat.thermostat.common.heap.HeapDump; import com.redhat.thermostat.swing.HeaderPanel; public class HeapSwingView extends HeapView implements SwingComponent { private StatsPanel stats; private HeapPanel heapDetailPanel; private HeaderPanel overview; private JPanel visiblePane; public HeapSwingView() { stats = new StatsPanel(); stats.addHeapDumperListener(new ActionListener() { @Override public void actionPerformed(ActionEvent e) { stats.disableHeapDumperControl(); heapDumperNotifier.fireAction(HeapDumperAction.DUMP_REQUESTED); } }); stats.addDumpListListener(new ListSelectionListener() { @Override public void valueChanged(ListSelectionEvent arg0) { HeapDump dump = stats.getSelectedHeapDump(); heapDumperNotifier.fireAction(HeapDumperAction.ANALYSE, dump); } }); visiblePane = new JPanel(); visiblePane.setLayout(new BoxLayout(visiblePane, BoxLayout.X_AXIS)); heapDetailPanel = new HeapPanel(); overview = new HeaderPanel(Translate.localize(LocaleResources.HEAP_OVERVIEW_TITLE)); overview.setContent(stats); overview.addHierarchyListener(new ViewVisibleListener()); // at the beginning, only the overview is visible visiblePane.add(overview); } private class ViewVisibleListener extends ComponentVisibleListener { @Override public void componentShown(Component component) { HeapSwingView.this.notify(Action.VISIBLE); } @Override public void componentHidden(Component component) { HeapSwingView.this.notify(Action.HIDDEN); } } @Override public void setModel(final OverviewChart model) { SwingUtilities.invokeLater(new Runnable() { @Override public void run() { ChartPanel charts = new ChartPanel(model.createChart(stats.getWidth(), stats.getBackground())); /* * By default, ChartPanel scales itself instead of redrawing things when * it's resized. To have it resize automatically, we need to set minimum * and maximum sizes. Lets constrain the minimum, but not the maximum * size. */ final int MINIMUM_DRAW_SIZE = 100; charts.setMinimumDrawHeight(MINIMUM_DRAW_SIZE); charts.setMinimumDrawWidth(MINIMUM_DRAW_SIZE); charts.setMaximumDrawHeight(Integer.MAX_VALUE); charts.setMaximumDrawWidth(Integer.MAX_VALUE); stats.setChartPanel(charts); } }); } @Override public void updateUsedAndCapacity(final String used, final String capacity) { SwingUtilities.invokeLater(new Runnable() { @Override public void run() { stats.setMax(capacity); stats.setUsed(used); } }); } @Override public void addHeapDump(final HeapDump dump) { SwingUtilities.invokeLater(new Runnable() { @Override public void run() { stats.addDump(dump); } }); } @Override public void clearHeapDumpList() { SwingUtilities.invokeLater(new Runnable() { @Override public void run() { stats.clearDumpList(); } }); } @Override public void openDumpView() { SwingUtilities.invokeLater(new Runnable() { @Override public void run() { visiblePane.removeAll(); heapDetailPanel.divideView(); heapDetailPanel.setTop(overview); visiblePane.add(heapDetailPanel); visiblePane.revalidate(); } }); } @Override public void setChildView(BasicView childView) { if (childView instanceof HeapDetailsSwing) { final HeapDetailsSwing view = (HeapDetailsSwing)childView; SwingUtilities.invokeLater(new Runnable() { @Override public void run() { heapDetailPanel.setBottom(view.getUiComponent()); visiblePane.revalidate(); } }); } } @Override public Component getUiComponent() { return visiblePane; } @Override public void notifyHeapDumpComplete() { EventQueue.invokeLater(new Runnable() { @Override public void run() { stats.enableHeapDumperControl(); } }); } @Override public void updateHeapDumpList(final List<HeapDump> heapDumps) { EventQueue.invokeLater(new Runnable() { @Override public void run() { stats.updateHeapDumpList(heapDumps); } }); } }