Mercurial > hg > release > thermostat-0.15
view vm-memory/common/src/main/java/com/redhat/thermostat/vm/memory/common/internal/VmMemoryStatDAOImpl.java @ 1265:0e0e2b6041ad
Refactor DAOs so as to use prepared writes over direct write operations.
Reviewed-by: omajid
Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2013-September/008296.html
author | Severin Gehwolf <sgehwolf@redhat.com> |
---|---|
date | Mon, 16 Sep 2013 15:28:13 +0200 |
parents | cd020319d8ed |
children |
line wrap: on
line source
/* * Copyright 2012, 2013 Red Hat, Inc. * * This file is part of Thermostat. * * Thermostat is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published * by the Free Software Foundation; either version 2, or (at your * option) any later version. * * Thermostat is distributed in the hope that it will be useful, but * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. * * You should have received a copy of the GNU General Public License * along with Thermostat; see the file COPYING. If not see * <http://www.gnu.org/licenses/>. * * Linking this code with other modules is making a combined work * based on this code. Thus, the terms and conditions of the GNU * General Public License cover the whole combination. * * As a special exception, the copyright holders of this code give * you permission to link this code with independent modules to * produce an executable, regardless of the license terms of these * independent modules, and to copy and distribute the resulting * executable under terms of your choice, provided that you also * meet, for each linked independent module, the terms and conditions * of the license of that module. An independent module is a module * which is not derived from or based on this code. If you modify * this code, you may extend this exception to your version of the * library, but you are not obligated to do so. If you do not wish * to do so, delete this exception statement from your version. */ package com.redhat.thermostat.vm.memory.common.internal; import java.util.List; import java.util.logging.Level; import java.util.logging.Logger; import com.redhat.thermostat.common.utils.LoggingUtils; import com.redhat.thermostat.storage.core.Cursor; import com.redhat.thermostat.storage.core.DescriptorParsingException; import com.redhat.thermostat.storage.core.Key; import com.redhat.thermostat.storage.core.PreparedStatement; import com.redhat.thermostat.storage.core.StatementDescriptor; import com.redhat.thermostat.storage.core.StatementExecutionException; import com.redhat.thermostat.storage.core.Storage; import com.redhat.thermostat.storage.core.VmLatestPojoListGetter; import com.redhat.thermostat.storage.core.VmRef; import com.redhat.thermostat.vm.memory.common.VmMemoryStatDAO; import com.redhat.thermostat.vm.memory.common.model.VmMemoryStat; class VmMemoryStatDAOImpl implements VmMemoryStatDAO { private static final Logger logger = LoggingUtils.getLogger(VmMemoryStatDAOImpl.class); static final String QUERY_LATEST = "QUERY " + vmMemoryStatsCategory.getName() + " WHERE '" + Key.AGENT_ID.getName() + "' = ?s AND '" + Key.VM_ID.getName() + "' = ?s SORT '" + Key.TIMESTAMP.getName() + "' DSC LIMIT 1"; // ADD vm-memory-stats SET 'agentId' = ?s , \ // 'vmId' = ?s , \ // 'timeStamp' = ?s , \ // 'generations' = ?p[ static final String DESC_ADD_VM_MEMORY_STAT = "ADD " + vmMemoryStatsCategory.getName() + " SET '" + Key.AGENT_ID.getName() + "' = ?s , " + "'" + Key.VM_ID.getName() + "' = ?s , " + "'" + Key.TIMESTAMP.getName() + "' = ?l , " + "'" + generationsKey.getName() + "' = ?p["; private final Storage storage; private final VmLatestPojoListGetter<VmMemoryStat> getter; VmMemoryStatDAOImpl(Storage storage) { this.storage = storage; storage.registerCategory(vmMemoryStatsCategory); getter = new VmLatestPojoListGetter<>(storage, vmMemoryStatsCategory); } @Override public VmMemoryStat getLatestMemoryStat(VmRef ref) { StatementDescriptor<VmMemoryStat> desc = new StatementDescriptor<>(vmMemoryStatsCategory, QUERY_LATEST); PreparedStatement<VmMemoryStat> stmt; Cursor<VmMemoryStat> cursor; try { stmt = storage.prepareStatement(desc); stmt.setString(0, ref.getHostRef().getAgentId()); stmt.setString(1, ref.getVmId()); cursor = stmt.executeQuery(); } catch (DescriptorParsingException e) { // should not happen, but if it *does* happen, at least log it logger.log(Level.SEVERE, "Preparing query '" + desc + "' failed!", e); return null; } catch (StatementExecutionException e) { // should not happen, but if it *does* happen, at least log it logger.log(Level.SEVERE, "Executing query '" + desc + "' failed!", e); return null; } VmMemoryStat result = null; if (cursor.hasNext()) { result = cursor.next(); } return result; } @Override public void putVmMemoryStat(VmMemoryStat stat) { StatementDescriptor<VmMemoryStat> desc = new StatementDescriptor<>(vmMemoryStatsCategory, DESC_ADD_VM_MEMORY_STAT); PreparedStatement<VmMemoryStat> prepared; try { prepared = storage.prepareStatement(desc); prepared.setString(0, stat.getAgentId()); prepared.setString(1, stat.getVmId()); prepared.setLong(2, stat.getTimeStamp()); prepared.setPojoList(3, stat.getGenerations()); prepared.execute(); } catch (DescriptorParsingException e) { logger.log(Level.SEVERE, "Preparing stmt '" + desc + "' failed!", e); } catch (StatementExecutionException e) { logger.log(Level.SEVERE, "Executing stmt '" + desc + "' failed!", e); } } @Override public List<VmMemoryStat> getLatestVmMemoryStats(VmRef ref, long since) { return getter.getLatest(ref, since); } }