Mercurial > hg > release > thermostat-0.13
view thread/collector/src/main/java/com/redhat/thermostat/thread/model/ThreadInfoData.java @ 1176:f7961cf1e440
Convert VM IDs to UUIDs
This commit changes VM IDs used in VmRef and VmInfo to a randomly
generated UUID string. The VM PIDs are still stored, but are not used to
identify a specific VM. The motivation behind this change is that PIDs
can be reused by the OS, thus there is a chance we could have a PID that
refers to two different VMs (one alive, one dead). There are then
security implications if we return the wrong VM, which the client user
may not have access to. The VM's PID is still required when dealing with
external interfaces like /proc and JMX, but the data collected is placed
in storage using the VM's UUID.
Additionally, I have cleaned up the API in VmRef. I have removed
getIdString from VmRef since we already have a getStringID that does the
same thing. I've also changed VmRef.getAgent to getHostRef to more
accurately reflect what is returned.
Reviewed-by: jerboaa
Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2013-July/007242.html
author | Elliott Baron <ebaron@redhat.com> |
---|---|
date | Thu, 18 Jul 2013 18:33:49 -0400 |
parents | ccac9bcabaa0 |
children |
line wrap: on
line source
/* * Copyright 2012, 2013 Red Hat, Inc. * * This file is part of Thermostat. * * Thermostat is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published * by the Free Software Foundation; either version 2, or (at your * option) any later version. * * Thermostat is distributed in the hope that it will be useful, but * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. * * You should have received a copy of the GNU General Public License * along with Thermostat; see the file COPYING. If not see * <http://www.gnu.org/licenses/>. * * Linking this code with other modules is making a combined work * based on this code. Thus, the terms and conditions of the GNU * General Public License cover the whole combination. * * As a special exception, the copyright holders of this code give * you permission to link this code with independent modules to * produce an executable, regardless of the license terms of these * independent modules, and to copy and distribute the resulting * executable under terms of your choice, provided that you also * meet, for each linked independent module, the terms and conditions * of the license of that module. An independent module is a module * which is not derived from or based on this code. If you modify * this code, you may extend this exception to your version of the * library, but you are not obligated to do so. If you do not wish * to do so, delete this exception statement from your version. */ package com.redhat.thermostat.thread.model; import java.lang.Thread.State; import java.util.Arrays; import com.redhat.thermostat.storage.core.Entity; import com.redhat.thermostat.storage.core.Persist; import com.redhat.thermostat.storage.model.BasePojo; import com.redhat.thermostat.storage.model.TimeStampedPojo; @Entity public class ThreadInfoData extends BasePojo implements TimeStampedPojo { private String vmId; private StackTraceElement[] stackTrace; private long threadID; private State threadState; private String name; private long allocatedBytes; private long threadCpuTime; private long threadUserTime; private long blockedCount; private long waitedCount; private long timestamp; public void setStackTrace(StackTraceElement[] stackTrace) { this.stackTrace = stackTrace; } public StackTraceElement[] getStackTrace() { return stackTrace; } @Override public String toString() { return "ThreadMXInfo [name=" + name + ", threadID=" + threadID + ", threadState=" + threadState + ", stackTrace=" + Arrays.toString(stackTrace) + ", allocatedBytes=" + allocatedBytes + ", threadCpuTime=" + threadCpuTime + ", threadUserTime=" + threadUserTime + ", blockedCount=" + blockedCount + ", waitedCount=" + waitedCount + ", timestamp=" + timestamp + "]"; } @Persist public void setVmId(String vmId) { this.vmId = vmId; } @Persist public String getVmId() { return vmId; } @Persist public void setThreadName(String threadName) { this.name = threadName; } @Persist public void setThreadId(long threadID) { this.threadID = threadID; } public void setState(State threadState) { this.threadState = threadState; } @Persist public void setThreadState(String threadStateString) { this.threadState = Thread.State.valueOf(threadStateString); } @Persist public void setAllocatedBytes(long allocatedBytes) { this.allocatedBytes = allocatedBytes; } @Persist public String getThreadName() { return name; } @Persist public long getAllocatedBytes() { return allocatedBytes; } @Persist public long getThreadId() { return threadID; } public State getState() { return threadState; } @Persist public String getThreadState() { return threadState.name(); } @Persist public long getTimeStamp() { return timestamp; } @Persist public void setTimeStamp(long timestamp) { this.timestamp = timestamp; } @Persist public void setThreadCpuTime(long threadCpuTime) { this.threadCpuTime = threadCpuTime; } @Persist public void setThreadUserTime(long threadUserTime) { this.threadUserTime = threadUserTime; } @Persist public void setThreadBlockedCount(long blockedCount) { this.blockedCount = blockedCount; } @Persist public void setThreadWaitCount(long waitedCount) { this.waitedCount = waitedCount; } @Persist public long getThreadBlockedCount() { return blockedCount; } @Persist public long getThreadWaitCount() { return waitedCount; } @Persist public long getThreadCpuTime() { return threadCpuTime; } @Persist public long getThreadUserTime() { return threadUserTime; } public int hashCode() { final int prime = 31; int result = 1; result = prime * result + ((name == null) ? 0 : name.hashCode()); result = prime * result + (int) (threadID ^ (threadID >>> 32)); return result; } @Override public boolean equals(Object obj) { if (this == obj) return true; if (obj == null) return false; if (getClass() != obj.getClass()) return false; ThreadInfoData other = (ThreadInfoData) obj; if (name == null) { if (other.name != null) return false; } else if (!name.equals(other.name)) return false; if (threadID != other.threadID) return false; return true; } }