Mercurial > hg > release > thermostat-0.13
view client/cli/src/main/resources/com/redhat/thermostat/client/cli/strings.properties @ 1176:f7961cf1e440
Convert VM IDs to UUIDs
This commit changes VM IDs used in VmRef and VmInfo to a randomly
generated UUID string. The VM PIDs are still stored, but are not used to
identify a specific VM. The motivation behind this change is that PIDs
can be reused by the OS, thus there is a chance we could have a PID that
refers to two different VMs (one alive, one dead). There are then
security implications if we return the wrong VM, which the client user
may not have access to. The VM's PID is still required when dealing with
external interfaces like /proc and JMX, but the data collected is placed
in storage using the VM's UUID.
Additionally, I have cleaned up the API in VmRef. I have removed
getIdString from VmRef since we already have a getStringID that does the
same thing. I've also changed VmRef.getAgent to getHostRef to more
accurately reflect what is returned.
Reviewed-by: jerboaa
Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2013-July/007242.html
author | Elliott Baron <ebaron@redhat.com> |
---|---|
date | Thu, 18 Jul 2013 18:33:49 -0400 |
parents | 8757e35030f2 |
children | 40e2c7a18bda |
line wrap: on
line source
MISSING_INFO = Missing Information MISSING_LAUNCHER = Fatal Error: Could not locate launcher HOST_SERVICE_UNAVAILABLE = Unable to get host information (HostInfoDAO is unavailable) VM_SERVICE_UNAVAILABLE = Unable to get vm information (VmInfoDAO is unavailable) VM_CPU_SERVICE_NOT_AVAILABLE = Unable to access vm cpu information (VmCpuStats not available) VM_MEMORY_SERVICE_NOT_AVAILABLE = Unable to access vm memory information (VmCpuStats not available) COMMAND_CONNECT_ALREADY_CONNECTED = Already connected to storage: URL = {0}\nPlease use disconnect command to disconnect. COMMAND_CONNECT_FAILED_TO_CONNECT = Could not connect to db {0} COMMAND_CONNECT_INVALID_STORAGE = Unrecognized storage URL {0} COMMAND_CONNECT_NO_KEYRING = Unable to retrieve keyring COMMAND_CONNECT_ERROR = Error: {0} COMMAND_CONNECT_USER_PROMPT_ERROR = Error while prompting for username and password. COMMAND_DISCONNECT_NOT_CONNECTED = Not connected to storage. You may use the connect command for establishing connections. COMMAND_DISCONNECT_ERROR = Failed to disconnect from database. COMMAND_SHELL_IO_EXCEPTION = IOException caught during Thermostat shell session. VM_INFO_VM_ID = VM ID: VM_INFO_PROCESS_ID = Process ID: VM_INFO_START_TIME = Start time: VM_INFO_STOP_TIME = Stop time: VM_INFO_MAIN_CLASS = Main class: VM_INFO_COMMAND_LINE = Command line: VM_INFO_JAVA_VERSION = Java version: VM_INFO_VIRTUAL_MACHINE = Virtual machine: VM_INFO_VM_ARGUMENTS = VM arguments: VM_INFO_USER = User ID: VM_INFO_USER_UNKNOWN = <Unknown> COLUMN_HEADER_HOST_ID = HOST_ID COLUMN_HEADER_HOST = HOST COLUMN_HEADER_VM_ID = VM_ID COLUMN_HEADER_VM_PID = VM_PID COLUMN_HEADER_VM_NAME = VM_NAME COLUMN_HEADER_VM_STATUS = STATUS COLUMN_HEADER_TIME = TIME VM_STOP_TIME_RUNNING = <Running> VM_STATUS_ALIVE = RUNNING VM_STATUS_DEAD = EXITED HOSTID_REQUIRED_MESSAGE = a hostId is required VMID_REQUIRED_MESSAGE = a vmId is required