Mercurial > hg > release > thermostat-0.13
view storage/core/src/main/java/com/redhat/thermostat/storage/internal/dao/VmInfoDAOImpl.java @ 1171:d04860739261
Fix prepared queries (String Keys were missing quotes).
Reviewed-by: ebaron
Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2013-July/007492.html
author | Severin Gehwolf <sgehwolf@redhat.com> |
---|---|
date | Tue, 16 Jul 2013 14:56:10 +0200 |
parents | 340d6f755eb7 |
children | f7961cf1e440 |
line wrap: on
line source
/* * Copyright 2012, 2013 Red Hat, Inc. * * This file is part of Thermostat. * * Thermostat is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published * by the Free Software Foundation; either version 2, or (at your * option) any later version. * * Thermostat is distributed in the hope that it will be useful, but * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. * * You should have received a copy of the GNU General Public License * along with Thermostat; see the file COPYING. If not see * <http://www.gnu.org/licenses/>. * * Linking this code with other modules is making a combined work * based on this code. Thus, the terms and conditions of the GNU * General Public License cover the whole combination. * * As a special exception, the copyright holders of this code give * you permission to link this code with independent modules to * produce an executable, regardless of the license terms of these * independent modules, and to copy and distribute the resulting * executable under terms of your choice, provided that you also * meet, for each linked independent module, the terms and conditions * of the license of that module. An independent module is a module * which is not derived from or based on this code. If you modify * this code, you may extend this exception to your version of the * library, but you are not obligated to do so. If you do not wish * to do so, delete this exception statement from your version. */ package com.redhat.thermostat.storage.internal.dao; import java.util.ArrayList; import java.util.Collection; import java.util.Collections; import java.util.List; import java.util.logging.Level; import java.util.logging.Logger; import com.redhat.thermostat.common.utils.LoggingUtils; import com.redhat.thermostat.storage.core.Cursor; import com.redhat.thermostat.storage.core.DescriptorParsingException; import com.redhat.thermostat.storage.core.HostRef; import com.redhat.thermostat.storage.core.Key; import com.redhat.thermostat.storage.core.PreparedStatement; import com.redhat.thermostat.storage.core.Put; import com.redhat.thermostat.storage.core.StatementDescriptor; import com.redhat.thermostat.storage.core.StatementExecutionException; import com.redhat.thermostat.storage.core.Storage; import com.redhat.thermostat.storage.core.Update; import com.redhat.thermostat.storage.core.VmRef; import com.redhat.thermostat.storage.dao.DAOException; import com.redhat.thermostat.storage.dao.VmInfoDAO; import com.redhat.thermostat.storage.model.VmInfo; import com.redhat.thermostat.storage.query.Expression; import com.redhat.thermostat.storage.query.ExpressionFactory; public class VmInfoDAOImpl implements VmInfoDAO { private final Logger logger = LoggingUtils.getLogger(VmInfoDAOImpl.class); static final String QUERY_VM_INFO = "QUERY " + vmInfoCategory.getName() + " WHERE '" + Key.AGENT_ID.getName() + "' = ?s AND '" + Key.VM_ID.getName() + "' = ?i LIMIT 1"; static final String QUERY_ALL_VMS = "QUERY " + vmInfoCategory.getName() + " WHERE '" + Key.AGENT_ID.getName() + "' = ?s"; private final Storage storage; private final ExpressionFactory factory; public VmInfoDAOImpl(Storage storage) { this.storage = storage; storage.registerCategory(vmInfoCategory); factory = new ExpressionFactory(); } @Override public VmInfo getVmInfo(VmRef ref) { StatementDescriptor<VmInfo> desc = new StatementDescriptor<>(vmInfoCategory, QUERY_VM_INFO); PreparedStatement<VmInfo> stmt; Cursor<VmInfo> cursor; try { stmt = storage.prepareStatement(desc); stmt.setString(0, ref.getAgent().getAgentId()); stmt.setInt(1, ref.getId()); cursor = stmt.executeQuery(); } catch (DescriptorParsingException e) { // should not happen, but if it *does* happen, at least log it logger.log(Level.SEVERE, "Preparing query '" + desc + "' failed!", e); return null; } catch (StatementExecutionException e) { // should not happen, but if it *does* happen, at least log it logger.log(Level.SEVERE, "Executing query '" + desc + "' failed!", e); return null; } VmInfo result; if (cursor.hasNext()) { result = cursor.next(); } else { // FIXME this is inconsistent with null returned elsewhere throw new DAOException("Unknown VM: host:" + ref.getAgent().getAgentId() + ";vm:" + ref.getId()); } return result; } @Override public Collection<VmRef> getVMs(HostRef host) { StatementDescriptor<VmInfo> desc = new StatementDescriptor<>(vmInfoCategory, QUERY_ALL_VMS); PreparedStatement<VmInfo> stmt; Cursor<VmInfo> cursor; try { stmt = storage.prepareStatement(desc); stmt.setString(0, host.getAgentId()); cursor = stmt.executeQuery(); } catch (DescriptorParsingException e) { // should not happen, but if it *does* happen, at least log it logger.log(Level.SEVERE, "Preparing query '" + desc + "' failed!", e); return Collections.emptyList(); } catch (StatementExecutionException e) { // should not happen, but if it *does* happen, at least log it logger.log(Level.SEVERE, "Executing query '" + desc + "' failed!", e); return Collections.emptyList(); } return buildVMsFromQuery(cursor, host); } private Collection<VmRef> buildVMsFromQuery(Cursor<VmInfo> cursor, HostRef host) { List<VmRef> vmRefs = new ArrayList<VmRef>(); while (cursor.hasNext()) { VmInfo vmInfo = cursor.next(); VmRef vm = buildVmRefFromChunk(vmInfo, host); vmRefs.add(vm); } return vmRefs; } private VmRef buildVmRefFromChunk(VmInfo vmInfo, HostRef host) { Integer id = vmInfo.getVmId(); // TODO can we do better than the main class? String mainClass = vmInfo.getMainClass(); VmRef ref = new VmRef(host, id, mainClass); return ref; } @Override public long getCount() { return storage.getCount(vmInfoCategory); } @Override public void putVmInfo(VmInfo info) { Put replace = storage.createReplace(vmInfoCategory); replace.setPojo(info); replace.apply(); } @Override public void putVmStoppedTime(int vmId, long timestamp) { Update update = storage.createUpdate(vmInfoCategory); Expression expr = factory.equalTo(Key.VM_ID, vmId); update.where(expr); update.set(VmInfoDAO.stopTimeKey, timestamp); update.apply(); } }