view netx/net/sourceforge/jnlp/security/CertVerifier.java @ 2127:8c1dc32cd058

RH672262, CVE-2011-0025: IcedTea jarfile signature verification bypass 2011-01-24 Deepak Bhole <dbhole@redhat.com> RH672262, CVE-2011-0025: IcedTea jarfile signature verification bypass * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java (initializeResources): Prompt user only if there is a single certificate that signs all jars in the jnlp file, otherwise treat as unsigned. * rt/net/sourceforge/jnlp/security/CertVerifier.java: Rename getCerts to getCertPath and make it return a CertPath. * rt/net/sourceforge/jnlp/security/CertsInfoPane.java: Rename certs variable to certPath and change its type to CertPath. (buildTree): Use new certPath variable. (populateTable): Same. * rt/net/sourceforge/jnlp/security/HttpsCertVerifier.java: Rename getCerts to getCertPath and make it return a CertPath. * rt/net/sourceforge/jnlp/tools/JarSigner.java: Change type for certs variable to be a hashmap that stores certs and the number of entries they have signed. (totalSignableEntries): New variable to track how many signable entries have been encountered. (getCerts): Updated method to return certs from new hashmap. (isFullySignedByASingleCert): New method. Returns if there is a single cert that signs all the entries in the jars specified in the jnlp file. (verifyJars): Move verifiedJars and unverifiedJars out of the for loop so that the data is not lost when the next jar is processed. After verifying each jar, see if there is a single signer, and prompt the user if there is such an untrusted signer. (verifyJar): Increment totalSignableEntries for each signable entry encountered and the count for each cert when it signs an entry. Move checkTrustedCerts() out of the function into verifyJars().
author Andrew John Hughes <ahughes@redhat.com>
date Tue, 25 Jan 2011 15:39:15 +0000
parents 7fd598f9cf42
children
line wrap: on
line source

/* CertVerifier.java
   Copyright (C) 2009 Red Hat, Inc.

This file is part of IcedTea.

IcedTea is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License as published by
the Free Software Foundation, version 2.

IcedTea is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with IcedTea; see the file COPYING.  If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301 USA.

Linking this library statically or dynamically with other modules is
making a combined work based on this library.  Thus, the terms and
conditions of the GNU General Public License cover the whole
combination.

As a special exception, the copyright holders of this library give you
permission to link this library with independent modules to produce an
executable, regardless of the license terms of these independent
modules, and to copy and distribute the resulting executable under
terms of your choice, provided that you also meet, for each linked
independent module, the terms and conditions of the license of that
module.  An independent module is a module which is not derived from
or based on this library.  If you modify this library, you may extend
this exception to your version of the library, but you are not
obligated to do so.  If you do not wish to do so, delete this
exception statement from your version.
*/

package net.sourceforge.jnlp.security;

import java.security.cert.CertPath;
import java.security.cert.Certificate;
import java.util.ArrayList;

/**
 * An interface that provides various details about a certificate 
 */

public interface CertVerifier {

    /**
     * Return if the publisher is already trusted
     */
    public boolean getAlreadyTrustPublisher();

    /**
     * Return if the root is in CA certs
     */
    public boolean getRootInCacerts();

    /**
     * Return if there are signing issues with the certificate(s) being veried
     */
    public boolean hasSigningIssues();

    /**
     * Return if there are no signing issues with this cert (!hasSigningIssues())
     */
    public boolean noSigningIssues();

    /**
     * Get the details regarding issue(s) with this certificate
     */
    public ArrayList<String> getDetails();

    /**
     * Return a valid certificate path to this certificate(s) being verified
     * @return The CertPath
     */
    public CertPath getCertPath();

    /** 
     * Returns the application's publisher's certificate.
     */
    public abstract Certificate getPublisher();

    /**
     * Returns the application's root's certificate. This
     * may return the same certificate as getPublisher() in
     * the event that the application is self signed.
     */
    public abstract Certificate getRoot();
}