Mercurial > hg > openjdk > jigsaw > langtools
changeset 1736:f4fdd53f8b3e
8005183: Missing accessor for constructor reference pointing to private inner class ctor
Summary: Compiler should add bridges when translating private constructor reference
Reviewed-by: jjg
author | mcimadamore |
---|---|
date | Thu, 21 Feb 2013 15:23:48 +0000 |
parents | 3a39d123d33a |
children | 7ac9242d2ca6 |
files | src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java test/tools/javac/lambda/MethodReference63.java |
diffstat | 2 files changed, 49 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java Thu Feb 21 15:21:38 2013 +0000 +++ b/src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java Thu Feb 21 15:23:48 2013 +0000 @@ -1702,12 +1702,17 @@ return tree.sym.owner == syms.arrayClass; } + boolean isPrivateConstructor() { + return tree.sym.name == names.init && + (tree.sym.flags() & PRIVATE) != 0; + } + /** * Does this reference needs a bridge (i.e. var args need to be * expanded or "super" is used) */ final boolean needsBridge() { - return isSuper || needsVarArgsConversion() || isArrayOp(); + return isSuper || needsVarArgsConversion() || isArrayOp() || isPrivateConstructor(); } Type generatedRefSig() {
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/tools/javac/lambda/MethodReference63.java Thu Feb 21 15:23:48 2013 +0000 @@ -0,0 +1,43 @@ +/* + * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8005183 + * @summary Missing accessor for constructor reference pointing to private inner class ctor + */ +public class MethodReference63 { + + interface SAM { + void m(); + } + + static class Foo { + private Foo() { } + } + + public static void main(String[] args) { + SAM s = Foo::new; + s.m(); + } +}