# HG changeset patch # User Omair Majid # Date 1370016917 14400 # Node ID 49f6272156ffa4ae25e2d24ba54cec5f701aaf3c # Parent 3694f5bb12f52cc476276189368551ddf11192b6 Move command availability to command info Reviewed-by: jerboaa, neugens Review-thread: http://icedtea.classpath.org/pipermail/thermostat/2013-May/006794.html diff -r 3694f5bb12f5 -r 49f6272156ff agent/cli/src/main/java/com/redhat/thermostat/agent/cli/impl/AgentApplication.java --- a/agent/cli/src/main/java/com/redhat/thermostat/agent/cli/impl/AgentApplication.java Fri May 31 15:21:04 2013 +0200 +++ b/agent/cli/src/main/java/com/redhat/thermostat/agent/cli/impl/AgentApplication.java Fri May 31 12:15:17 2013 -0400 @@ -309,11 +309,6 @@ } @Override - public boolean isAvailableInShell() { - return false; - } - - @Override public boolean isStorageRequired() { return false; } diff -r 3694f5bb12f5 -r 49f6272156ff agent/cli/src/main/java/com/redhat/thermostat/agent/cli/impl/ServiceCommand.java --- a/agent/cli/src/main/java/com/redhat/thermostat/agent/cli/impl/ServiceCommand.java Fri May 31 15:21:04 2013 +0200 +++ b/agent/cli/src/main/java/com/redhat/thermostat/agent/cli/impl/ServiceCommand.java Fri May 31 12:15:17 2013 -0400 @@ -120,11 +120,6 @@ } @Override - public boolean isAvailableInShell() { - return false; - } - - @Override public boolean isStorageRequired() { return false; } diff -r 3694f5bb12f5 -r 49f6272156ff agent/cli/src/main/java/com/redhat/thermostat/agent/cli/impl/db/StorageCommand.java --- a/agent/cli/src/main/java/com/redhat/thermostat/agent/cli/impl/db/StorageCommand.java Fri May 31 15:21:04 2013 +0200 +++ b/agent/cli/src/main/java/com/redhat/thermostat/agent/cli/impl/db/StorageCommand.java Fri May 31 12:15:17 2013 -0400 @@ -163,9 +163,5 @@ return false; } - @Override - public boolean isAvailableInShell() { - return false; - } } diff -r 3694f5bb12f5 -r 49f6272156ff client/cli/src/main/java/com/redhat/thermostat/client/cli/internal/ConnectCommand.java --- a/client/cli/src/main/java/com/redhat/thermostat/client/cli/internal/ConnectCommand.java Fri May 31 15:21:04 2013 +0200 +++ b/client/cli/src/main/java/com/redhat/thermostat/client/cli/internal/ConnectCommand.java Fri May 31 12:15:17 2013 -0400 @@ -135,11 +135,6 @@ } @Override - public boolean isAvailableOutsideShell() { - return false; - } - - @Override public boolean isStorageRequired() { return false; } diff -r 3694f5bb12f5 -r 49f6272156ff client/cli/src/main/java/com/redhat/thermostat/client/cli/internal/DisconnectCommand.java --- a/client/cli/src/main/java/com/redhat/thermostat/client/cli/internal/DisconnectCommand.java Fri May 31 15:21:04 2013 +0200 +++ b/client/cli/src/main/java/com/redhat/thermostat/client/cli/internal/DisconnectCommand.java Fri May 31 12:15:17 2013 -0400 @@ -80,11 +80,6 @@ } @Override - public boolean isAvailableOutsideShell() { - return false; - } - - @Override public boolean isStorageRequired() { return false; } diff -r 3694f5bb12f5 -r 49f6272156ff client/cli/src/main/java/com/redhat/thermostat/client/cli/internal/ShellCommand.java --- a/client/cli/src/main/java/com/redhat/thermostat/client/cli/internal/ShellCommand.java Fri May 31 15:21:04 2013 +0200 +++ b/client/cli/src/main/java/com/redhat/thermostat/client/cli/internal/ShellCommand.java Fri May 31 12:15:17 2013 -0400 @@ -181,10 +181,5 @@ return false; } - @Override - public boolean isAvailableInShell() { - return false; - } - } diff -r 3694f5bb12f5 -r 49f6272156ff client/cli/src/test/java/com/redhat/thermostat/client/cli/internal/ConnectCommandTest.java --- a/client/cli/src/test/java/com/redhat/thermostat/client/cli/internal/ConnectCommandTest.java Fri May 31 15:21:04 2013 +0200 +++ b/client/cli/src/test/java/com/redhat/thermostat/client/cli/internal/ConnectCommandTest.java Fri May 31 12:15:17 2013 -0400 @@ -155,15 +155,5 @@ assertFalse(cmd.isStorageRequired()); } - @Test - public void testIsNotAvailableOutsideShell() { - assertFalse(cmd.isAvailableOutsideShell()); - } - - @Test - public void testIsAvailableInShell() { - assertTrue(cmd.isAvailableInShell()); - } - } diff -r 3694f5bb12f5 -r 49f6272156ff client/cli/src/test/java/com/redhat/thermostat/client/cli/internal/DisconnectCommandTest.java --- a/client/cli/src/test/java/com/redhat/thermostat/client/cli/internal/DisconnectCommandTest.java Fri May 31 15:21:04 2013 +0200 +++ b/client/cli/src/test/java/com/redhat/thermostat/client/cli/internal/DisconnectCommandTest.java Fri May 31 12:15:17 2013 -0400 @@ -98,16 +98,6 @@ } @Test - public void testIsNotAvailableOutsideShell() { - assertFalse(cmd.isAvailableOutsideShell()); - } - - @Test - public void testIsAvailableInShell() { - assertTrue(cmd.isAvailableInShell()); - } - - @Test public void testIsStorageRequired() { assertFalse(cmd.isStorageRequired()); } diff -r 3694f5bb12f5 -r 49f6272156ff client/swing/src/main/java/com/redhat/thermostat/client/swing/internal/GUIClientCommand.java --- a/client/swing/src/main/java/com/redhat/thermostat/client/swing/internal/GUIClientCommand.java Fri May 31 15:21:04 2013 +0200 +++ b/client/swing/src/main/java/com/redhat/thermostat/client/swing/internal/GUIClientCommand.java Fri May 31 12:15:17 2013 -0400 @@ -59,10 +59,5 @@ return false; } - @Override - public boolean isAvailableInShell() { - return false; - } - } diff -r 3694f5bb12f5 -r 49f6272156ff common/core/src/main/java/com/redhat/thermostat/common/cli/AbstractCommand.java --- a/common/core/src/main/java/com/redhat/thermostat/common/cli/AbstractCommand.java Fri May 31 15:21:04 2013 +0200 +++ b/common/core/src/main/java/com/redhat/thermostat/common/cli/AbstractCommand.java Fri May 31 12:15:17 2013 -0400 @@ -52,15 +52,5 @@ return true; } - @Override - public boolean isAvailableInShell() { - return true; - } - - @Override - public boolean isAvailableOutsideShell() { - return true; - } - } diff -r 3694f5bb12f5 -r 49f6272156ff common/core/src/main/java/com/redhat/thermostat/common/cli/Command.java --- a/common/core/src/main/java/com/redhat/thermostat/common/cli/Command.java Fri May 31 15:21:04 2013 +0200 +++ b/common/core/src/main/java/com/redhat/thermostat/common/cli/Command.java Fri May 31 12:15:17 2013 -0400 @@ -74,18 +74,5 @@ */ public boolean isStorageRequired(); - /** - * Whether the command is available to be invoked from within the shell. - * @return true if the command can be invoked from within the shell - */ - public boolean isAvailableInShell(); - - /** - * Indicates if the command is available to be invoked from outside the - * shell (as an argument to the main thermostat program). - * @return true if can command can be invoked from the command line - */ - public boolean isAvailableOutsideShell(); - } diff -r 3694f5bb12f5 -r 49f6272156ff common/core/src/test/java/com/redhat/thermostat/common/cli/AbstractCommandTest.java --- a/common/core/src/test/java/com/redhat/thermostat/common/cli/AbstractCommandTest.java Fri May 31 15:21:04 2013 +0200 +++ b/common/core/src/test/java/com/redhat/thermostat/common/cli/AbstractCommandTest.java Fri May 31 12:15:17 2013 -0400 @@ -48,8 +48,6 @@ AbstractCommand command = createCommandForTest(); assertTrue(command.isStorageRequired()); - assertTrue(command.isAvailableInShell()); - assertTrue(command.isAvailableOutsideShell()); } private AbstractCommand createCommandForTest() { diff -r 3694f5bb12f5 -r 49f6272156ff distribution/config/commands/agent.properties --- a/distribution/config/commands/agent.properties Fri May 31 15:21:04 2013 +0200 +++ b/distribution/config/commands/agent.properties Fri May 31 12:15:17 2013 -0400 @@ -30,3 +30,5 @@ saveOnExit.description = save the data on exit saveOnExit.required = false saveOnExit.hasarg = false + +environments = cli diff -r 3694f5bb12f5 -r 49f6272156ff distribution/config/commands/connect.properties --- a/distribution/config/commands/connect.properties Fri May 31 15:21:04 2013 +0200 +++ b/distribution/config/commands/connect.properties Fri May 31 12:15:17 2013 -0400 @@ -19,3 +19,5 @@ options = AUTO_LOG_OPTION, AUTO_DB_OPTIONS, dbUrl dbUrl.required = true + +environments = shell diff -r 3694f5bb12f5 -r 49f6272156ff distribution/config/commands/disconnect.properties --- a/distribution/config/commands/disconnect.properties Fri May 31 15:21:04 2013 +0200 +++ b/distribution/config/commands/disconnect.properties Fri May 31 12:15:17 2013 -0400 @@ -5,3 +5,5 @@ usage = disconnect [-l ] options = AUTO_LOG_OPTION + +environments = shell diff -r 3694f5bb12f5 -r 49f6272156ff distribution/config/commands/gui.properties --- a/distribution/config/commands/gui.properties Fri May 31 15:21:04 2013 +0200 +++ b/distribution/config/commands/gui.properties Fri May 31 12:15:17 2013 -0400 @@ -27,3 +27,5 @@ usage = gui [-l ] options = AUTO_LOG_OPTION + +environments = cli diff -r 3694f5bb12f5 -r 49f6272156ff distribution/config/commands/help.properties --- a/distribution/config/commands/help.properties Fri May 31 15:21:04 2013 +0200 +++ b/distribution/config/commands/help.properties Fri May 31 12:15:17 2013 -0400 @@ -5,3 +5,5 @@ # This command does not have any options #options = + +environments = cli, shell diff -r 3694f5bb12f5 -r 49f6272156ff distribution/config/commands/list-vms.properties --- a/distribution/config/commands/list-vms.properties Fri May 31 15:21:04 2013 +0200 +++ b/distribution/config/commands/list-vms.properties Fri May 31 12:15:17 2013 -0400 @@ -17,3 +17,5 @@ # This command does not have any options options = AUTO_DB_OPTIONS, AUTO_LOG_OPTION + +environments = cli, shell diff -r 3694f5bb12f5 -r 49f6272156ff distribution/config/commands/ping.properties --- a/distribution/config/commands/ping.properties Fri May 31 15:21:04 2013 +0200 +++ b/distribution/config/commands/ping.properties Fri May 31 12:15:17 2013 -0400 @@ -18,3 +18,5 @@ usage = ping [-d ] [-l ] options = AUTO_DB_OPTIONS, AUTO_LOG_OPTION + +environments = cli, shell diff -r 3694f5bb12f5 -r 49f6272156ff distribution/config/commands/service.properties --- a/distribution/config/commands/service.properties Fri May 31 15:21:04 2013 +0200 +++ b/distribution/config/commands/service.properties Fri May 31 12:15:17 2013 -0400 @@ -16,3 +16,5 @@ usage = service [-l ] options = AUTO_LOG_OPTION + +environments = cli diff -r 3694f5bb12f5 -r 49f6272156ff distribution/config/commands/shell.properties --- a/distribution/config/commands/shell.properties Fri May 31 15:21:04 2013 +0200 +++ b/distribution/config/commands/shell.properties Fri May 31 12:15:17 2013 -0400 @@ -7,3 +7,5 @@ # This command does not have any options #options = + +environments = cli diff -r 3694f5bb12f5 -r 49f6272156ff distribution/config/commands/storage.properties --- a/distribution/config/commands/storage.properties Fri May 31 15:21:04 2013 +0200 +++ b/distribution/config/commands/storage.properties Fri May 31 12:15:17 2013 -0400 @@ -33,3 +33,5 @@ quiet.hasarg = false quiet.required = false quiet.description = don't produce any output + +environments = cli diff -r 3694f5bb12f5 -r 49f6272156ff distribution/config/commands/vm-info.properties --- a/distribution/config/commands/vm-info.properties Fri May 31 15:21:04 2013 +0200 +++ b/distribution/config/commands/vm-info.properties Fri May 31 12:15:17 2013 -0400 @@ -28,3 +28,5 @@ vmId.hasarg = true vmId.required = false vmId.description = the ID of the VM to monitor + +environments= cli, shell diff -r 3694f5bb12f5 -r 49f6272156ff distribution/config/commands/vm-stat.properties --- a/distribution/config/commands/vm-stat.properties Fri May 31 15:21:04 2013 +0200 +++ b/distribution/config/commands/vm-stat.properties Fri May 31 12:15:17 2013 -0400 @@ -34,3 +34,5 @@ continuous.hasarg = false continuous.required = false continuous.description = print data continuously + +environments = cli, shell diff -r 3694f5bb12f5 -r 49f6272156ff distribution/config/commands/webservice.properties --- a/distribution/config/commands/webservice.properties Fri May 31 15:21:04 2013 +0200 +++ b/distribution/config/commands/webservice.properties Fri May 31 12:15:17 2013 -0400 @@ -40,3 +40,5 @@ bindAddrs.required = true bindAddrs.description = A comma separated list of IP address, \ port pairs used for binding (e.g. 127.0.0.1:8888,127.0.0.1:8889) + +environments = cli diff -r 3694f5bb12f5 -r 49f6272156ff distribution/docs/thermostat-plugin.xsd --- a/distribution/docs/thermostat-plugin.xsd Fri May 31 15:21:04 2013 +0200 +++ b/distribution/docs/thermostat-plugin.xsd Fri May 31 12:15:17 2013 -0400 @@ -67,6 +67,7 @@ + @@ -120,6 +121,30 @@ + + + + + + + + + + + + + + Indicates that the command is available to be invoked from within the thermostat shell. + + + + + Indicates that the command is available to be invoked as an argument to the main thermostat program. + + + + + diff -r 3694f5bb12f5 -r 49f6272156ff integration-tests/src/test/java/com/redhat/thermostat/itest/PluginTest.java --- a/integration-tests/src/test/java/com/redhat/thermostat/itest/PluginTest.java Fri May 31 15:21:04 2013 +0200 +++ b/integration-tests/src/test/java/com/redhat/thermostat/itest/PluginTest.java Fri May 31 12:15:17 2013 -0400 @@ -122,6 +122,10 @@ " " + " " + command + "" + " " + description + "" + + " " + + " shell" + + " cli" + + " " + " " + " \n" + " \n" + + " " + + " shell" + + " cli" + + " " + " \n" + " \n \t \nfoo\t \n \n\n" + " \tbar baz\n\n" + @@ -422,6 +448,10 @@ " some required and long option\n" + " \n" + " \n" + + " " + + " shell" + + " cli" + + " " + " \n" + " \n" + ""; @@ -471,6 +501,10 @@ " \n" + " test\n" + " just a test\n" + + " " + + " shell" + + " cli" + + " " + " \n" + " + + cli + shell + thermostat-vm-heap-analysis-common-${project.version}.jar thermostat-vm-heap-analysis-command-${project.version}.jar @@ -170,6 +178,10 @@ logLevel + + cli + shell + thermostat-vm-heap-analysis-common-${project.version}.jar thermostat-vm-heap-analysis-command-${project.version}.jar @@ -218,6 +230,10 @@ logLevel + + cli + shell + thermostat-vm-heap-analysis-common-${project.version}.jar thermostat-vm-heap-analysis-command-${project.version}.jar @@ -266,6 +282,10 @@ logLevel + + cli + shell + thermostat-vm-heap-analysis-common-${project.version}.jar thermostat-vm-heap-analysis-command-${project.version}.jar @@ -314,6 +334,10 @@ logLevel + + cli + shell + thermostat-vm-heap-analysis-common-${project.version}.jar thermostat-vm-heap-analysis-command-${project.version}.jar @@ -355,6 +379,10 @@ logLevel + + cli + shell + thermostat-vm-heap-analysis-common-${project.version}.jar thermostat-vm-heap-analysis-command-${project.version}.jar diff -r 3694f5bb12f5 -r 49f6272156ff web/cmd/src/main/java/com/redhat/thermostat/web/cmd/WebServiceCommand.java --- a/web/cmd/src/main/java/com/redhat/thermostat/web/cmd/WebServiceCommand.java Fri May 31 15:21:04 2013 +0200 +++ b/web/cmd/src/main/java/com/redhat/thermostat/web/cmd/WebServiceCommand.java Fri May 31 12:15:17 2013 -0400 @@ -91,11 +91,6 @@ return false; } - @Override - public boolean isAvailableInShell() { - return false; - } - private List parseIPsPorts(String rawIpsPorts) throws CommandException { HostPortsParser parser = new HostPortsParser(rawIpsPorts); parser.parse();