# HG changeset patch # User aeubanks # Date 1566256108 25200 # Node ID 15a134ed08c4b0f3b2a89835959c3bf5d45cddaf # Parent aadfefa63ebc0d7d4b03a22121f974dafeaf55db 8229899: Make java.io.File.isInvalid() less racy Reviewed-by: alanb, martin, shade diff -r aadfefa63ebc -r 15a134ed08c4 src/share/classes/java/io/File.java --- a/src/share/classes/java/io/File.java Wed May 06 21:01:10 2020 +0200 +++ b/src/share/classes/java/io/File.java Mon Aug 19 16:08:28 2019 -0700 @@ -183,11 +183,13 @@ * @return true if the file path is invalid. */ final boolean isInvalid() { - if (status == null) { - status = (this.path.indexOf('\u0000') < 0) ? PathStatus.CHECKED - : PathStatus.INVALID; + PathStatus s = status; + if (s == null) { + s = (this.path.indexOf('\u0000') < 0) ? PathStatus.CHECKED + : PathStatus.INVALID; + status = s; } - return status == PathStatus.INVALID; + return s == PathStatus.INVALID; } /**