# HG changeset patch # User khazra # Date 1363811996 25200 # Node ID ad785fb5f898bf17a5ff7c27f72c9858ca290bac # Parent 1d48c0d0a0a2d955b234f128404d6472abc2cf37 8010213: Some api/javax_net/SocketFactory tests fail in 7u25 nightly build Summary: Eliminate fall-through while setting socket options on Windows Reviewed-by: alanb, chegar diff -r 1d48c0d0a0a2 -r ad785fb5f898 src/windows/classes/java/net/DualStackPlainSocketImpl.java --- a/src/windows/classes/java/net/DualStackPlainSocketImpl.java Wed Apr 10 14:28:10 2013 +0400 +++ b/src/windows/classes/java/net/DualStackPlainSocketImpl.java Wed Mar 20 13:39:56 2013 -0700 @@ -184,14 +184,15 @@ int optionValue = 0; switch(opt) { - case TCP_NODELAY : - case SO_OOBINLINE : case SO_REUSEADDR : if (exclusiveBind) { // SO_REUSEADDR emulated when using exclusive bind isReuseAddress = on; return; } + // intentional fallthrough + case TCP_NODELAY : + case SO_OOBINLINE : case SO_KEEPALIVE : optionValue = on ? 1 : 0; break;