# HG changeset patch # User Omair Majid # Date 1325922485 18000 # Node ID f0647c9385358b4fc3fe747ba7b95b9117c2f681 # Parent 9f7d46c3314de3946052e78ddf779b878246c867 fix findbugs cloud jnlps Someone reported that the following JNLP was not starting: http://findbugs.cs.umd.edu/cloud/eclipse.jnlp The attached fixes the problem, which was that (in the extension jnlp file) the jnlp element did not contain a codebase attribute. IcedTea-Web tried to add this null codebase when merging the jnlp file, causing an exception. The patch simply ignores this null. ChangeLog: 2012-01-07 Omair Majid * netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java (addToCodeBaseLoader): Do not try to process null urls. diff -r 9f7d46c3314d -r f0647c938535 ChangeLog --- a/ChangeLog Thu Dec 22 16:15:54 2011 -0500 +++ b/ChangeLog Sat Jan 07 02:48:05 2012 -0500 @@ -1,3 +1,8 @@ +2012-01-07 Omair Majid + + * netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java + (addToCodeBaseLoader): Do not try to process null urls. + 2011-12-22 Thomas Meyer * plugin/icedteanp/IcedTeaPluginRequestProcessor.cc(sendMember): Use diff -r 9f7d46c3314d -r f0647c938535 netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java --- a/netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java Thu Dec 22 16:15:54 2011 -0500 +++ b/netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java Sat Jan 07 02:48:05 2012 -0500 @@ -1413,6 +1413,9 @@ * @throws IllegalArgumentException If the given url is not a path */ private void addToCodeBaseLoader(URL u) { + if (u == null) { + return; + } // Only paths may be added if (!u.getFile().endsWith("/")) {