# HG changeset patch # User mikael # Date 1392774904 28800 # Node ID 801743983ed6e7b5336f03a7570fc15dc78b3b3b # Parent dc8461142fb8aa10775dba9d29e0f1d9c5802886 8035287: gcc warnings compiling various libraries files Reviewed-by: prr diff -r dc8461142fb8 -r 801743983ed6 src/share/native/com/sun/java/util/jar/pack/bands.cpp --- a/src/share/native/com/sun/java/util/jar/pack/bands.cpp Mon Mar 16 18:08:01 2015 +0800 +++ b/src/share/native/com/sun/java/util/jar/pack/bands.cpp Tue Feb 18 17:55:04 2014 -0800 @@ -288,7 +288,7 @@ { e_##name, #name, /*debug only*/ \ cspec, ix } -const band_init all_band_inits[] = { +const band_init all_band_inits[BAND_LIMIT+1] = { //BAND_INIT(archive_magic, BYTE1_spec, 0), //BAND_INIT(archive_header, UNSIGNED5_spec, 0), //BAND_INIT(band_headers, BYTE1_spec, 0), @@ -448,14 +448,8 @@ BAND_INIT(file_modtime, DELTA5_spec, 0), BAND_INIT(file_options, UNSIGNED5_spec, 0), //BAND_INIT(file_bits, BYTE1_spec, 0), -#ifndef PRODUCT - { 0, 0, 0, 0 } -#else - { 0, 0 } -#endif + { 0, NULL, 0, 0 } }; -#define NUM_BAND_INITS \ - (sizeof(all_band_inits)/sizeof(all_band_inits[0])) band* band::makeBands(unpacker* u) { band* tmp_all_bands = U_NEW(band, BAND_LIMIT); diff -r dc8461142fb8 -r 801743983ed6 src/share/native/sun/java2d/opengl/OGLContext.c --- a/src/share/native/sun/java2d/opengl/OGLContext.c Mon Mar 16 18:08:01 2015 +0800 +++ b/src/share/native/sun/java2d/opengl/OGLContext.c Tue Feb 18 17:55:04 2014 -0800 @@ -38,6 +38,8 @@ #include "GraphicsPrimitiveMgr.h" #include "Region.h" +#include "jvm.h" + /** * The following methods are implemented in the windowing system (i.e. GLX * and WGL) source files. diff -r dc8461142fb8 -r 801743983ed6 src/solaris/native/sun/awt/awt_Font.c --- a/src/solaris/native/sun/awt/awt_Font.c Mon Mar 16 18:08:01 2015 +0800 +++ b/src/solaris/native/sun/awt/awt_Font.c Tue Feb 18 17:55:04 2014 -0800 @@ -454,6 +454,7 @@ int32_t i, size; char *fontsetname = NULL; char *nativename = NULL; + Boolean doFree = FALSE; jobjectArray componentFonts = NULL; jobject peer = NULL; jobject fontDescriptor = NULL; @@ -493,8 +494,10 @@ if (!JNU_IsNull(env, fontDescriptorName)) { nativename = (char *) JNU_GetStringPlatformChars(env, fontDescriptorName, NULL); + doFree = TRUE; } else { nativename = ""; + doFree = FALSE; } fdata->flist[i].xlfd = malloc(strlen(nativename) @@ -502,7 +505,7 @@ jio_snprintf(fdata->flist[i].xlfd, strlen(nativename) + 10, nativename, size * 10); - if (nativename != NULL && nativename != "") + if (nativename != NULL && doFree) JNU_ReleaseStringPlatformChars(env, fontDescriptorName, (const char *) nativename); /* diff -r dc8461142fb8 -r 801743983ed6 src/solaris/native/sun/java2d/x11/X11SurfaceData.c --- a/src/solaris/native/sun/java2d/x11/X11SurfaceData.c Mon Mar 16 18:08:01 2015 +0800 +++ b/src/solaris/native/sun/java2d/x11/X11SurfaceData.c Tue Feb 18 17:55:04 2014 -0800 @@ -545,7 +545,7 @@ xsdo->cData = xsdo->configData->color_data; XShared_initSurface(env, xsdo, depth, width, height, drawable); - xsdo->xrPic = NULL; + xsdo->xrPic = None; #endif /* !HEADLESS */ } diff -r dc8461142fb8 -r 801743983ed6 src/solaris/native/sun/xawt/XToolkit.c --- a/src/solaris/native/sun/xawt/XToolkit.c Mon Mar 16 18:08:01 2015 +0800 +++ b/src/solaris/native/sun/xawt/XToolkit.c Tue Feb 18 17:55:04 2014 -0800 @@ -716,7 +716,7 @@ if (pollFds[0].revents) { // Events in X pipe update_poll_timeout(TIMEOUT_EVENTS); - PRINT2("performPoll(): TIMEOUT_EVENTS curPollTimeout = %ld \n", curPollTimeout); + PRINT2("performPoll(): TIMEOUT_EVENTS curPollTimeout = %d \n", curPollTimeout); } return TRUE;