# HG changeset patch # User sundar # Date 1382444276 -19800 # Node ID d04028e6b624285e4b1455d7f3a2baa750705905 # Parent f22742d5daa358a645f81c3d8294a77f2a1ec372# Parent 360761288b38f564b6fb719008a2fb712bdcffa6 Merge diff -r f22742d5daa3 -r d04028e6b624 src/jdk/nashorn/internal/objects/NativeArray.java --- a/src/jdk/nashorn/internal/objects/NativeArray.java Mon Oct 21 13:31:03 2013 +0400 +++ b/src/jdk/nashorn/internal/objects/NativeArray.java Tue Oct 22 17:47:56 2013 +0530 @@ -1163,12 +1163,16 @@ try { final ScriptObject sobj = (ScriptObject)Global.toObject(self); final long len = JSType.toUint32(sobj.getLength()); - final long n = JSType.toLong(fromIndex); - - if (len == 0 || n >= len) { + if (len == 0) { return -1; } + final long n = JSType.toLong(fromIndex); + if (n >= len) { + return -1; + } + + for (long k = Math.max(0, (n < 0) ? (len - Math.abs(n)) : n); k < len; k++) { if (sobj.has(k)) { if (ScriptRuntime.EQ_STRICT(sobj.get(k), searchElement)) { diff -r f22742d5daa3 -r d04028e6b624 src/jdk/nashorn/internal/objects/NativeString.java --- a/src/jdk/nashorn/internal/objects/NativeString.java Mon Oct 21 13:31:03 2013 +0400 +++ b/src/jdk/nashorn/internal/objects/NativeString.java Tue Oct 22 17:47:56 2013 +0530 @@ -505,7 +505,7 @@ */ @Function(attributes = Attribute.NOT_ENUMERABLE) public static Object charAt(final Object self, final Object pos) { - return charAt(self, JSType.toInteger(pos)); + return charAtImpl(checkObjectToString(self), JSType.toInteger(pos)); } /** @@ -527,7 +527,10 @@ */ @SpecializedFunction public static String charAt(final Object self, final int pos) { - final String str = checkObjectToString(self); + return charAtImpl(checkObjectToString(self), pos); + } + + private static String charAtImpl(final String str, final int pos) { return (pos < 0 || pos >= str.length()) ? "" : String.valueOf(str.charAt(pos)); } @@ -539,7 +542,7 @@ */ @Function(attributes = Attribute.NOT_ENUMERABLE) public static Object charCodeAt(final Object self, final Object pos) { - return charCodeAt(self, JSType.toInteger(pos)); + return charCodeAtImpl(checkObjectToString(self), JSType.toInteger(pos)); } /** @@ -561,7 +564,10 @@ */ @SpecializedFunction public static double charCodeAt(final Object self, final int pos) { - final String str = checkObjectToString(self); + return charCodeAtImpl(checkObjectToString(self), pos); + } + + private static double charCodeAtImpl(final String str, final int pos) { return (pos < 0 || pos >= str.length()) ? Double.NaN : str.charAt(pos); } diff -r f22742d5daa3 -r d04028e6b624 src/jdk/nashorn/internal/runtime/ScriptRuntime.java --- a/src/jdk/nashorn/internal/runtime/ScriptRuntime.java Mon Oct 21 13:31:03 2013 +0400 +++ b/src/jdk/nashorn/internal/runtime/ScriptRuntime.java Tue Oct 22 17:47:56 2013 +0530 @@ -47,6 +47,7 @@ import jdk.nashorn.api.scripting.ScriptObjectMirror; import jdk.nashorn.internal.codegen.CompilerConstants.Call; import jdk.nashorn.internal.ir.debug.JSONWriter; +import jdk.nashorn.internal.objects.Global; import jdk.nashorn.internal.parser.Lexer; import jdk.nashorn.internal.runtime.linker.Bootstrap; @@ -258,6 +259,11 @@ return ((Map,?>)obj).keySet().iterator(); } + final Object wrapped = Global.instance().wrapAsObject(obj); + if (wrapped instanceof ScriptObject) { + return ((ScriptObject)wrapped).propertyIterator(); + } + return Collections.emptyIterator(); } @@ -336,6 +342,11 @@ return ((Iterable>)obj).iterator(); } + final Object wrapped = Global.instance().wrapAsObject(obj); + if (wrapped instanceof ScriptObject) { + return ((ScriptObject)wrapped).valueIterator(); + } + return Collections.emptyIterator(); } diff -r f22742d5daa3 -r d04028e6b624 src/overview.html --- a/src/overview.html Mon Oct 21 13:31:03 2013 +0400 +++ b/src/overview.html Tue Oct 22 17:47:56 2013 +0530 @@ -108,6 +108,6 @@