# HG changeset patch # User sadayapalam # Date 1449748499 -19800 # Node ID 60205b73466d984bcf616b03dd38c6e07c11124b # Parent 004d36edd8c9d4b3b664b1056e014e5873bfb958 8145051: Wrong parameter name in synthetic lambda method leads to verifier error Summary: Synthetic names manufactured by the compiler should not contain '.' Reviewed-by: mcimadamore diff -r 004d36edd8c9 -r 60205b73466d src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java --- a/src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java Mon Feb 08 06:17:19 2021 +0000 +++ b/src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java Thu Dec 10 17:24:59 2015 +0530 @@ -1988,7 +1988,7 @@ }; break; case CAPTURED_OUTER_THIS: - Name name = names.fromString(new String(sym.flatName().toString() + names.dollarThis)); + Name name = names.fromString(new String(sym.flatName().toString().replace('.', '$') + names.dollarThis)); ret = new VarSymbol(SYNTHETIC | FINAL | PARAMETER, name, types.erasure(sym.type), translatedSym) { @Override public Symbol baseSymbol() { diff -r 004d36edd8c9 -r 60205b73466d test/tools/javac/lambda/T8145051.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/tools/javac/lambda/T8145051.java Thu Dec 10 17:24:59 2015 +0530 @@ -0,0 +1,43 @@ +/* + * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8145051 + * @summary Wrong parameter name in synthetic lambda method leads to verifier error + * @compile pkg/T8145051.java + * @run main/othervm -Xverify:all T8145051 + */ + +public class T8145051 { + + public static void main(String [] args) { + pkg.T8145051 t8145051 = new pkg.T8145051(); + t8145051.new Sub(); + if (!t8145051.s.equals("Executed lambda")) + throw new AssertionError("Unexpected data"); + else + System.out.println("OK"); + } + +} diff -r 004d36edd8c9 -r 60205b73466d test/tools/javac/lambda/pkg/T8145051.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/tools/javac/lambda/pkg/T8145051.java Thu Dec 10 17:24:59 2015 +0530 @@ -0,0 +1,43 @@ +/* + * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +package pkg; + +public class T8145051 { + + public String s; + + public static class Sup { + Sup(Runnable r) { + r.run(); + } + } + + public class Sub extends Sup { + public Sub() { + super(() -> { + s = "Executed lambda"; + }); + } + } +}